[ADF-1287] compatibility with the new noUnusedLocals rule (#2170)

* support for noUnusedLocals rule

* clean diagram components

* code cleanup

* Viewer fixes

* code fixes

* code fixes
This commit is contained in:
Denys Vuika
2017-08-04 15:35:15 +01:00
committed by Mario Romano
parent 0f239a1fa3
commit 9d3962b3b5
113 changed files with 190 additions and 346 deletions

View File

@@ -26,7 +26,8 @@
"@angular/*": ["node_modules/@angular/*"],
"rxjs/*": ["node_modules/rxjs/*"]
},
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -45,7 +45,6 @@ export const ANALYTICS_PROVIDERS: any[] = [
];
declare let jasmine: any;
declare let mdDateTimePicker: any;
describe('AnalyticsGeneratorComponent', () => {

View File

@@ -16,7 +16,7 @@
*/
import { Component, EventEmitter, Input, OnChanges, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Chart } from '../models/chart.model';
import { ReportQuery } from '../models/report.model';
import { AnalyticsService } from '../services/analytics.service';
@@ -62,10 +62,8 @@ export class AnalyticsGeneratorComponent implements OnChanges {
}
};
constructor(private translateService: AlfrescoTranslationService,
private analyticsService: AnalyticsService,
private logService: LogService) {
logService.info('AnalyticsGeneratorComponent');
constructor(translateService: AlfrescoTranslationService,
private analyticsService: AnalyticsService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-analytics', 'assets/ng2-activiti-analytics');
}

View File

@@ -42,7 +42,7 @@ export class AnalyticsReportHeatMapComponent implements OnInit {
currentMetricColors: string;
metricType: string;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private analyticsService: AnalyticsService,
private formBuilder: FormBuilder) {
if (translateService) {

View File

@@ -16,7 +16,6 @@
*/
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { LogService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { ReportParametersModel } from '../models/report.model';
import { AnalyticsService } from '../services/analytics.service';
@@ -56,8 +55,7 @@ export class AnalyticsReportListComponent implements OnInit {
reports: ReportParametersModel[] = [];
constructor(private analyticsService: AnalyticsService,
private logService: LogService) {
constructor(private analyticsService: AnalyticsService) {
this.report$ = new Observable<ReportParametersModel>(observer => this.reportObserver = observer).share();
}

View File

@@ -29,7 +29,6 @@ import { ReportParametersModel } from '../models/report.model';
import { AnalyticsService } from '../services/analytics.service';
declare let jasmine: any;
declare let mdDateTimePicker: any;
describe('AnalyticsReportParametersComponent', () => {
@@ -521,14 +520,14 @@ describe('AnalyticsReportParametersComponent', () => {
it('Should show a dialog to allowing report save', async(() => {
component.saveReportSuccess.subscribe((repId) => {
let reportDialogTitle: HTMLElement = <HTMLElement>element.querySelector('#report-dialog');
let reportDialogTitle: HTMLElement = <HTMLElement> element.querySelector('#report-dialog');
expect(reportDialogTitle.getAttribute('open')).toBeNull();
expect(repId).toBe('1');
});
component.submit(values);
fixture.detectChanges();
let saveButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#save-button');
let saveButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#save-button');
expect(saveButton).toBeDefined();
expect(saveButton).not.toBeNull();
saveButton.click();
@@ -537,10 +536,10 @@ describe('AnalyticsReportParametersComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
let reportDialogTitle: HTMLElement = <HTMLElement>element.querySelector('#report-dialog-title');
let reportDialogTitle: HTMLElement = <HTMLElement> element.querySelector('#report-dialog-title');
let saveTitleSubMessage: HTMLElement = <HTMLElement> element.querySelector('#save-title-submessage');
let inputSaveName: HTMLInputElement = <HTMLInputElement> element.querySelector('#repName');
let performActionButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#action-dialog-button');
let performActionButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#action-dialog-button');
let todayDate = component.getTodayDate();
expect(reportDialogTitle).not.toBeNull();
@@ -560,7 +559,7 @@ describe('AnalyticsReportParametersComponent', () => {
it('Should show a dialog to allowing report export', async(() => {
component.submit(values);
fixture.detectChanges();
let exportButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#export-button');
let exportButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#export-button');
expect(exportButton).toBeDefined();
expect(exportButton).not.toBeNull();
@@ -570,9 +569,9 @@ describe('AnalyticsReportParametersComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
let reportDialogTitle: HTMLElement = <HTMLElement>element.querySelector('#report-dialog-title');
let reportDialogTitle: HTMLElement = <HTMLElement> element.querySelector('#report-dialog-title');
let inputSaveName: HTMLInputElement = <HTMLInputElement> element.querySelector('#repName');
let performActionButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#action-dialog-button');
let performActionButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#action-dialog-button');
let todayDate = component.getTodayDate();
expect(reportDialogTitle).not.toBeNull();
@@ -589,7 +588,7 @@ describe('AnalyticsReportParametersComponent', () => {
}));
it('Should raise an event for report deleted', async(() => {
let deleteButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#delete-button');
let deleteButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#delete-button');
expect(deleteButton).toBeDefined();
expect(deleteButton).not.toBeNull();
@@ -606,7 +605,7 @@ describe('AnalyticsReportParametersComponent', () => {
}));
it('Should hide export button if the form is not valid', async(() => {
let exportButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#export-button');
let exportButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#export-button');
expect(exportButton).toBeDefined();
expect(exportButton).not.toBeNull();
validForm = false;
@@ -615,13 +614,13 @@ describe('AnalyticsReportParametersComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
exportButton = <HTMLButtonElement>element.querySelector('#export-button');
exportButton = <HTMLButtonElement> element.querySelector('#export-button');
expect(exportButton).toBeNull();
});
}));
it('Should hide save button if the form is not valid', async(() => {
let saveButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#save-button');
let saveButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#save-button');
expect(saveButton).toBeDefined();
expect(saveButton).not.toBeNull();
validForm = false;
@@ -630,7 +629,7 @@ describe('AnalyticsReportParametersComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
saveButton = <HTMLButtonElement>element.querySelector('#save-button');
saveButton = <HTMLButtonElement> element.querySelector('#save-button');
expect(saveButton).toBeNull();
});
}));
@@ -638,8 +637,8 @@ describe('AnalyticsReportParametersComponent', () => {
it('Should show export and save button when the form became valid', async(() => {
validForm = false;
fixture.detectChanges();
let saveButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#save-button');
let exportButton: HTMLButtonElement = <HTMLButtonElement>element.querySelector('#export-button');
let saveButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#save-button');
let exportButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#export-button');
expect(saveButton).toBeNull();
expect(exportButton).toBeNull();
validForm = true;
@@ -647,8 +646,8 @@ describe('AnalyticsReportParametersComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
saveButton = <HTMLButtonElement>element.querySelector('#save-button');
exportButton = <HTMLButtonElement>element.querySelector('#export-button');
saveButton = <HTMLButtonElement> element.querySelector('#save-button');
exportButton = <HTMLButtonElement> element.querySelector('#export-button');
expect(saveButton).not.toBeNull();
expect(saveButton).toBeDefined();

View File

@@ -107,7 +107,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
private hideParameters: boolean = true;
private formValidState: boolean = false;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private analyticsService: AnalyticsService,
private formBuilder: FormBuilder,
private logService: LogService,

View File

@@ -43,7 +43,6 @@ export const ANALYTICS_PROVIDERS: any[] = [
];
declare let jasmine: any;
declare let mdDateTimePicker: any;
describe('AnalyticsComponent', () => {

View File

@@ -16,9 +16,8 @@
*/
import { Component, EventEmitter, Input, OnChanges, Output, SimpleChanges, ViewChild } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { ReportQuery } from '../models/report.model';
import { AnalyticsService } from '../services/analytics.service';
import { AnalyticsGeneratorComponent } from './analytics-generator.component';
@Component({
@@ -54,10 +53,7 @@ export class AnalyticsComponent implements OnChanges {
reportParamQuery: ReportQuery;
constructor(private translateService: AlfrescoTranslationService,
private analyticsService: AnalyticsService,
private logService: LogService) {
logService.info('AnalyticsComponent');
constructor(translateService: AlfrescoTranslationService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-analytics', 'assets/ng2-activiti-analytics');
}

View File

@@ -19,7 +19,7 @@
/* tslint:disable::no-access-missing-member */
import { Component, ElementRef, EventEmitter, Input, OnDestroy, OnInit, Output, ViewChild } from '@angular/core';
import { AbstractControl, FormBuilder, FormControl, FormGroup, Validators } from '@angular/forms';
import { AbstractControl, FormControl, FormGroup, Validators } from '@angular/forms';
import * as moment from 'moment';
import { WidgetComponent } from './../widget.component';
@@ -62,8 +62,7 @@ export class DateRangeWidgetComponent extends WidgetComponent implements OnInit,
dialogEnd: any;
constructor(public elementRef: ElementRef,
private formBuilder: FormBuilder) {
constructor(public elementRef: ElementRef) {
super();
}

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-business-rule-task',
templateUrl: './diagram-business-rule-task.component.html'
})
export class DiagramBusinessRuleTaskComponent implements OnInit {
export class DiagramBusinessRuleTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,25 +17,19 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-manual-task',
templateUrl: './diagram-manual-task.component.html'
})
export class DiagramManualTaskComponent implements OnInit {
export class DiagramManualTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {
}
ngOnInit() {
constructor(public elementRef: ElementRef) {
}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-receive-task',
templateUrl: './diagram-receive-task.component.html'
})
export class DiagramReceiveTaskComponent implements OnInit {
export class DiagramReceiveTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-script-task',
templateUrl: './diagram-script-task.component.html'
})
export class DiagramScriptTaskComponent implements OnInit {
export class DiagramScriptTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-service-task',
templateUrl: './diagram-service-task.component.html'
})
export class DiagramServiceTaskComponent implements OnInit {
export class DiagramServiceTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-user-task',
templateUrl: './diagram-user-task.component.html'
})
export class DiagramUserTaskComponent implements OnInit {
export class DiagramUserTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { Component, ElementRef, EventEmitter, Input, OnChanges, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { Component, EventEmitter, Input, OnChanges, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { DiagramElementModel, DiagramModel } from '../models/diagram.model';
import { DiagramColorService } from '../services/diagram-color.service';
import { DiagramsService } from '../services/diagrams.service';
@@ -60,12 +60,10 @@ export class DiagramComponent implements OnChanges {
diagram: DiagramModel;
constructor(private elementRef: ElementRef,
private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private diagramColorService: DiagramColorService,
private raphaelService: RaphaelService,
private diagramsService: DiagramsService,
private logService: LogService) {
private diagramsService: DiagramsService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-diagrams', 'assets/ng2-activiti-diagrams');
}

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-event',
@@ -39,8 +38,7 @@ export class DiagramEventComponent implements OnInit {
center: any = {};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {

View File

@@ -17,14 +17,13 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-container-icon-event',
templateUrl: './diagram-container-icon-event.component.html'
})
export class DiagramContainerIconEventTaskComponent implements OnInit {
export class DiagramContainerIconEventTaskComponent {
@Input()
data: any;
@@ -37,9 +36,5 @@ export class DiagramContainerIconEventTaskComponent implements OnInit {
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-alfresco-publish-task',
@@ -35,8 +34,7 @@ export class DiagramIconAlfrescoPublishTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-box-publish-task',
@@ -35,8 +34,7 @@ export class DiagramIconBoxPublishTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 6, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-business-rule-task',
@@ -35,8 +34,7 @@ export class DiagramIconBusinessRuleTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-camel-task',
@@ -35,8 +34,7 @@ export class DiagramIconCamelTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 8, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-error',
@@ -38,8 +37,7 @@ export class DiagramIconErrorComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x - 1, y: this.data.y - 1};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-google-drive-publish-task',
@@ -35,8 +34,7 @@ export class DiagramIconGoogleDrivePublishTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 6, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-manual-task',
@@ -35,8 +34,7 @@ export class DiagramIconManualTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-message',
@@ -35,8 +34,7 @@ export class DiagramIconMessageComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 6, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-mule-task',
@@ -35,8 +34,7 @@ export class DiagramIconMuleTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 2, y: this.data.y + 2};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-receive-task',
@@ -35,8 +34,7 @@ export class DiagramIconReceiveTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 2};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-rest-call-task',
@@ -35,8 +34,7 @@ export class DiagramIconRestCallTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 2, y: this.data.y + 2};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-script-task',
@@ -35,8 +34,7 @@ export class DiagramIconScriptTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-send-task',
@@ -35,8 +34,7 @@ export class DiagramIconSendTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-service-task',
@@ -35,8 +34,7 @@ export class DiagramIconServiceTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-signal',
@@ -38,8 +37,7 @@ export class DiagramIconSignalComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x - 1, y: this.data.y - 1};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-timer',
@@ -39,8 +38,7 @@ export class DiagramIconTimerComponent implements OnInit {
circleOptions: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
timerOptions: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.center.x = this.data.x + (this.data.width / 2);

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-user-task',
@@ -35,8 +34,7 @@ export class DiagramIconUserTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-lane',
@@ -40,8 +39,7 @@ export class DiagramLaneComponent implements OnInit {
textTransform: string;
options: any = {stroke: '#000000', fillColors: 'none', fillOpacity: '', strokeWidth: '1', radius: 0};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.rectLeftCorner = {x: this.lane.x, y: this.lane.y};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-pool',
@@ -40,8 +39,7 @@ export class DiagramPoolComponent implements OnInit {
textTransform: string;
options: any = {stroke: '#000000', fillColors: 'none', fillOpacity: '', strokeWidth: '1', radius: 0};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.rectLeftCorner = {x: this.pool.x, y: this.pool.y};

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -16,7 +16,6 @@
*/
import { Component, Input, OnChanges, SimpleChanges } from '@angular/core';
import { LogService } from 'ng2-alfresco-core';
import { FormService } from './../services/form.service';
@Component({
@@ -29,8 +28,7 @@ export class FormListComponent implements OnChanges {
@Input()
forms: any [] = [];
constructor(protected formService: FormService,
private logService: LogService) {
constructor(protected formService: FormService) {
}
ngOnChanges(changes: SimpleChanges) {

View File

@@ -45,7 +45,7 @@ describe('FormComponent', () => {
spyOn(visibilityService, 'refreshVisibility').and.stub();
formService = new FormService(null, null, logService);
nodeService = new NodeService(null);
formComponent = new FormComponent(formService, visibilityService, null, nodeService, logService);
formComponent = new FormComponent(formService, visibilityService, null, nodeService);
});
it('should upgrade MDL content on view checked', () => {

View File

@@ -17,7 +17,6 @@
/* tslint:disable */
import { AfterViewChecked, Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';
import { LogService } from 'ng2-alfresco-core';
import { FormErrorEvent, FormEvent } from './../events/index';
import { EcmModelService } from './../services/ecm-model.service';
import { FormService } from './../services/form.service';
@@ -118,8 +117,7 @@ export class FormComponent implements OnInit, AfterViewChecked, OnChanges {
constructor(protected formService: FormService,
protected visibilityService: WidgetVisibilityService,
private ecmModelService: EcmModelService,
private nodeService: NodeService,
private logService: LogService) {
private nodeService: NodeService) {
}
hasForm(): boolean {

View File

@@ -75,7 +75,7 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
formService: FormService,
visibilityService: WidgetVisibilityService,
logService: LogService) {
super(formService, visibilityService, null, null, logService);
super(formService, visibilityService, null, null);
if (this.translate) {
this.translate.addTranslationFolder('ng2-activiti-form', 'assets/ng2-activiti-form');

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, EventEmitter, Input, OnInit, Output, ViewChild } from '@angular/core';
import { LogService } from 'ng2-alfresco-core';
import { ActivitiAlfrescoContentService } from '../../../services/activiti-alfresco.service';
import { ExternalContent } from '../core/external-content';
import { ExternalContentLink } from '../core/external-content-link';
@@ -56,8 +55,7 @@ export class AttachWidgetComponent extends WidgetComponent implements OnInit {
dialog: any;
constructor(public formService: FormService,
private contentService: ActivitiAlfrescoContentService,
private logService: LogService) {
private contentService: ActivitiAlfrescoContentService) {
super(formService);
}

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { FormFieldModel, FormModel } from './../components/widgets/core/index';
import { FormModel } from './../components/widgets/core/index';
import { FormEvent } from './form.event';
export class ValidateFormEvent extends FormEvent {

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -35,7 +35,7 @@ export class CreateProcessAttachmentComponent implements OnChanges {
@Output()
success: EventEmitter<any> = new EventEmitter<any>();
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService) {
if (translateService) {

View File

@@ -41,7 +41,7 @@ export class ProcessAttachmentListComponent implements OnChanges {
attachments: any[] = [];
isLoading: boolean = true;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService,
private contentService: ContentService,
private thumbnailService: ThumbnailService) {

View File

@@ -41,8 +41,7 @@ export class ProcessCommentsComponent {
* Constructor
* @param translate Translation service
*/
constructor(private translate: AlfrescoTranslationService) {
constructor(translate: AlfrescoTranslationService) {
if (translate) {
translate.addTranslationFolder('ng2-activiti-processlist', 'assets/ng2-activiti-processlist');
}

View File

@@ -53,7 +53,7 @@ describe('ActivitiFilters', () => {
beforeEach(() => {
logService = new LogServiceMock();
activitiService = new ProcessService(null, logService);
filterList = new ProcessFiltersComponent(null, activitiService, logService);
filterList = new ProcessFiltersComponent(null, activitiService);
});
it('should return the filter task list', (done) => {

View File

@@ -16,13 +16,11 @@
*/
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { FilterParamsModel, FilterProcessRepresentationModel } from './../models/filter-process.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
@Component({
selector: 'adf-process-instance-filters, activiti-process-instance-filters',
templateUrl: './process-filters.component.html',
@@ -58,9 +56,8 @@ export class ProcessFiltersComponent implements OnInit, OnChanges {
filters: FilterProcessRepresentationModel [] = [];
constructor(private translate: AlfrescoTranslationService,
private activiti: ProcessService,
private logService: LogService) {
constructor(translate: AlfrescoTranslationService,
private activiti: ProcessService) {
this.filter$ = new Observable<FilterProcessRepresentationModel>(observer => this.filterObserver = observer).share();
if (translate) {

View File

@@ -25,8 +25,6 @@ import { ProcessService } from './../services/process.service';
import { ProcessInstanceHeaderComponent } from './process-instance-header.component';
import { ProcessInstanceTasksComponent } from './process-instance-tasks.component';
declare let dialogPolyfill: any;
@Component({
selector: 'adf-process-instance-details, activiti-process-instance-details',
templateUrl: './process-instance-details.component.html',
@@ -68,7 +66,7 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
* @param translate Translation service
* @param activitiProcess Process service
*/
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService,
private logService: LogService) {

View File

@@ -16,11 +16,9 @@
*/
import { Component, Input, OnChanges, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, CardViewDateItemModel, CardViewItem, CardViewTextItemModel, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService, CardViewDateItemModel, CardViewItem, CardViewTextItemModel } from 'ng2-alfresco-core';
import { ProcessInstance } from '../models/process-instance.model';
declare let componentHandler: any;
@Component({
selector: 'adf-process-instance-header, activiti-process-instance-header',
templateUrl: './process-instance-header.component.html',
@@ -33,8 +31,7 @@ export class ProcessInstanceHeaderComponent implements OnChanges {
properties: CardViewItem [];
constructor(private translate: AlfrescoTranslationService,
private logService: LogService) {
constructor(translate: AlfrescoTranslationService) {
if (translate) {
translate.addTranslationFolder('ng2-activiti-processlist', 'assets/ng2-activiti-processlist');

View File

@@ -23,7 +23,6 @@ import { Observable, Observer } from 'rxjs/Rx';
import { ProcessInstance } from '../models/process-instance.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
declare let dialogPolyfill: any;
@Component({
@@ -66,7 +65,7 @@ export class ProcessInstanceTasksComponent implements OnInit, OnChanges {
@Output()
taskClick: EventEmitter<TaskDetailsEvent> = new EventEmitter<TaskDetailsEvent>();
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService,
private logService: LogService) {
if (translate) {

View File

@@ -22,7 +22,6 @@ import { DataCellEvent, DataTableAdapter, ObjectDataRow, ObjectDataTableAdapter
import { ProcessInstanceVariable } from './../models/process-instance-variable.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
declare let dialogPolyfill: any;
@Component({
@@ -68,7 +67,7 @@ export class ProcessInstanceVariablesComponent implements OnInit, OnChanges {
* @param translate Translation service
* @param activitiProcess Process service
*/
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService) {
if (translate) {

View File

@@ -70,7 +70,7 @@ export class ProcessInstanceListComponent implements OnChanges, AfterContentInit
];
constructor(private processService: ProcessService,
private translate: AlfrescoTranslationService) {
translate: AlfrescoTranslationService) {
if (translate !== null) {
translate.addTranslationFolder('ng2-activiti-processlist', 'assets/ng2-activiti-processlist');
}

View File

@@ -23,9 +23,6 @@ import { ProcessDefinitionRepresentation } from './../models/process-definition.
import { ProcessInstance } from './../models/process-instance.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
declare let dialogPolyfill: any;
@Component({
selector: 'adf-start-process, activiti-start-process',
templateUrl: './start-process.component.html',
@@ -59,7 +56,7 @@ export class StartProcessInstanceComponent implements OnChanges {
errorMessageId: string = '';
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService) {
if (translate) {

View File

@@ -34,7 +34,6 @@ import { ProcessFilterRequestRepresentation } from '../models/process-instance-f
import { ProcessInstanceVariable } from '../models/process-instance-variable.model';
import { ProcessService } from './process.service';
declare let jasmine: any;
describe('ProcessService', () => {
let service: ProcessService;

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -23,8 +23,6 @@ import { AppDefinitionRepresentationModel } from '../models/filter.model';
import { IconModel } from '../models/icon.model';
import { TaskListService } from './../services/tasklist.service';
declare let componentHandler: any;
@Component({
selector: 'adf-apps, activiti-apps',
templateUrl: 'apps-list.component.html',
@@ -67,7 +65,7 @@ export class AppsListComponent implements OnInit {
* @param translate Translate service
* @param activitiTaskList Task service
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService) {
if (translateService) {

View File

@@ -16,7 +16,7 @@
*/
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges, ViewChild } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { TaskDetailsModel } from '../models/task-details.model';
import { TaskListService } from './../services/tasklist.service';
@@ -64,9 +64,8 @@ export class ChecklistComponent implements OnInit, OnChanges {
* @param auth
* @param translate
*/
constructor(private translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService,
private logService: LogService) {
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');

View File

@@ -52,7 +52,7 @@ export class CommentsComponent implements OnChanges {
* @param translate Translation service
* @param activitiTaskList Task service
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService) {
if (translateService) {

View File

@@ -35,7 +35,7 @@ export class AttachmentComponent implements OnChanges {
@Output()
success: EventEmitter<any> = new EventEmitter<any>();
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService) {
if (translateService) {

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { TaskDetailsComponent } from './task-details.component';
import { NoTaskDetailsTemplateDirective } from './no-task-detail-template.directive';
import { TaskDetailsComponent } from './task-details.component';
describe('NoTaskDetailsTemplateDirective', () => {
@@ -24,7 +24,7 @@ describe('NoTaskDetailsTemplateDirective', () => {
let detailsComponent: TaskDetailsComponent;
beforeEach(() => {
detailsComponent = new TaskDetailsComponent(null, null, null, null, null, null);
detailsComponent = new TaskDetailsComponent(null, null, null, null);
component = new NoTaskDetailsTemplateDirective(detailsComponent);
});

View File

@@ -22,7 +22,6 @@ import { Observable } from 'rxjs/Observable';
import { User } from '../models/user.model';
declare let componentHandler: any;
declare var require: any;
@Component({
selector: 'adf-people-search, activiti-people-search',
@@ -50,7 +49,7 @@ export class PeopleSearchComponent implements OnInit, AfterViewInit {
selectedUser: User;
constructor(private translateService: AlfrescoTranslationService) {
constructor(translateService: AlfrescoTranslationService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');
}

View File

@@ -55,7 +55,7 @@ export class PeopleComponent implements AfterViewInit {
* @param translate
* @param people service
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private peopleService: PeopleService,
private logService: LogService) {
if (translateService) {

View File

@@ -26,8 +26,6 @@ import { TaskListService } from '../services/tasklist.service';
import { startTaskMock } from './../assets/start-task.mock';
import { StartTaskComponent } from './start-task.component';
declare let jasmine: any;
describe('StartTaskComponent', () => {
let activitiStartTaskComponent: StartTaskComponent;

View File

@@ -62,7 +62,7 @@ export class StartTaskComponent implements OnInit {
* @param translate
* @param taskService
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private taskService: TaskListService,
private peopleService: PeopleService,
private logService: LogService) {

View File

@@ -41,7 +41,7 @@ export class TaskAttachmentListComponent implements OnChanges {
attachments: any[] = [];
isLoading: boolean = true;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService,
private contentService: ContentService,
private thumbnailService: ThumbnailService) {

View File

@@ -22,7 +22,6 @@ import {
fakeAsync,
TestBed
} from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { CoreModule } from 'ng2-alfresco-core';
import { Observable } from 'rxjs/Rx';
import { TaskListService } from './../services/tasklist.service';
@@ -34,7 +33,6 @@ describe('TaskAuditDirective', () => {
let fixture: ComponentFixture<BasicButtonComponent>;
let component: BasicButtonComponent;
let auditDirective: TaskAuditDirective;
let service: TaskListService;
function createFakePdfBlob(): Blob {

View File

@@ -26,15 +26,14 @@ import { Component,
TemplateRef,
ViewChild
} from '@angular/core';
import { ContentLinkModel, FormModel, FormOutcomeEvent, FormService } from 'ng2-activiti-form';
import { AlfrescoAuthenticationService, AlfrescoTranslationService, CardViewUpdateService, ClickNotification, LogService, UpdateNotification } from 'ng2-alfresco-core';
import { ContentLinkModel, FormModel, FormOutcomeEvent } from 'ng2-activiti-form';
import { AlfrescoAuthenticationService, AlfrescoTranslationService, CardViewUpdateService, ClickNotification, UpdateNotification } from 'ng2-alfresco-core';
import { TaskQueryRequestRepresentationModel } from '../models/filter.model';
import { TaskDetailsModel } from '../models/task-details.model';
import { User } from '../models/user.model';
import { TaskListService } from './../services/tasklist.service';
declare var require: any;
declare let dialogPolyfill: any;
@Component({
selector: 'adf-task-details, activiti-task-details',
@@ -128,22 +127,10 @@ export class TaskDetailsComponent implements OnInit, OnChanges {
noTaskDetailsTemplateComponent: TemplateRef<any>;
/**
*
* @param translateService
* @param activitiForm
* @param activitiTaskList
* @param logService
* @param authService
*/
constructor(private translateService: AlfrescoTranslationService,
private activitiForm: FormService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService,
private logService: LogService,
private authService: AlfrescoAuthenticationService,
private cardViewUpdateService: CardViewUpdateService
) {
private cardViewUpdateService: CardViewUpdateService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');
}

View File

@@ -66,7 +66,7 @@ describe('TaskFiltersComponent', () => {
beforeEach(() => {
logService = new LogServiceMock();
activitiService = new TaskListService(null, logService);
filterList = new TaskFiltersComponent(null, activitiService, logService);
filterList = new TaskFiltersComponent(null, activitiService);
});
it('should return the filter task list', (done) => {

View File

@@ -16,13 +16,11 @@
*/
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { FilterParamsModel, FilterRepresentationModel } from '../models/filter.model';
import { TaskListService } from './../services/tasklist.service';
declare let componentHandler: any;
@Component({
selector: 'adf-filters, activiti-filters',
templateUrl: './task-filters.component.html',
@@ -59,9 +57,8 @@ export class TaskFiltersComponent implements OnInit, OnChanges {
filters: FilterRepresentationModel [] = [];
constructor(private translateService: AlfrescoTranslationService,
private activiti: TaskListService,
private logService: LogService) {
constructor(translateService: AlfrescoTranslationService,
private activiti: TaskListService) {
this.filter$ = new Observable<FilterRepresentationModel>(observer => this.filterObserver = observer).share();
if (translateService) {
@@ -235,8 +232,4 @@ export class TaskFiltersComponent implements OnInit, OnChanges {
this.filters = [];
this.currentFilter = undefined;
}
private isCurrentFilterEmpty(): boolean {
return this.currentFilter === undefined || null ? true : false;
}
}

View File

@@ -39,7 +39,7 @@ export class TaskHeaderComponent implements OnChanges {
properties: CardViewItem [];
inEdit: boolean = false;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskService: TaskListService,
private logService: LogService) {
if (translateService) {

View File

@@ -25,7 +25,7 @@ import {
Output,
SimpleChanges
} from '@angular/core';
import { AlfrescoTranslationService, DataColumnListComponent, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService, DataColumnListComponent } from 'ng2-alfresco-core';
import {
DataColumn,
DataRowEvent,
@@ -99,9 +99,8 @@ export class TaskListComponent implements OnChanges, AfterContentInit {
{ type: 'text', key: 'created', title: 'Created', cssClass: 'hidden', sortable: true }
];
constructor(private translateService: AlfrescoTranslationService,
private taskListService: TaskListService,
private logService: LogService) {
constructor(translateService: AlfrescoTranslationService,
private taskListService: TaskListService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');
}

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -67,8 +67,8 @@ export class ContextMenuHolderComponent {
isShown = false;
private mouseLocation: { left: number, top: number } = {left: 0, top: 0};
constructor(private _contextMenuService: ContextMenuService) {
_contextMenuService.show.subscribe(e => this.showMenu(e.event, e.obj));
constructor(contextMenuService: ContextMenuService) {
contextMenuService.show.subscribe(e => this.showMenu(e.event, e.obj));
}
get locationCss() {

View File

@@ -28,8 +28,6 @@ import { SearchService } from './search.service';
import { StorageService } from './storage.service';
import { UserPreferencesService } from './user-preferences.service';
declare let jasmine: any;
describe('SearchService', () => {
let service: SearchService;

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -27,8 +27,6 @@ import { ObjectDataRow, ObjectDataTableAdapter } from '../../data/object-datatab
import { DataCellEvent } from './data-cell.event';
import { DataRowActionEvent } from './data-row-action.event';
declare var componentHandler;
@Component({
selector: 'adf-datatable, alfresco-datatable',
styleUrls: ['./datatable.component.scss'],
@@ -110,7 +108,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck
constructor(translateService: AlfrescoTranslationService,
private elementRef: ElementRef,
private differs: IterableDiffers) {
differs: IterableDiffers) {
if (differs) {
this.differ = differs.find([]).create(null);
}

View File

@@ -20,8 +20,6 @@ import { TemplateRef } from '@angular/core';
import { ObjectUtils } from 'ng2-alfresco-core';
import { DataColumn, DataRow, DataSorting, DataTableAdapter } from './datatable-adapter';
declare var require: any;
// Simple implementation of the DataTableAdapter interface.
export class ObjectDataTableAdapter implements DataTableAdapter {

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { async, TestBed } from '@angular/core/testing';
import { CoreModule } from 'ng2-alfresco-core';
import { DataTableCellComponent } from '../components/datatable/datatable-cell.component';
import { DataTableComponent } from '../components/datatable/datatable.component';

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { async, getTestBed, TestBed } from '@angular/core/testing';
import { async, TestBed } from '@angular/core/testing';
import { CoreModule } from 'ng2-alfresco-core';
import { DataTableCellComponent } from '../components/datatable/datatable-cell.component';
import { DataTableComponent } from '../components/datatable/datatable.component';

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -41,8 +41,6 @@ import { fakeNodeWithCreatePermission } from '../../assets/document-list.compone
import { DocumentListComponent } from '../document-list.component';
import { DropdownBreadcrumbComponent } from './dropdown-breadcrumb.component';
declare let jasmine: any;
describe('DropdownBreadcrumb', () => {
let component: DropdownBreadcrumbComponent;

View File

@@ -19,7 +19,7 @@ import { DebugElement, EventEmitter } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { MD_DIALOG_DATA, MdDialogRef } from '@angular/material';
import { By } from '@angular/platform-browser';
import { MinimalNodeEntryEntity, NodePaging } from 'alfresco-js-api';
import { MinimalNodeEntryEntity } from 'alfresco-js-api';
import { AlfrescoTranslationService, CoreModule, SearchService, SiteModel } from 'ng2-alfresco-core';
import { DataTableModule } from 'ng2-alfresco-datatable';
import { MaterialModule } from '../../material.module';
@@ -44,12 +44,6 @@ const ONE_FOLDER_RESULT = {
}
};
const NO_RESULT = {
list: {
entries: []
}
};
describe('ContentNodeSelectorComponent', () => {
let component: ContentNodeSelectorComponent;

View File

@@ -47,7 +47,7 @@ export class ContentNodeSelectorComponent {
select: EventEmitter<MinimalNodeEntryEntity> = new EventEmitter<MinimalNodeEntryEntity>();
constructor(private searchService: SearchService,
@Optional() private translateService: AlfrescoTranslationService,
@Optional() translateService: AlfrescoTranslationService,
@Optional() @Inject(MD_DIALOG_DATA) public data?: ContentNodeSelectorComponentData,
@Optional() private containingDialog?: MdDialogRef<ContentNodeSelectorComponent>) {

View File

@@ -18,7 +18,7 @@
import { NgZone, SimpleChange, TemplateRef } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { AlfrescoTranslationService, CoreModule } from 'ng2-alfresco-core';
import { DataColumn, DataRowEvent, DataTableComponent } from 'ng2-alfresco-datatable';
import { DataColumn, DataTableComponent } from 'ng2-alfresco-datatable';
import { DataTableModule } from 'ng2-alfresco-datatable';
import { Observable, Subject } from 'rxjs/Rx';
import { FileNode, FolderNode } from '../assets/document-library.model.mock';
@@ -31,7 +31,7 @@ import {
import { MaterialModule } from '../material.module';
import { ContentActionModel } from '../models/content-action.model';
import { NodeMinimal, NodeMinimalEntry, NodePaging } from '../models/document-library.model';
import { ImageResolver, RowFilter, ShareDataRow } from './../data/share-datatable-adapter';
import { ImageResolver, RowFilter } from './../data/share-datatable-adapter';
import { DocumentListService } from './../services/document-list.service';
import { DocumentListComponent } from './document-list.component';
import { DocumentMenuActionComponent } from './document-menu-action.component';
@@ -747,7 +747,6 @@ describe('DocumentList', () => {
it('should emit [nodeClick] event on row click', () => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
spyOn(documentList, 'onNodeClick').and.callThrough();
documentList.onNodeClick(node);
@@ -756,7 +755,6 @@ describe('DocumentList', () => {
it('should emit node-click DOM event', (done) => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
const htmlElement = fixture.debugElement.nativeElement as HTMLElement;
htmlElement.addEventListener('node-click', (e: CustomEvent) => {
@@ -768,7 +766,6 @@ describe('DocumentList', () => {
it('should emit [nodeDblClick] event on row double-click', () => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
spyOn(documentList, 'onNodeDblClick').and.callThrough();
documentList.onNodeDblClick(node);
@@ -777,7 +774,6 @@ describe('DocumentList', () => {
it('should emit node-dblclick DOM event', (done) => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
const htmlElement = fixture.debugElement.nativeElement as HTMLElement;
htmlElement.addEventListener('node-dblclick', (e: CustomEvent) => {

View File

@@ -21,7 +21,7 @@ import {
} from '@angular/core';
import { MinimalNodeEntity, MinimalNodeEntryEntity, NodePaging, Pagination } from 'alfresco-js-api';
import { AlfrescoTranslationService, DataColumnListComponent } from 'ng2-alfresco-core';
import { DataCellEvent, DataColumn, DataRow, DataRowActionEvent, DataRowEvent, DataSorting, DataTableComponent, ObjectDataColumn } from 'ng2-alfresco-datatable';
import { DataCellEvent, DataColumn, DataRowActionEvent, DataSorting, DataTableComponent, ObjectDataColumn } from 'ng2-alfresco-datatable';
import { Observable, Subject } from 'rxjs/Rx';
import { ImageResolver, RowFilter, ShareDataRow, ShareDataTableAdapter } from './../data/share-datatable-adapter';
import { ContentActionModel } from './../models/content-action.model';

View File

@@ -18,7 +18,6 @@
import { DatePipe } from '@angular/common';
import { MinimalNode, MinimalNodeEntity, NodePaging } from 'alfresco-js-api';
import { ObjectUtils } from 'ng2-alfresco-core';
import { PermissionsEnum } from 'ng2-alfresco-core';
import { DataColumn, DataRow, DataSorting, DataTableAdapter } from 'ng2-alfresco-datatable';
import { PermissionStyleModel } from './../models/permissions-style.model';
import { DocumentListService } from './../services/document-list.service';

View File

@@ -15,8 +15,6 @@
* limitations under the License.
*/
import { MdDialog } from '@angular/material';
import { TranslateService } from '@ngx-translate/core';
import { AlfrescoContentService, AlfrescoTranslationService, NotificationService } from 'ng2-alfresco-core';
import { FileNode, FolderNode } from '../assets/document-library.model.mock';
import { DocumentListServiceMock } from '../assets/document-list.service.mock';

View File

@@ -20,7 +20,6 @@ import { MinimalNodeEntity } from 'alfresco-js-api';
import { AlfrescoContentService, AlfrescoTranslationService, NotificationService } from 'ng2-alfresco-core';
import { Observable } from 'rxjs/Observable';
import { Subject } from 'rxjs/Rx';
import { ContentNodeSelectorComponent } from '../components/content-node-selector/content-node-selector.component';
import { ContentActionHandler } from '../models/content-action.model';
import { PermissionModel } from '../models/permissions.model';
import { DocumentListService } from './document-list.service';

View File

@@ -26,7 +26,7 @@ export class DocumentListService {
static ROOT_ID = '-root-';
constructor(private authService: AlfrescoAuthenticationService,
constructor(authService: AlfrescoAuthenticationService,
private contentService: AlfrescoContentService,
private apiService: AlfrescoApiService,
private logService: LogService,

View File

@@ -19,7 +19,6 @@ import { EventEmitter, Injectable } from '@angular/core';
import { MdDialog } from '@angular/material';
import { MinimalNodeEntryEntity } from 'alfresco-js-api';
import { AlfrescoContentService, AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable } from 'rxjs/Observable';
import { Subject } from 'rxjs/Rx';
import { ContentNodeSelectorComponent } from '../components/content-node-selector/content-node-selector.component';
import { DocumentListService } from './document-list.service';

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -20,8 +20,6 @@ import { MinimalNodeEntity } from 'alfresco-js-api';
import { AlfrescoTranslationService, SearchOptions, SearchService } from 'ng2-alfresco-core';
import { ThumbnailService } from 'ng2-alfresco-core';
declare var require: any;
@Component({
selector: 'adf-search-autocomplete, alfresco-search-autocomplete',
templateUrl: './search-autocomplete.component.html',

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",

Some files were not shown because too many files have changed in this diff Show More