inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-09-10 14:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-37006 Fix floating label overlapping in dateitem component (#11118)

Browse Source
This commit is contained in:
Darren Thornton
2025-08-15 19:03:12 -05:00
committed by GitHub
parent 81e307c81e
commit 9deaab4c11
2 changed files with 60 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/src/lib/card-view/components/card-view-dateitem/card-view-dateitem.component.html
View File

@@ -19,7 +19,7 @@
>{{ property.displayValue }}</span
>
</span>
<mat-form-field *ngIf="isEditable && !property.multivalued" class="adf-dateitem-editable hxp-input">
<mat-form-field *ngIf="isEditable && !property.multivalued" class="adf-dateitem-editable hxp-input" [floatLabel]="property.default ? 'always' : null">
<mat-label
class="adf-property-label"
[attr.data-automation-id]="'card-dateitem-label-' + property.key"

59
lib/core/src/lib/card-view/components/card-view-dateitem/card-view-dateitem.component.spec.ts
View File

@@ -356,4 +356,63 @@ describe('CardViewDateItemComponent', () => {
expect(await chips[1].getText()).toBe('Jul 11, 2017, 0:01');
expect(await chips[2].getText()).toBe('Jul 12, 2017, 0:01');
});
describe('FloatLabel behavior', () => {
it('should set floatLabel to "always" when property has default value and is editable', async () => {
component.property = new CardViewDateItemModel({
label: 'Date label',
value: new Date('07/10/2017'),
key: 'dateKey',
default: 'Default Value',
format: '',
editable: true
});
component.editable = true;
fixture.detectChanges();
const matFormField = await testingUtils.getMatFormField();
const host = await matFormField.host();
const floatLabel = await host.getAttribute('ng-reflect-float-label');
expect(floatLabel).toBe('always');
});
it('should set floatLabel to null when property has no default value and is editable', async () => {
component.property = new CardViewDateItemModel({
label: 'Date label',
value: new Date('07/10/2017'),
key: 'dateKey',
default: '',
format: '',
editable: true
});
component.editable = true;
fixture.detectChanges();
const matFormField = await testingUtils.getMatFormField();
const host = await matFormField.host();
const floatLabel = await host.getAttribute('ng-reflect-float-label');
expect(floatLabel).toBe(null);
});
it('should set floatLabel to null when property has null default value and is editable', async () => {
component.property = new CardViewDateItemModel({
label: 'Date label',
value: new Date('07/10/2017'),
key: 'dateKey',
default: null,
format: '',
editable: true
});
component.editable = true;
fixture.detectChanges();
const matFormField = await testingUtils.getMatFormField();
const host = await matFormField.host();
const floatLabel = await host.getAttribute('ng-reflect-float-label');
expect(floatLabel).toBe(null);
});
});
});