Minor code and style fixes (#5398)

* type fixes

* import fixes

* fix typos

* fix warning for private props that init in ctor only

* typing fixes

* typing fixes

* style cleanup

* fix test template

lib/content-services/src/lib/dialogs/folder.dialog.scss

@@ -17,8 +17,7 @@
     }
 
     .mat-checkbox-inner-container {
-        margin: auto 0;
-        margin-right: 8px;
+        margin: auto 8px auto 0;
     }
 }
 

lib/content-services/src/lib/tag/tag-list.component.ts

@@ -20,6 +20,7 @@ import { TagService } from './services/tag.service';
 import { PaginationModel } from '@alfresco/adf-core';
 import { Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
+import { TagEntry } from '@alfresco/js-api';
 
 /**
  * This component provide a list of all the tag inside the ECM
@@ -39,7 +40,7 @@ export class TagListComponent implements OnInit, OnDestroy {
     /**
      * Array of tags that are displayed
      */
-    tagsEntries: any = [];
+    tagsEntries: TagEntry[] = [];
 
     /**
      * Number of items per iteration
@@ -86,7 +87,7 @@ export class TagListComponent implements OnInit, OnDestroy {
     }
 
     refreshTag(opts?: any) {
-        this.tagService.getAllTheTags(opts).subscribe((tags: any) => {
+        this.tagService.getAllTheTags(opts).subscribe((tags) => {
             this.tagsEntries = this.tagsEntries.concat(tags.list.entries);
             this.pagination = tags.list.pagination;
             this.result.emit(this.tagsEntries);

lib/content-services/src/lib/tag/tag-node-list.component.ts

@@ -17,7 +17,7 @@
 
 import { Component, EventEmitter, Input, OnChanges, Output, ViewEncapsulation, OnDestroy, OnInit } from '@angular/core';
 import { TagService } from './services/tag.service';
-import { TagPaging } from '@alfresco/js-api';
+import { TagEntry } from '@alfresco/js-api';
 import { Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
@@ -41,7 +41,7 @@ export class TagNodeListComponent implements OnChanges, OnDestroy, OnInit {
     @Input()
     showDelete = true;
 
-    tagsEntries: any;
+    tagsEntries: TagEntry[];
 
     /** Emitted when a tag is selected. */
     @Output()
@@ -73,7 +73,7 @@ export class TagNodeListComponent implements OnChanges, OnDestroy, OnInit {
 
     refreshTag() {
         if (this.nodeId) {
-            this.tagService.getTagsByNodeId(this.nodeId).subscribe((tagPaging: TagPaging) => {
+            this.tagService.getTagsByNodeId(this.nodeId).subscribe((tagPaging) => {
                 this.tagsEntries = tagPaging.list.entries;
                 this.results.emit(this.tagsEntries);
             });

lib/content-services/src/lib/version-manager/version-manager.component.scss

@@ -27,7 +27,7 @@ adf-version-manager {
 .adf-new-version-uploader-container {
     padding: 16px 0;
     width: 100%;
-    height: 0%;
+    height: 0;
 
     float: left;
     position: relative;