Minor code and style fixes (#5398)

* type fixes

* import fixes

* fix typos

* fix warning for private props that init in ctor only

* typing fixes

* typing fixes

* style cleanup

* fix test template

lib/core/form/components/widgets/container/container.widget.scss

@@ -1,3 +1,4 @@
+@import '~@angular/material/theming';
 
 @mixin adf-form-container-widget-theme($theme) {
     $primary: map-get($theme, primary);

lib/core/form/components/widgets/core/form-outcome-event.model.ts

@@ -21,7 +21,7 @@ import { FormOutcomeModel } from './form-outcome.model';
 
 export class FormOutcomeEvent {
 
-    private _outcome: FormOutcomeModel;
+    private readonly _outcome: FormOutcomeModel;
     private _defaultPrevented: boolean = false;
 
     get outcome(): FormOutcomeModel {

lib/core/form/components/widgets/core/form-widget.model.ts

@@ -30,7 +30,7 @@ export abstract class FormWidgetModel {
     readonly form: any;
     readonly json: any;
 
-    constructor(form: FormModel, json: any) {
+    protected constructor(form: FormModel, json: any) {
         this.form = form;
         this.json = json;
 

lib/core/form/components/widgets/dynamic-table/dynamic-table.widget.model.ts

@@ -38,7 +38,7 @@ export class DynamicTableModel extends FormWidgetModel {
     rows: DynamicTableRow[] = [];
 
     private _selectedRow: DynamicTableRow;
-    private _validators: CellValidator[] = [];
+    private readonly _validators: CellValidator[] = [];
 
     get selectedRow(): DynamicTableRow {
         return this._selectedRow;

lib/core/form/components/widgets/dynamic-table/dynamic-table.widget.scss

@@ -1,3 +1,4 @@
+@import '~@angular/material/theming';
 @import '../form';
 
 @mixin adf-dynamic-table-theme($theme) {
@@ -62,9 +63,7 @@
 
                     &:focus {
                         outline-offset: -1px;
-                        outline-width: 1px;
-                        outline-color: rgb(68, 138, 255);
-                        outline-style: solid;
+                        outline: rgb(68, 138, 255) solid 1px;
                     }
                 }
             }

lib/core/form/components/widgets/dynamic-table/editors/row.editor.css

@@ -7,10 +7,7 @@
 }
 
 .row-editor__invalid .row-editor__validation-summary {
-    padding-left: 16px;
-    padding-right: 16px;
-    padding-top: 8px;
-    padding-bottom: 8px;
+    padding: 8px 16px;
     color: #d50000;
     visibility: visible;
 }

lib/core/form/components/widgets/form.scss

@@ -1,3 +1,5 @@
+@import '~@angular/material/theming';
+
 @mixin adf-form-theme($theme) {
     $primary: map-get($theme, primary);
     $accent: map-get($theme, accent);

lib/core/form/components/widgets/hyperlink/hyperlink.widget.scss

@@ -1,3 +1,5 @@
+@import '~@angular/material/theming';
+
 @mixin adf-hyperlink-widget-theme($theme) {
     $primary: map-get($theme, primary);
 

lib/core/form/components/widgets/index.ts

@@ -46,6 +46,7 @@ import { TypeaheadWidgetComponent } from './typeahead/typeahead.widget';
 import { UploadWidgetComponent } from './upload/upload.widget';
 import { DateTimeWidgetComponent } from './date-time/date-time.widget';
 import { JsonWidgetComponent } from './json/json.widget';
+import { UploadFolderWidgetComponent } from './upload-folder/upload-folder.widget';
 
 // core
 export * from './widget.component';
@@ -76,6 +77,7 @@ export * from './error/error.component';
 export * from './document/document.widget';
 export * from './date-time/date-time.widget';
 export * from './json/json.widget';
+export * from './upload-folder/upload-folder.widget';
 
 // editors (dynamic table)
 export * from './dynamic-table/dynamic-table.widget.model';
@@ -117,7 +119,8 @@ export const WIDGET_DIRECTIVES: any[] = [
     DateTimeWidgetComponent,
     DateTimeEditorComponent,
     JsonWidgetComponent,
-    AmountEditorComponent
+    AmountEditorComponent,
+    UploadFolderWidgetComponent
 ];
 
 export const MASK_DIRECTIVE: any[] = [

lib/core/form/components/widgets/people/people.widget.scss

@@ -1,3 +1,5 @@
+@import '~@angular/material/theming';
+
 @mixin adf-form-people-widget-theme($theme) {
     $primary: map-get($theme, primary);
     $background: map-get($theme, background);

lib/core/form/components/widgets/upload-folder/upload-folder.widget.ts

@@ -147,7 +147,7 @@ export class UploadFolderWidgetComponent extends WidgetComponent implements OnIn
                 file.contentBlob = blob;
                 this.formService.formContentClicked.next(file);
             },
-            (error) => {
+            () => {
                 this.logService.error('Unable to send event for file ' + file.name);
             }
         );