[ADF-4936] Auth guard redirect fix (#5092)

* [ADF-4936] fix for auth guard with silent Login true

* [ADF-4936] check only for isOAuth...

* [ADF-4936] fix all auth guards when silent Login true

* [ADF-4936] unit tests

* [ADF-4936] fix doc info

* [ADF-4936] types and null checks

* [ADF-4936] fallback option in case silentLogin is missing from settings

* [ADF-4936] refactoring

* try to fix e2e test [C299158] Login component - SSO Grant type password (implicit flow false)

* Fix e2e test [C299158] Login component - SSO Grant type password (implicit flow false)

* [ADF-4936] show the error page when route path is unknown

* [ADF-4936] remove ssoImplicitLogin and do the redirectToUrl instead

-the implicit login concern is already in the JS-API

* [ADF-4936] refactor to simplify code

- the removed 'if' conditions cover all possible 'else' cases

* [ADF-4936] remove unneeded method
This commit is contained in:
Suzana Dirla
2019-10-29 17:16:08 +02:00
committed by Eugenio Romano
parent 9c2bcdee1a
commit a150e74366
9 changed files with 126 additions and 27 deletions

View File

@@ -82,13 +82,13 @@ export abstract class AuthGuardBase implements CanActivate, CanActivateChild {
);
}
protected isOAuthWithoutSilentLogin() {
protected isOAuthWithoutSilentLogin(): boolean {
const oauth = this.appConfigService.get<OauthConfigModel>(
AppConfigValues.OAUTHCONFIG,
null
);
return (
this.authenticationService.isOauth() && oauth.silentLogin === false
this.authenticationService.isOauth() && !!oauth && !oauth.silentLogin
);
}
}