mirror of
https://github.com/Alfresco/alfresco-ng2-components.git
synced 2025-09-17 14:21:29 +00:00
[ACS-5991] ESLint fixes and code quality improvements (#8893)
* prefer-optional-chain: core * prefer-optional-chain: content, fix typings * prefer-optional-chain: process, fix typings * prefer-optional-chain: process-cloud, fix typings, fix ts configs and eslint * [ci: force] sonar errors fixes, insights lib * [ci:force] fix security issues * [ci:force] fix metadata e2e bug, js assignment bugs * [ci:force] fix lint issue * [ci:force] fix tests
This commit is contained in:
@@ -23,7 +23,7 @@ import { TreeNode } from '../models/tree-node.interface';
|
||||
import { TreeResponse } from '../models/tree-response.interface';
|
||||
|
||||
@Injectable({ providedIn: 'root' })
|
||||
export abstract class TreeService<T extends TreeNode> extends DataSource<T> {
|
||||
export abstract class TreeService<T extends TreeNode> extends DataSource<T> {
|
||||
public readonly treeControl: FlatTreeControl<T>;
|
||||
public treeNodesSource = new BehaviorSubject<T[]>([]);
|
||||
|
||||
@@ -38,7 +38,10 @@ export abstract class TreeService<T extends TreeNode> extends DataSource<T> {
|
||||
|
||||
constructor() {
|
||||
super();
|
||||
this.treeControl = new FlatTreeControl<T>(node => node.level, node => node.hasChildren);
|
||||
this.treeControl = new FlatTreeControl<T>(
|
||||
(node) => node.level,
|
||||
(node) => node.hasChildren
|
||||
);
|
||||
this.treeNodes = [];
|
||||
}
|
||||
|
||||
@@ -66,7 +69,7 @@ export abstract class TreeService<T extends TreeNode> extends DataSource<T> {
|
||||
* @param nodeToCollapse Node to be collapsed
|
||||
*/
|
||||
public collapseNode(nodeToCollapse: T): void {
|
||||
if (nodeToCollapse != null && nodeToCollapse.hasChildren) {
|
||||
if (nodeToCollapse?.hasChildren) {
|
||||
this.treeControl.collapse(nodeToCollapse);
|
||||
const children: T[] = this.treeNodes.filter((node: T) => nodeToCollapse.id === node.parentId);
|
||||
children.forEach((child: T) => {
|
||||
@@ -142,9 +145,7 @@ export abstract class TreeService<T extends TreeNode> extends DataSource<T> {
|
||||
const index: number = this.treeNodes.indexOf(nodeToCollapse);
|
||||
this.treeNodes.splice(index, 1);
|
||||
if (nodeToCollapse.hasChildren) {
|
||||
this.treeNodes
|
||||
.filter((node: T) => nodeToCollapse.id === node.parentId)
|
||||
.forEach((child: T) => this.collapseInnerNode(child));
|
||||
this.treeNodes.filter((node: T) => nodeToCollapse.id === node.parentId).forEach((child: T) => this.collapseInnerNode(child));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user