inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-10-01 14:41:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5991] ESLint fixes and code quality improvements (#8893)

Browse Source 
* prefer-optional-chain: core

* prefer-optional-chain: content, fix typings

* prefer-optional-chain: process, fix typings

* prefer-optional-chain: process-cloud, fix typings, fix ts configs and eslint

* [ci: force] sonar errors fixes, insights lib

* [ci:force] fix security issues

* [ci:force] fix metadata e2e bug, js assignment bugs

* [ci:force] fix lint issue

* [ci:force] fix tests
This commit is contained in:
Denys Vuika
2023-09-18 09:42:16 +01:00
committed by GitHub
parent 99f591ed67
commit a1dd270c5d
203 changed files with 4155 additions and 4960 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
lib/process-services/src/lib/form/start-form.component.ts
View File

@@ -80,7 +80,7 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
ngOnChanges(changes: SimpleChanges) {
const processDefinitionId = changes['processDefinitionId'];
if (processDefinitionId && processDefinitionId.currentValue) {
if (processDefinitionId?.currentValue) {
this.processDefinitionId = processDefinitionId.currentValue;
this.visibilityService.cleanProcessVariable();
this.getStartFormDefinition(this.processDefinitionId);
@@ -88,13 +88,13 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
}
const data = changes['data'];
if (data && data.currentValue) {
if (data?.currentValue) {
this.parseRefreshVisibilityValidateForm(this.form.json);
return;
}
const processId = changes['processId'];
if (processId && processId.currentValue) {
if (processId?.currentValue) {
this.visibilityService.cleanProcessVariable();
this.loadStartForm(processId.currentValue);
return;
@@ -102,33 +102,28 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
}
loadStartForm(processId: string) {
this.processService.getProcess(processId)
.subscribe((instance: any) => {
this.processService
.getStartFormInstance(processId)
.subscribe(
(form) => {
this.formName = form.name;
if (instance.variables) {
form.processVariables = instance.variables;
}
this.parseRefreshVisibilityValidateForm(form);
},
(error) => this.handleError(error)
);
});
}
getStartFormDefinition(processId: string) {
this.processService
.getStartFormDefinition(processId)
.subscribe(
this.processService.getProcess(processId).subscribe((instance: any) => {
this.processService.getStartFormInstance(processId).subscribe(
(form) => {
this.formName = form.processDefinitionName;
this.formName = form.name;
if (instance.variables) {
form.processVariables = instance.variables;
}
this.parseRefreshVisibilityValidateForm(form);
},
(error) => this.handleError(error)
);
});
}
getStartFormDefinition(processId: string) {
this.processService.getStartFormDefinition(processId).subscribe(
(form) => {
this.formName = form.processDefinitionName;
this.parseRefreshVisibilityValidateForm(form);
},
(error) => this.handleError(error)
);
}
parseRefreshVisibilityValidateForm(form) {
@@ -141,10 +136,9 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
/** @override */
isOutcomeButtonVisible(outcome: FormOutcomeModel, isFormReadOnly: boolean): boolean {
if (outcome && outcome.isSystem && (outcome.name === FormOutcomeModel.SAVE_ACTION ||
outcome.name === FormOutcomeModel.COMPLETE_ACTION)) {
if (outcome?.isSystem && (outcome.name === FormOutcomeModel.SAVE_ACTION || outcome.name === FormOutcomeModel.COMPLETE_ACTION)) {
return false;
} else if (outcome && outcome.name === FormOutcomeModel.START_PROCESS_ACTION) {
} else if (outcome?.name === FormOutcomeModel.START_PROCESS_ACTION) {
return true;
}
return super.isOutcomeButtonVisible(outcome, isFormReadOnly);