inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-09-17 14:21:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5991] ESLint fixes and code quality improvements (#8893)

Browse Source 
* prefer-optional-chain: core

* prefer-optional-chain: content, fix typings

* prefer-optional-chain: process, fix typings

* prefer-optional-chain: process-cloud, fix typings, fix ts configs and eslint

* [ci: force] sonar errors fixes, insights lib

* [ci:force] fix security issues

* [ci:force] fix metadata e2e bug, js assignment bugs

* [ci:force] fix lint issue

* [ci:force] fix tests
This commit is contained in:
Denys Vuika
2023-09-18 09:42:16 +01:00
committed by GitHub
parent 99f591ed67
commit a1dd270c5d
203 changed files with 4155 additions and 4960 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
lib/process-services/src/lib/process-list/components/process-instance-details.component.ts
View File

@@ -31,7 +31,6 @@ import { ProcessInstanceTasksComponent } from './process-instance-tasks.componen
styleUrls: ['./process-instance-details.component.css']
})
export class ProcessInstanceDetailsComponent implements OnChanges {
/** (required) The numeric ID of the process instance to display. */
@Input()
processInstanceId: string;
@@ -71,12 +70,10 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
/**
* Constructor
*
* @param translate Translation service
* @param activitiProcess Process service
* @param logService
*/
constructor(private activitiProcess: ProcessService,
private logService: LogService) {
}
constructor(private activitiProcess: ProcessService, private logService: LogService) {}
ngOnChanges(changes: SimpleChanges) {
const processInstanceId = changes['processInstanceId'];
@@ -84,7 +81,7 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
this.reset();
return;
}
if (processInstanceId && processInstanceId.currentValue) {
if (processInstanceId?.currentValue) {
this.load(processInstanceId.currentValue);
return;
}
@@ -99,11 +96,9 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
load(processId: string) {
if (processId) {
this.activitiProcess.getProcess(processId).subscribe(
(res: ProcessInstance) => {
this.processInstanceDetails = res;
}
);
this.activitiProcess.getProcess(processId).subscribe((res) => {
this.processInstanceDetails = res;
});
}
}
@@ -115,9 +110,11 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
this.activitiProcess.cancelProcess(this.processInstanceId).subscribe(
(data) => {
this.processCancelled.emit(data);
}, (err) => {
},
(err) => {
this.error.emit(err);
});
}
);
}
// bubbles (taskClick) event
@@ -128,7 +125,8 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
getProcessNameOrDescription(dateFormat: string): string {
let name = '';
if (this.processInstanceDetails) {
name = this.processInstanceDetails.name ||
name =
this.processInstanceDetails.name ||
this.processInstanceDetails.processDefinitionName + ' - ' + this.getFormatDate(this.processInstanceDetails.started, dateFormat);
}
return name;
@@ -144,7 +142,6 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
}
onShowProcessDiagram() {
this.showProcessDiagram.emit({value: this.processInstanceId});
this.showProcessDiagram.emit({ value: this.processInstanceId });
}
}