From a2e5bca63e9d62fe90d14a33a7b8526729bdeaff Mon Sep 17 00:00:00 2001
From: mauriziovitale84 <maurizio.vitale@alfresco.com>
Date: Thu, 22 Sep 2016 17:06:17 +0100
Subject: [PATCH] Improve test coverage

---
 .../activiti-tasklist.component.spec.ts        | 18 +++++++++++++++++-
 .../components/activiti-tasklist.component.ts  |  2 +-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.spec.ts b/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.spec.ts
index bea68053ea..6e0780a68f 100644
--- a/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.spec.ts
+++ b/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.spec.ts
@@ -21,7 +21,7 @@ import {
     expect,
     beforeEach
 } from '@angular/core/testing';
-
+import { SimpleChange } from '@angular/core';
 import { ActivitiTaskList } from './activiti-tasklist.component';
 import { ActivitiTaskListService } from '../services/activiti-tasklist.service';
 import { UserTaskFilterRepresentationModel } from '../models/filter.model';
@@ -120,6 +120,11 @@ describe('ActivitiTaskList', () => {
         taskList.ngOnInit();
     });
 
+    it('should return a currentId null when the taskList is empty', () => {
+        taskList.selectFirstTask();
+        expect(taskList.getCurrentTaskId()).toBeNull();
+    });
+
     it('should throw an exception when the response is wrong', (done) => {
         spyOn(taskList.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeErrorTaskPromise));
         taskList.taskFilter = new UserTaskFilterRepresentationModel({filter: { state: 'open', assignment: 'fake-assignee'}});
@@ -140,10 +145,21 @@ describe('ActivitiTaskList', () => {
 
         taskList.rowClick.subscribe(taskId => {
             expect(taskId).toEqual(999);
+            expect(taskList.getCurrentTaskId()).toEqual(999);
             done();
         });
 
         taskList.onRowClick(rowEvent);
     });
 
+    it('should reload task list by filter on binding changes', () => {
+        spyOn(taskList, 'load').and.stub();
+        const taskFilter = new UserTaskFilterRepresentationModel({filter: { state: 'open', assignment: 'fake-assignee'}});
+
+        let change = new SimpleChange(null, taskFilter);
+        taskList.ngOnChanges({ 'taskFilter': change });
+
+        expect(taskList.load).toHaveBeenCalled();
+    });
+
 });
diff --git a/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.ts b/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.ts
index ae8da9b896..f825d9362f 100644
--- a/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.ts
+++ b/ng2-components/ng2-activiti-tasklist/src/components/activiti-tasklist.component.ts
@@ -146,7 +146,7 @@ export class ActivitiTaskList implements OnInit, OnChanges {
     /**
      * Select the first task of a tasklist if present
      */
-    private selectFirstTask() {
+    selectFirstTask() {
         if (!this.isTaskListEmpty()) {
             this.currentTaskId = this.data.getRows()[0].getValue('id');
         } else {