[ADF-3763] fixed subscription for node child and invalid node id (#3991)

* [ADF-3763] fixed subscription for node child and invalid node id

* [ADF-3763] removed fdescribe

* [ADF-3763] added line for updating documentation
This commit is contained in:
Vito
2018-11-21 16:50:11 +00:00
committed by Eugenio Romano
parent 49c69c58f0
commit a5bf0d27e4
7 changed files with 112 additions and 29 deletions

View File

@@ -20,9 +20,10 @@ import { setupTestBed } from '@alfresco/adf-core';
import { TreeViewComponent } from './tree-view.component';
import { ContentTestingModule } from '../../testing/content.testing.module';
import { TreeViewService } from '../services/tree-view.service';
import { of } from 'rxjs';
import { of, throwError } from 'rxjs';
import { TreeBaseNode } from '../models/tree-view.model';
import { NodeEntry } from 'alfresco-js-api';
import { SimpleChange } from '@angular/core';
describe('TreeViewComponent', () => {
@@ -73,6 +74,8 @@ describe('TreeViewComponent', () => {
component = fixture.componentInstance;
spyOn(treeService, 'getTreeNodes').and.callFake((nodeId) => returnRootOrChildrenNode(nodeId));
component.nodeId = '9999999';
const changeNodeId = new SimpleChange(null, '9999999', true);
component.ngOnChanges({ 'nodeId': changeNodeId });
fixture.detectChanges();
}));
@@ -95,6 +98,24 @@ describe('TreeViewComponent', () => {
});
}));
it('should show only the correct subfolders when the nodeId is changed', async(() => {
component.nodeId = 'fake-second-id';
const changeNodeId = new SimpleChange('9999999', 'fake-second-id', true);
component.ngOnChanges({ 'nodeId': changeNodeId });
fixture.detectChanges();
fixture.whenStable().then(() => {
let rootFolderButton: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#button-fake-next-child-name');
expect(rootFolderButton).not.toBeNull();
rootFolderButton.click();
fixture.detectChanges();
fixture.whenStable().then(() => {
expect(element.querySelector('#fake-child-name-tree-child-node')).not.toBeNull();
expect(element.querySelector('#fake-second-name-tree-child-node')).not.toBeNull();
expect(element.querySelectorAll('mat-tree-node').length).toBe(4);
});
});
}));
it('should throw a nodeClicked event when a node is clicked', (done) => {
component.nodeClicked.subscribe((nodeClicked: NodeEntry) => {
expect(nodeClicked).toBeDefined();
@@ -178,4 +199,28 @@ describe('TreeViewComponent', () => {
});
}));
});
describe('When invalid nodeId is given', () => {
beforeEach(async(() => {
fixture = TestBed.createComponent(TreeViewComponent);
treeService = TestBed.get(TreeViewService);
spyOn(treeService, 'getTreeNodes').and.callFake((nodeId) => throwError('Invalid Node Id'));
fixture.componentInstance.nodeId = 'Poopoovic';
}));
afterEach(() => {
fixture.destroy();
});
it('should raise an error event when invalid nodeId is provided', (done) => {
fixture.componentInstance.error.subscribe((error) => {
expect(error).toBe('Invalid Node Id');
done();
});
const changeNodeId = new SimpleChange(null, 'Poopoovic', true);
fixture.componentInstance.ngOnChanges({ 'nodeId': changeNodeId });
fixture.detectChanges();
});
});
});