handle the logout route based on app config (#6587)

This commit is contained in:
Maurizio Vitale
2021-01-28 13:09:37 +00:00
committed by GitHub
parent 3010cfb310
commit a5e41e8492
2 changed files with 49 additions and 3 deletions

View File

@@ -20,6 +20,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { Router } from '@angular/router';
import { of, throwError } from 'rxjs';
import { AuthenticationService } from '../services';
import { AppConfigService } from '../app-config';
import { setupTestBed } from '../testing/setup-test-bed';
import { LogoutDirective } from './logout.directive';
import { CoreTestingModule } from '../testing/core.testing.module';
@@ -41,6 +42,7 @@ describe('LogoutDirective', () => {
let fixture: ComponentFixture<TestComponent>;
let router: Router;
let authService: AuthenticationService;
let appConfig: AppConfigService;
setupTestBed({
imports: [
@@ -55,11 +57,13 @@ describe('LogoutDirective', () => {
beforeEach(() => {
router = TestBed.inject(Router);
authService = TestBed.inject(AuthenticationService);
appConfig = TestBed.inject(AppConfigService);
fixture = TestBed.createComponent(TestComponent);
fixture.detectChanges();
appConfig.config['loginRoute'] = undefined;
});
it('should redirect to login on click', () => {
it('should redirect to login route if basic auth and loginRoute NOT defined', () => {
spyOn(router, 'navigate');
spyOn(authService, 'logout').and.returnValue(of(true));
@@ -70,6 +74,32 @@ describe('LogoutDirective', () => {
expect(router.navigate).toHaveBeenCalledWith(['/login']);
});
it('should redirect to loginRoute if basic auth and loginRoute defined', () => {
spyOn(router, 'navigate');
spyOn(authService, 'isOauth').and.returnValue(false);
appConfig.config['loginRoute'] = 'fake-base-logout';
spyOn(authService, 'logout').and.returnValue(of(true));
const button = fixture.nativeElement.querySelector('button');
button.click();
expect(authService.logout).toHaveBeenCalled();
expect(router.navigate).toHaveBeenCalledWith(['fake-base-logout']);
});
it('should redirect to redirectUriLogout on click if SSO auth', () => {
spyOn(router, 'navigate');
spyOn(authService, 'isOauth').and.returnValue(true);
spyOn(authService, 'logout').and.returnValue(of(true));
appConfig.config['oauth2.redirectUriLogout'] = 'fake-logout';
const button = fixture.nativeElement.querySelector('button');
button.click();
expect(authService.logout).toHaveBeenCalled();
expect(router.navigate).toHaveBeenCalledWith(['fake-logout']);
});
it('should redirect to login even on logout error', () => {
spyOn(router, 'navigate');
spyOn(authService, 'logout').and.returnValue(throwError('err'));
@@ -167,5 +197,6 @@ describe('LogoutDirective', () => {
expect(authService.logout).toHaveBeenCalled();
expect(router.navigate).not.toHaveBeenCalled();
});
});
});