inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-05-12 17:04:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AAE-4749] process filter notification fixes (#6773)

Browse Source 
* process filter notification fixes

* exclude flaky e2e
This commit is contained in:
Denys Vuika 2021-03-05 07:44:23 +00:00 committed by GitHub
parent df8a8fb61f
commit a5eb5acf5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
e2e/protractor.excludes.json
View File

@ -8,5 +8,6 @@
"C279931": "login problem APS not basic", "C279931": "login problem APS not basic",
"C279930": "login problem APS not basic", "C279930": "login problem APS not basic",
"C260241": "ADF-5335- this will exclude 2 tests", "C260241": "ADF-5335- this will exclude 2 tests",
"C587515": "https://alfresco.atlassian.net/browse/ADF-5340" "C587515": "https://alfresco.atlassian.net/browse/ADF-5340",
"C311290": "fix is in the progress by Vito"
} }

11
lib/process-services-cloud/src/lib/process/process-filters/components/edit-process-filter-cloud.component.spec.ts
View File

@ -107,6 +107,17 @@ describe('EditProcessFilterCloudComponent', () => {
fixture.destroy(); fixture.destroy();
}); });
it('should not raise filter change events if filter remains the same', () => {
let count = 0;
component.filterChange.subscribe(() => count++);
component.processFilter = fakeFilter;
component.processFilter = fakeFilter;
component.processFilter = fakeFilter;
expect(count).toBe(1);
});
it('should fetch process instance filter by id', async(() => { it('should fetch process instance filter by id', async(() => {
const processFilterIdChange = new SimpleChange(null, 'mock-process-filter-id', true); const processFilterIdChange = new SimpleChange(null, 'mock-process-filter-id', true);
component.ngOnChanges({ 'id': processFilterIdChange }); component.ngOnChanges({ 'id': processFilterIdChange });

17
lib/process-services-cloud/src/lib/process/process-filters/components/edit-process-filter-cloud.component.ts
View File

@ -103,6 +103,8 @@ export class EditProcessFilterCloudComponent implements OnInit, OnChanges, OnDes
@Input() @Input()
set processFilter(value: ProcessFilterCloudModel) { set processFilter(value: ProcessFilterCloudModel) {
const isChanged = this.isFilterChanged(this._filter, value);
this._filter = value; this._filter = value;
if (value?.appName) { if (value?.appName) {
@ -118,7 +120,9 @@ export class EditProcessFilterCloudComponent implements OnInit, OnChanges, OnDes
this.buildForm(this.processFilterProperties); this.buildForm(this.processFilterProperties);
this.filterChange.emit(value); if (isChanged) {
this.filterChange.emit(value);
}
} }
status: Array<DropdownOption> = [ status: Array<DropdownOption> = [
@ -637,6 +641,17 @@ export class EditProcessFilterCloudComponent implements OnInit, OnChanges, OnDes
]; ];
} }
private isFilterChanged(oldValue: ProcessFilterCloudModel, newValue: ProcessFilterCloudModel): boolean {
const oldJson = JSON.stringify(
this.processFilterCloudService.writeQueryParams(oldValue || {}, this.filterProperties)
);
const newJson = JSON.stringify(
this.processFilterCloudService.writeQueryParams(newValue || {}, this.filterProperties)
);
return oldJson !== newJson;
}
private createProcessFilterProperties(filterModel: ProcessFilterCloudModel): ProcessFilterProperties[] { private createProcessFilterProperties(filterModel: ProcessFilterCloudModel): ProcessFilterProperties[] {
const appVersionMultiple = []; const appVersionMultiple = [];