Fix e2e (#6087)

* fix protractor conf

* remove update env

* fix cli error script cs

* change screenshot plugin

* remove unused param

* fix

* fix

* fix

* moment comment nvm

* fix

* fix

* fix

* fix

* remove adf redirect

* fix

* fix

* save remote report

* report fix

* improve save result

* fix folder save

* fix folder save

* fix placeholder pointer , they needs refactor later

* fix

* fix lint

* fix

* remove test already covered by unit
fix the test in core needed
exclude the one impossible to make it works without APS basic support

* lint

* fix some logout missing

* fix

* Fix the custom-tasks-filters.e2e

* fix lint

* fix

* fix

* fix

* Fix wait on start process  and on process definition options

* Fix logout before login again

* fix uplaod test

* fix

* Fix infodrawer with check detail and sleep

* lint

* increase list of excluded test

* fix

* fix lint

* change wait method datatable

* fix

* fix

* revert check value

* fix

* fix

* change tag test

Co-authored-by: maurizio vitale <maurizio.vitale@alfresco.com>

e2e/content-services/upload/upload-dialog.e2e.ts

@@ -17,7 +17,7 @@
 
 import {
     ApiService,
-    BrowserActions,
+    BrowserActions, BrowserVisibility,
     LoginPage,
     UploadActions,
     UserModel,
@@ -98,15 +98,15 @@ describe('Upload component', () => {
         await apiService.getInstance().login(acsUser.email, acsUser.password);
         await loginPage.login(acsUser.email, acsUser.password);
         await contentServicesPage.goToDocumentList();
-   });
+    });
 
     beforeEach(async () => {
         await contentServicesPage.goToDocumentList();
     });
 
     afterEach(async () => {
-        const nbResults = await contentServicesPage.numberOfResultsDisplayed();
-        if (nbResults > 1) {
+        const nbResults = await contentServicesPage.emptyFolder.isPresent();
+        if (!nbResults) {
             const nodeIds = await contentServicesPage.getElementsDisplayedId();
             for (const nodeId of nodeIds) {
                 await uploadActions.deleteFileOrFolder(nodeId);
@@ -173,7 +173,7 @@ describe('Upload component', () => {
         await uploadDialog.clickOnCloseButton();
         await uploadDialog.dialogIsNotDisplayed();
         await contentServicesPage.uploadFile(pdfFileModel.location);
-        await contentServicesPage .checkContentIsDisplayed(pdfFileModel.name);
+        await contentServicesPage.checkContentIsDisplayed(pdfFileModel.name);
         await uploadDialog.fileIsUploaded(pdfFileModel.name);
         await uploadDialog.fileIsNotDisplayedInDialog(pngFileModel.name);
         await uploadDialog.fileIsNotDisplayedInDialog(pngFileModelTwo.name);
@@ -202,6 +202,7 @@ describe('Upload component', () => {
         await BrowserActions.click(versionManagePage.showNewVersionButton);
         await versionManagePage.uploadNewVersionFile(pngFileModel.location);
         await versionManagePage.closeVersionDialog();
+
         await uploadDialog.removeUploadedFile(pngFileModel.name);
         await contentServicesPage.checkContentIsDisplayed(pngFileModel.name);
         await uploadDialog.clickOnCloseButton();
@@ -231,18 +232,23 @@ describe('Upload component', () => {
         await uploadDialog.dialogIsNotDisplayed();
 
         await uploadToggles.enableFolderUpload();
+
         await browser.executeScript(` setInterval(() => {
                if(document.querySelector('[data-automation-id="adf"]')){
                     document.querySelector("#adf-upload-dialog-cancel-all").click();
                     document.querySelector("#adf-upload-dialog-cancel").click();
                 }
-              }, 500)`);
+              }, 2000)`);
         await contentServicesPage.uploadFolder(adfBigFolder.location);
 
-        await expect(await uploadDialog.getTitleText()).toEqual('Upload canceled');
+        await uploadDialog.fileIsUploaded('a_png_noBackground_file.PNG');
+        await uploadDialog.fileIsCancelled('a_png_noBackground_file.PNG');
+
+        await BrowserVisibility.waitUntilElementHasText(uploadDialog.title, 'Upload canceled');
         await uploadDialog.clickOnCloseButton();
         await uploadDialog.dialogIsNotDisplayed();
         await contentServicesPage.openFolder(adfBigFolder.name);
+        await browser.sleep(2000); // We need to wai when we upload too many files we have to wait the revert
         await expect(contentServicesPage.numberOfResultsDisplayed()).toBe(0);
     });
 });