Fix e2e (#6087)

* fix protractor conf

* remove update env

* fix cli error script cs

* change screenshot plugin

* remove unused param

* fix

* fix

* fix

* moment comment nvm

* fix

* fix

* fix

* fix

* remove adf redirect

* fix

* fix

* save remote report

* report fix

* improve save result

* fix folder save

* fix folder save

* fix placeholder pointer , they needs refactor later

* fix

* fix lint

* fix

* remove test already covered by unit
fix the test in core needed
exclude the one impossible to make it works without APS basic support

* lint

* fix some logout missing

* fix

* Fix the custom-tasks-filters.e2e

* fix lint

* fix

* fix

* fix

* Fix wait on start process  and on process definition options

* Fix logout before login again

* fix uplaod test

* fix

* Fix infodrawer with check detail and sleep

* lint

* increase list of excluded test

* fix

* fix lint

* change wait method datatable

* fix

* fix

* revert check value

* fix

* fix

* change tag test

Co-authored-by: maurizio vitale <maurizio.vitale@alfresco.com>

lib/cli/scripts/check-cs-env.ts

@@ -31,14 +31,14 @@ async function checkEnv() {
         });
 
         await alfrescoJsApi.login(program.username, program.password);
-    } catch (e) {
+    } catch (error) {
         console.log('Login error environment down or inaccessible');
         counter++;
         if (MAX_RETRY === counter) {
             console.log('Give up');
             process.exit(1);
         } else {
-            console.log(`Retry in 1 minute attempt N ${counter}`);
+            console.log(`Retry in 1 minute attempt N ${counter}`, error);
             sleep(TIMEOUT);
             checkEnv();
         }
@@ -74,8 +74,8 @@ async function checkDiskSpaceFullEnv() {
                 'overwrite': true
             });
         }
+        let pathFile = path.join(__dirname, '../', 'README.md');
 
-        let pathFile = path.join(__dirname, '../../', 'README.md');
         let file = fs.createReadStream(pathFile);
 
         let uploadedFile = await alfrescoJsApi.upload.uploadFile(
@@ -94,6 +94,8 @@ async function checkDiskSpaceFullEnv() {
     } catch (error) {
         counter++;
 
+        console.log('error', error);
+
         if (MAX_RETRY === counter) {
             console.log('=============================================================');
             console.log('================ Not able to upload a file ==================');
@@ -101,7 +103,7 @@ async function checkDiskSpaceFullEnv() {
             console.log('=============================================================');
             process.exit(1);
         } else {
-            console.log(`Retry in 1 minute attempt N ${counter}`);
+            console.log(`Retry in 1 minute attempt N ${counter}`, error);
             sleep(TIMEOUT);
             checkDiskSpaceFullEnv();
         }

lib/cli/scripts/init-aae-env.ts

@@ -65,20 +65,24 @@ async function healthCheck(nameService: string) {
             logger.info(`${nameService} is UP!`);
         }
     } catch (error) {
-        logger.error(`${nameService} is not reachable ${error.status} `);
+        logger.error(`${nameService} is not reachable error: `, error);
         isValid = false;
     }
 }
 
-function getApplicationByStatus(status: string) {
+async function getApplicationByStatus(status: string) {
     const url = `${args.host}/deployment-service/v1/applications/`;
 
     const pathParams = {}, queryParams = { status: status },
         headerParams = {}, formParams = {}, bodyParam = {},
         contentTypes = ['application/json'], accepts = ['application/json'];
     try {
+        await alfrescoJsApiDevops.login(args.devopsUsername, args.devopsPassword);
+
         return alfrescoJsApiDevops.oauth2Auth.callCustomApi(url, 'GET', pathParams, queryParams, headerParams, formParams, bodyParam,
-            contentTypes, accepts);
+            contentTypes, accepts).on('error',(error)=>{
+            logger.error(`Get application by status ${error} `);
+        });
 
     } catch (error) {
         logger.error(`Get application by status ${error.status} `);
@@ -203,6 +207,7 @@ function deploy(model: any) {
 function getAlfrescoJsApiInstance(configArgs: ConfigArgs) {
     const config = {
         provider: 'BPM',
+        hostEcm: `${configArgs.host}`,
         hostBpm: `${configArgs.host}`,
         authType: 'OAUTH',
         oauth2: {
@@ -395,6 +400,11 @@ async function main(configArgs: ConfigArgs) {
     }
 
     alfrescoJsApiModeler = getAlfrescoJsApiInstance(args);
+
+    AAE_MICROSERVICES.map(async (serviceName) => {
+        await healthCheck(serviceName);
+    });
+
     await alfrescoJsApiModeler.login(args.modelerUsername, args.modelerPassword).then(() => {
         logger.info('login SSO ok');
     }, (error) => {
@@ -402,10 +412,6 @@ async function main(configArgs: ConfigArgs) {
         process.exit(1);
     });
 
-    AAE_MICROSERVICES.map(async (serviceName) => {
-        await healthCheck(serviceName);
-    });
-
     if (isValid) {
         logger.error('The environment is up and running');
         alfrescoJsApiDevops = getAlfrescoJsApiInstance(args);