From a6bd153d27b1de642ea204ad6a0779238939f281 Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Mon, 31 Jul 2023 18:07:40 -0400 Subject: [PATCH] [ci:force] remove custom permission e2e test as already tested by unit --- demo-shell/resources/i18n/en.json | 1 - .../app/components/files/files.component.html | 22 ------------------- .../app/components/files/files.component.ts | 5 ----- .../document-list-permissions.e2e.ts | 9 -------- e2e/core/pages/content-services.page.ts | 5 ----- 5 files changed, 42 deletions(-) diff --git a/demo-shell/resources/i18n/en.json b/demo-shell/resources/i18n/en.json index c98af94b0c..91414cd792 100644 --- a/demo-shell/resources/i18n/en.json +++ b/demo-shell/resources/i18n/en.json @@ -52,7 +52,6 @@ }, "PERSONAL-FILES": "Personal Files", "WARN-MULTIPLE-UPLOADS": "Display warning for multiple uploads.", - "CUSTOM-PERMISSION-MESSAGE": "Enable custom permission message", "MEDIUM-TIME-FORMAT": "Enable medium time format for document list", "SEARCH": { "RADIO": { diff --git a/demo-shell/src/app/components/files/files.component.html b/demo-shell/src/app/components/files/files.component.html index e2d83cfa9b..1c51d43a6c 100644 --- a/demo-shell/src/app/components/files/files.component.html +++ b/demo-shell/src/app/components/files/files.component.html @@ -186,9 +186,6 @@ (name-click)="documentList.onNodeDblClick($any($event).detail?.node)" (filterSelection)="onFilterSelected($event)"> - -

You don't have permissions

-
{{ 'SEARCH.NO_RESULT' | translate }}
@@ -277,19 +274,6 @@ - - - - - -
- - {{'APP.CUSTOM-PERMISSION-MESSAGE' | translate}} - -
-
{{'APP.MEDIUM-TIME-FORMAT' | translate}} diff --git a/demo-shell/src/app/components/files/files.component.ts b/demo-shell/src/app/components/files/files.component.ts index 341bf61297..9f876b7317 100644 --- a/demo-shell/src/app/components/files/files.component.ts +++ b/demo-shell/src/app/components/files/files.component.ts @@ -237,7 +237,6 @@ export class FilesComponent implements OnInit, OnChanges, OnDestroy { stickyHeader: boolean; warnOnMultipleUploads = false; thumbnails = false; - enableCustomPermissionMessage = false; enableMediumTimeFormat = false; displayEmptyMetadata = false; hyperlinkNavigation = false; @@ -604,10 +603,6 @@ export class FilesComponent implements OnInit, OnChanges, OnDestroy { this.infinitePaginationComponent.reset(); } - canDownloadNode(node: MinimalNodeEntity): boolean { - return node && node.entry && node.entry.name === 'custom'; - } - onBeginUpload(event: UploadFilesEvent) { if (this.warnOnMultipleUploads && event) { const files = event.files || []; diff --git a/e2e/content-services/document-list/document-list-permissions.e2e.ts b/e2e/content-services/document-list/document-list-permissions.e2e.ts index dffdd453ec..8222ed0cec 100644 --- a/e2e/content-services/document-list/document-list-permissions.e2e.ts +++ b/e2e/content-services/document-list/document-list-permissions.e2e.ts @@ -16,7 +16,6 @@ */ import { browser } from 'protractor'; -import { ContentServicesPage } from '../../core/pages/content-services.page'; import { NavigationBarPage } from '../../core/pages/navigation-bar.page'; import { createApiService, BrowserActions, ErrorPage, LoginPage, StringUtil, UsersActions } from '@alfresco/adf-testing'; import { SitesApi } from '@alfresco/js-api'; @@ -24,7 +23,6 @@ import { SitesApi } from '@alfresco/js-api'; describe('Document List Component', () => { const loginPage = new LoginPage(); - const contentServicesPage = new ContentServicesPage(); const errorPage = new ErrorPage(); const navigationBarPage = new NavigationBarPage(); const apiService = createApiService(); @@ -61,12 +59,5 @@ describe('Document List Component', () => { await expect(await errorPage.getErrorCode()).toBe('403'); await expect(await errorPage.getErrorDescription()).toBe('You\'re not allowed access to this resource on the server.'); }); - - it('[C279924] Should display custom message when accessing a file without permissions', async () => { - await contentServicesPage.goToDocumentList(); - await contentServicesPage.enableCustomPermissionMessage(); - await BrowserActions.getUrl(browser.baseUrl + '/files/' + privateSite.entry.guid); - await expect(await errorPage.getErrorCode()).toBe('403'); - }); }); }); diff --git a/e2e/core/pages/content-services.page.ts b/e2e/core/pages/content-services.page.ts index c8b5e6d777..005f52605f 100644 --- a/e2e/core/pages/content-services.page.ts +++ b/e2e/core/pages/content-services.page.ts @@ -428,11 +428,6 @@ export class ContentServicesPage { await BrowserActions.click(infiniteScrollButton); } - async enableCustomPermissionMessage(): Promise { - const customPermissionMessage = element(by.cssContainingText('.mat-slide-toggle-content', 'Enable custom permission message')); - await BrowserActions.click(customPermissionMessage); - } - async enableMediumTimeFormat(): Promise { const mediumTimeFormat = $('#enableMediumTimeFormat'); await BrowserActions.click(mediumTimeFormat);