[AAE-2107] Move e2e to Unit test (#5535)

* [AAE-2107] Move e2e to Unit test

* * fixed namings

* * more unit test added

* * minor changes

e2e/process-services-cloud/process-custom-filters.e2e.ts

@@ -227,18 +227,6 @@ describe('Process list cloud', () => {
             await expect(await processCloudDemoPage.processListCloudComponent().getDataTable().checkListIsSorted('DESC', 'Business Key')).toBe(true);
         });
 
-        it('[C305054] Should display the actions filters Save, SaveAs and Delete', async () => {
-            await processCloudDemoPage.processFilterCloudComponent.clickAllProcessesFilter();
-            await expect(await processCloudDemoPage.processFilterCloudComponent.getActiveFilterName()).toBe('All Processes');
-            await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
-
-            const editProcessFilterCloudComponent = processCloudDemoPage.editProcessFilterCloudComponent();
-
-            await editProcessFilterCloudComponent.checkSaveButtonIsDisplayed();
-            await editProcessFilterCloudComponent.checkSaveAsButtonIsDisplayed();
-            await editProcessFilterCloudComponent.checkDeleteButtonIsDisplayed();
-        });
-
         it('[C297697] The value of the filter should be preserved when saving it', async () => {
             await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
             await processCloudDemoPage.editProcessFilterCloudComponent().setProcessInstanceId(completedProcess.entry.id);
@@ -297,32 +285,5 @@ describe('Process list cloud', () => {
             await BrowserActions.closeMenuAndDialogs();
         });
 
-        describe('Process List - Check Action Filters', () => {
-
-            beforeEach(async () => {
-                await LocalStorageUtil.setConfigField('adf-edit-process-filter', JSON.stringify({
-                    'actions': [
-                        'save',
-                        'saveAs'
-                    ]
-                }));
-                await navigationBarPage.navigateToProcessServicesCloudPage();
-                await appListCloudComponent.checkApsContainer();
-                await appListCloudComponent.goToApp(candidateBaseApp);
-                await tasksCloudDemoPage.taskListCloudComponent().checkTaskListIsLoaded();
-                await processCloudDemoPage.processFilterCloudComponent.clickOnProcessFilters();
-
-            });
-
-            it('[C305054] Should display the actions filters Save and SaveAs, Delete button is not displayed', async () => {
-                await processCloudDemoPage.processFilterCloudComponent.clickAllProcessesFilter();
-                await expect(await processCloudDemoPage.processFilterCloudComponent.getActiveFilterName()).toBe('All Processes');
-                await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
-                await processCloudDemoPage.editProcessFilterCloudComponent().checkSaveButtonIsDisplayed();
-                await processCloudDemoPage.editProcessFilterCloudComponent().checkSaveAsButtonIsDisplayed();
-                await processCloudDemoPage.editProcessFilterCloudComponent().checkDeleteButtonIsNotDisplayed();
-            });
-
-        });
    });
 });

e2e/process-services-cloud/process-filter-results.e2e.ts

@@ -184,14 +184,6 @@ describe('Process filters cloud', () => {
         await processCloudDemoPage.processListCloudComponent().checkContentIsNotDisplayedByName(differentAppUserProcessInstance.entry.name);
     });
 
-    it('[C306891] Should be able to see "No process found" when providing an initiator whitout processes', async () => {
-        await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
-        await processCloudDemoPage.editProcessFilterCloudComponent().setProperty('initiator', anotherUser.username);
-
-        await processCloudDemoPage.processListCloudComponent().getDataTable().waitTillContentLoaded();
-        await expect(await processListPage.getDisplayedProcessListTitle()).toEqual('No Processes Found');
-    });
-
     it('[C311315] Should be able to filter by process definition id', async () => {
         await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
         await processCloudDemoPage.editProcessFilterCloudComponent().setProperty('processDefinitionId', processDefinition.entry.id);

e2e/process-services-cloud/process-filter-task.e2e.ts

@@ -31,10 +31,13 @@ import { ProcessCloudDemoPage } from '../pages/adf/demo-shell/process-services/p
 import { ProcessDetailsCloudDemoPage } from '../pages/adf/demo-shell/process-services-cloud/process-details-cloud-demo.page';
 import { TasksCloudDemoPage } from '../pages/adf/demo-shell/process-services/tasks-cloud-demo.page';
 import { NavigationBarPage } from '../pages/adf/navigation-bar.page';
-import { ProcessListPage } from '../pages/adf/process-services/process-list.page';
 import { EditProcessFilterConfiguration } from './config/edit-process-filter.config';
 import { ProcessListCloudConfiguration } from './config/process-list-cloud.config';
-import { ProcessDefinitionCloud, ProcessInstanceCloud, StartTaskCloudResponseModel } from '@alfresco/adf-process-services-cloud';
+import {
+    ProcessDefinitionCloud,
+    ProcessInstanceCloud,
+    StartTaskCloudResponseModel
+} from '@alfresco/adf-process-services-cloud';
 
 describe('Process filters cloud', () => {
     const loginSSOPage = new LoginSSOPage();
@@ -45,7 +48,6 @@ describe('Process filters cloud', () => {
     const processDetailsCloudDemoPage = new ProcessDetailsCloudDemoPage();
     const taskHeaderCloudPage = new TaskHeaderCloudPage();
     const taskFormCloudComponent = new TaskFormCloudComponent();
-    const processListPage = new ProcessListPage();
     const apiService = new ApiService(
         browser.params.config.oauth2.clientId,
         browser.params.config.bpmHost, browser.params.config.oauth2.host, browser.params.config.providers
@@ -88,30 +90,6 @@ describe('Process filters cloud', () => {
         await processCloudDemoPage.processFilterCloudComponent.clickOnProcessFilters();
     });
 
-    it('[C290041] Should be displayed the "No Process Found" message when the process list is empty', async () => {
-        await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
-        await processCloudDemoPage.editProcessFilterCloudComponent().setAppNameDropDown(simpleApp);
-        await processCloudDemoPage.editProcessFilterCloudComponent().setStatusFilterDropDown('COMPLETED');
-
-        await processCloudDemoPage.processListCloudComponent().getDataTable().waitTillContentLoaded();
-        await expect(await processCloudDemoPage.processListCloudComponent().getDataTable().contents.count()).toBeGreaterThan(0);
-
-        await processCloudDemoPage.editProcessFilterCloudComponent().setProperty('processInstanceId', 'i_am_fake_id');
-        await expect(await processListPage.getDisplayedProcessListTitle()).toEqual('No Processes Found');
-    });
-
-    it('[C315296] Should NOT display "No Process Found" before displaying the process list', async () => {
-        await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
-        await processCloudDemoPage.editProcessFilterCloudComponent().setAppNameDropDown(simpleApp);
-        await processCloudDemoPage.editProcessFilterCloudComponent().setStatusFilterDropDown('COMPLETED');
-
-        await expect(await processListPage.titleNotPresent()).toBeTruthy();
-        await expect(await processCloudDemoPage.processListCloudComponent().getDataTable().contents.count()).toBeGreaterThan(0);
-
-        await processCloudDemoPage.editProcessFilterCloudComponent().setProperty('processInstanceId', 'i_am_fake_id');
-        await expect(await processListPage.getDisplayedProcessListTitle()).toEqual('No Processes Found');
-    });
-
     it('[C290040] Should be able to open the Task Details page by clicking on the process name', async () => {
         await processCloudDemoPage.editProcessFilterCloudComponent().openFilter();
         await processCloudDemoPage.editProcessFilterCloudComponent().setAppNameDropDown(simpleApp);

e2e/process-services-cloud/process-list-cloud-component.e2e.ts

@@ -1,102 +0,0 @@
-/*!
- * @license
- * Copyright 2019 Alfresco Software, Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import { ApiService, AppListCloudPage, GroupIdentityService, IdentityService, LocalStorageUtil, LoginSSOPage, ProcessDefinitionsService, ProcessInstancesService } from '@alfresco/adf-testing';
-import { browser } from 'protractor';
-import { ProcessCloudDemoPage } from '../pages/adf/demo-shell/process-services/process-cloud-demo.page';
-import { NavigationBarPage } from '../pages/adf/navigation-bar.page';
-import { ProcessListCloudConfiguration } from './config/process-list-cloud.config';
-
-describe('Process list cloud', () => {
-
-    describe('Process List', () => {
-        const loginSSOPage = new LoginSSOPage();
-        const navigationBarPage = new NavigationBarPage();
-        const appListCloudComponent = new AppListCloudPage();
-        const processCloudDemoPage = new ProcessCloudDemoPage();
-        const apiService = new ApiService(browser.params.config.oauth2.clientId, browser.params.config.bpmHost, browser.params.config.oauth2.host, 'BPM');
-
-        let processDefinitionService: ProcessDefinitionsService;
-        let processInstancesService: ProcessInstancesService;
-        let identityService: IdentityService;
-        let groupIdentityService: GroupIdentityService;
-        let testUser, groupInfo;
-
-        const candidateBaseApp = browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.name;
-        let jsonFile;
-        let runningProcess;
-
-        beforeAll(async () => {
-            await apiService.login(browser.params.identityAdmin.email, browser.params.identityAdmin.password);
-            identityService = new IdentityService(apiService);
-            groupIdentityService = new GroupIdentityService(apiService);
-            testUser = await identityService.createIdentityUserWithRole(apiService, [identityService.ROLES.ACTIVITI_USER]);
-            groupInfo = await groupIdentityService.getGroupInfoByGroupName('hr');
-            await identityService.addUserToGroup(testUser.idIdentityService, groupInfo.id);
-
-            await apiService.login(testUser.email, testUser.password);
-
-            processDefinitionService = new ProcessDefinitionsService(apiService);
-            const processDefinition = await processDefinitionService
-                .getProcessDefinitionByName(browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.processes.candidateGroupProcess, candidateBaseApp);
-
-            processInstancesService = new ProcessInstancesService(apiService);
-            runningProcess = await processInstancesService.createProcessInstance(processDefinition.entry.key, candidateBaseApp);
-
-            await loginSSOPage.loginSSOIdentityService(testUser.email, testUser.password);
-        });
-
-        afterAll(async () => {
-            await apiService.login(browser.params.identityAdmin.email, browser.params.identityAdmin.password);
-            await identityService.deleteIdentityUser(testUser.idIdentityService);
-
-        });
-
-        beforeEach(async () => {
-            const processListCloudConfiguration = new ProcessListCloudConfiguration();
-            jsonFile = processListCloudConfiguration.getConfiguration();
-
-            await LocalStorageUtil.setConfigField('adf-cloud-process-list', JSON.stringify(jsonFile));
-
-            await navigationBarPage.navigateToProcessServicesCloudPage();
-            await appListCloudComponent.checkApsContainer();
-            await appListCloudComponent.goToApp(candidateBaseApp);
-            await processCloudDemoPage.processFilterCloudComponent.clickOnProcessFilters();
-            await processCloudDemoPage.processFilterCloudComponent.clickRunningProcessesFilter();
-            await expect(await processCloudDemoPage.processFilterCloudComponent.getActiveFilterName()).toBe('Running Processes');
-            await processCloudDemoPage.processListCloudComponent().checkProcessListIsLoaded();
-            await processCloudDemoPage.processListCloudComponent().checkContentIsDisplayedById(runningProcess.entry.id);
-
-        });
-
-        it('[C291997] Should be able to change the default columns', async () => {
-
-            await expect(await processCloudDemoPage.processListCloudComponent().getDataTable().getNumberOfColumns()).toBe(10);
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('id');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('name');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('status');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('startDate');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('appName');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('businessKey');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('initiator');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('lastModified');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('processDefinitionId');
-            await processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('processDefinitionKey');
-
-        });
-   });
-});

e2e/process-services-cloud/start-task/start-task-custom-app-cloud.e2e.ts

@@ -199,13 +199,6 @@ describe('Start Task', () => {
         await expect(await tasksCloudDemoPage.taskFilterCloudComponent.getActiveFilterName()).toBe('My Tasks');
     });
 
-    it('[C291953] Assignee field should display the logged user as default', async () => {
-        await tasksCloudDemoPage.openNewTaskForm();
-        await startTask.checkFormIsDisplayed();
-        await expect(await peopleCloudComponent.checkSelectedPeople(testUser.firstName));
-        await startTask.clickCancelButton();
-    });
-
     it('[C305050] Should be able to reassign the removed user when starting a new task', async () => {
         await tasksCloudDemoPage.openNewTaskForm();
         await startTask.checkFormIsDisplayed();

e2e/process-services-cloud/task-filters-cloud.e2e.ts

@@ -63,11 +63,6 @@ describe('Task filters cloud', () => {
             await appListCloudComponent.goToApp(simpleApp);
         });
 
-        it('[C290011] Should display default filters when an app is deployed', async () => {
-            await tasksCloudDemoPage.taskFilterCloudComponent.checkMyTasksFilterIsDisplayed();
-            await tasksCloudDemoPage.taskFilterCloudComponent.checkCompletedTasksFilterIsDisplayed();
-        });
-
         it('[C290009] Should display default filters and created task', async () => {
             tasksService = new TasksService(apiService);
 
@@ -101,9 +96,5 @@ describe('Task filters cloud', () => {
             await tasksCloudDemoPage.taskListCloudComponent().checkContentIsDisplayedByName(completedTask);
         });
 
-        it('[C291792] Should select the first task filter from the list as default', async () => {
-
-            await expect(await tasksCloudDemoPage.taskFilterCloudComponent.firstFilterIsActive()).toBe(true);
-        });
    });
 });