enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-27 09:55:30 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions
+1 -1
View File
@@ -27,7 +27,7 @@ export class NodeActions {
async getNodesDisplayed(alfrescoJsApi, idList, numberOfElements) {
let promises = [];
const promises = [];
let nodeList;
for (let i = 0; i < (numberOfElements - 1); i++) {
+8 -8
View File
@@ -22,8 +22,8 @@ import TestConfig = require('../../test.config');
export class UploadActions {
async uploadFile(alfrescoJsApi, fileLocation, fileName, parentFolderId) {
let pathFile = path.join(TestConfig.main.rootPath + fileLocation);
let file = fs.createReadStream(pathFile);
const pathFile = path.join(TestConfig.main.rootPath + fileLocation);
const file = fs.createReadStream(pathFile);
return alfrescoJsApi.upload.uploadFile(
file,
@@ -39,10 +39,10 @@ export class UploadActions {
}
async createEmptyFiles(alfrescoJsApi, emptyFileNames: string[], parentFolderId) {
let filesRequest = [];
const filesRequest = [];
for (let i = 0; i < emptyFileNames.length; i++) {
let jsonItem = {};
const jsonItem = {};
jsonItem['name'] = emptyFileNames[i];
jsonItem['nodeType'] = 'cm:content';
filesRequest.push(jsonItem);
@@ -65,15 +65,15 @@ export class UploadActions {
}
async uploadFolder(alfrescoJsApi, sourcePath, folder) {
let absolutePath = '../../' + sourcePath;
let files = fs.readdirSync(path.join(__dirname, absolutePath));
const absolutePath = '../../' + sourcePath;
const files = fs.readdirSync(path.join(__dirname, absolutePath));
let uploadedFiles;
let promises = [];
const promises = [];
if (files && files.length > 0) {
for (const fileName of files) {
let pathFile = path.join(sourcePath, fileName);
const pathFile = path.join(sourcePath, fileName);
promises.push(this.uploadFile(alfrescoJsApi, pathFile, fileName, folder));
}
uploadedFiles = await Promise.all(promises);
+1 -1
View File
@@ -32,7 +32,7 @@ export class Roles {
const queryParams = {}, postBody = {};
const data = await this.api.performIdentityOperation(path, method, queryParams, postBody);
for (let key in data) {
for (const key in data) {
if (data[key].name === roleName) {
roleId = data[key].id;
}
+1 -1
View File
@@ -73,7 +73,7 @@ export class Tasks {
}
async createAndCompleteTask (taskName, appName) {
let task = await this.createStandaloneTask(taskName, appName);
const task = await this.createStandaloneTask(taskName, appName);
await this.claimTask(task.entry.id, appName);
await this.completeTask(task.entry.id, appName);
return task;
+17 -17
View File
@@ -25,7 +25,7 @@ import { browser } from 'protractor';
export class AppsActions {
async getProcessTaskId(alfrescoJsApi, processId) {
let taskList = await alfrescoJsApi.activiti.taskApi.listTasks({});
const taskList = await alfrescoJsApi.activiti.taskApi.listTasks({});
let taskId = -1;
taskList.data.forEach((task) => {
@@ -38,7 +38,7 @@ export class AppsActions {
}
async getAppDefinitionId(alfrescoJsApi, appModelId) {
let appDefinitions = await alfrescoJsApi.activiti.appsApi.getAppDefinitions();
const appDefinitions = await alfrescoJsApi.activiti.appsApi.getAppDefinitions();
let appDefinitionId = -1;
appDefinitions.data.forEach((appDefinition) => {
@@ -51,9 +51,9 @@ export class AppsActions {
}
async importPublishDeployApp(alfrescoJsApi, appFileLocation) {
let appCreated = await this.importApp(alfrescoJsApi, appFileLocation);
const appCreated = await this.importApp(alfrescoJsApi, appFileLocation);
let publishApp = await alfrescoJsApi.activiti.appsApi.publishAppDefinition(appCreated.id, new AppPublish());
const publishApp = await alfrescoJsApi.activiti.appsApi.publishAppDefinition(appCreated.id, new AppPublish());
await alfrescoJsApi.activiti.appsApi.deployAppDefinitions({ appDefinitions: [{ id: publishApp.appDefinition.id }] });
@@ -63,8 +63,8 @@ export class AppsActions {
async importApp(alfrescoJsApi, appFileLocation) {
browser.setFileDetector(new remote.FileDetector());
let pathFile = path.join(TestConfig.main.rootPath + appFileLocation);
let file = fs.createReadStream(pathFile);
const pathFile = path.join(TestConfig.main.rootPath + appFileLocation);
const file = fs.createReadStream(pathFile);
return await alfrescoJsApi.activiti.appsApi.importAppDefinition(file);
}
@@ -72,7 +72,7 @@ export class AppsActions {
async publishDeployApp(alfrescoJsApi, appId) {
browser.setFileDetector(new remote.FileDetector());
let publishApp = await alfrescoJsApi.activiti.appsApi.publishAppDefinition(appId, new AppPublish());
const publishApp = await alfrescoJsApi.activiti.appsApi.publishAppDefinition(appId, new AppPublish());
await alfrescoJsApi.activiti.appsApi.deployAppDefinitions({ appDefinitions: [{ id: publishApp.appDefinition.id }] });
@@ -82,12 +82,12 @@ export class AppsActions {
async importNewVersionAppDefinitionPublishDeployApp(alfrescoJsApi, appFileLocation, modelId) {
browser.setFileDetector(new remote.FileDetector());
let pathFile = path.join(TestConfig.main.rootPath + appFileLocation);
let file = fs.createReadStream(pathFile);
const pathFile = path.join(TestConfig.main.rootPath + appFileLocation);
const file = fs.createReadStream(pathFile);
let appCreated = await alfrescoJsApi.activiti.appsApi.importNewAppDefinition(modelId, file);
const appCreated = await alfrescoJsApi.activiti.appsApi.importNewAppDefinition(modelId, file);
let publishApp = await alfrescoJsApi.activiti.appsApi.publishAppDefinition(appCreated.id, new AppPublish());
const publishApp = await alfrescoJsApi.activiti.appsApi.publishAppDefinition(appCreated.id, new AppPublish());
await alfrescoJsApi.activiti.appsApi.deployAppDefinitions({ appDefinitions: [{ id: publishApp.appDefinition.id }] });
@@ -97,21 +97,21 @@ export class AppsActions {
async startProcess(alfrescoJsApi, app, processName?: string) {
browser.setFileDetector(new remote.FileDetector());
let appDefinitionsList = await alfrescoJsApi.activiti.appsApi.getAppDefinitions();
const appDefinitionsList = await alfrescoJsApi.activiti.appsApi.getAppDefinitions();
let appDefinition = appDefinitionsList.data.filter((currentApp) => {
const appDefinition = appDefinitionsList.data.filter((currentApp) => {
return currentApp.name === app.name;
});
let processDefinitionList = await alfrescoJsApi.activiti.processApi.getProcessDefinitions({ deploymentId: appDefinition.deploymentId });
const processDefinitionList = await alfrescoJsApi.activiti.processApi.getProcessDefinitions({ deploymentId: appDefinition.deploymentId });
let chosenProcess = processDefinitionList.data.find( (processDefinition) => {
const chosenProcess = processDefinitionList.data.find( (processDefinition) => {
return processDefinition.name === processName;
});
let processDefinitionIdToStart = chosenProcess ? chosenProcess.id : processDefinitionList.data[0].id;
const processDefinitionIdToStart = chosenProcess ? chosenProcess.id : processDefinitionList.data[0].id;
let startProcessOptions: any = { processDefinitionId: processDefinitionIdToStart };
const startProcessOptions: any = { processDefinitionId: processDefinitionIdToStart };
if (typeof processName !== 'undefined') {
startProcessOptions.name = processName;
+1 -1
View File
@@ -19,7 +19,7 @@ export class AppsRuntimeActions {
async getRuntimeAppByName(alfrescoJsApi, appName) {
let runtimeApps = await this.getRuntimeAppDefinitions(alfrescoJsApi);
const runtimeApps = await this.getRuntimeAppDefinitions(alfrescoJsApi);
let desiredApp;
for (let i = 0; i < runtimeApps.data.length; i++) {
+16 -16
View File
@@ -22,20 +22,20 @@ import path = require('path');
import TestConfig = require('../test.config');
import remote = require('selenium-webdriver/remote');
let JS_BIND_INPUT = function (target) {
let input = document.createElement('input');
const JS_BIND_INPUT = function (target) {
const input = document.createElement('input');
input.type = 'file';
input.style.display = 'none';
input.addEventListener('change', function (event) {
target.scrollIntoView(true);
let rect = target.getBoundingClientRect();
let x = rect.left + (rect.width >> 1);
let y = rect.top + (rect.height >> 1);
let data = { files: input.files };
const rect = target.getBoundingClientRect();
const x = rect.left + (rect.width >> 1);
const y = rect.top + (rect.height >> 1);
const data = { files: input.files };
['dragenter', 'dragover', 'drop'].forEach(function (name) {
let mouseEvent: any = document.createEvent('MouseEvent');
const mouseEvent: any = document.createEvent('MouseEvent');
mouseEvent.initMouseEvent(name, !0, !0, window, 0, 0, 0, x, y, !1, !1, !1, !1, 0, null);
mouseEvent.dataTransfer = data;
target.dispatchEvent(mouseEvent);
@@ -48,8 +48,8 @@ let JS_BIND_INPUT = function (target) {
return input;
};
let JS_BIND_INPUT_FOLDER = function (target) {
let input: any = document.createElement('input');
const JS_BIND_INPUT_FOLDER = function (target) {
const input: any = document.createElement('input');
input.type = 'file';
input.style.display = 'none';
input.multiple = true;
@@ -57,13 +57,13 @@ let JS_BIND_INPUT_FOLDER = function (target) {
input.addEventListener('change', function (event) {
target.scrollIntoView(true);
let rect = target.getBoundingClientRect();
let x = rect.left + (rect.width >> 1);
let y = rect.top + (rect.height >> 1);
let data = { files: input.files };
const rect = target.getBoundingClientRect();
const x = rect.left + (rect.width >> 1);
const y = rect.top + (rect.height >> 1);
const data = { files: input.files };
['dragenter', 'dragover', 'drop'].forEach(function (name) {
let mouseEvent: any = document.createEvent('MouseEvent');
const mouseEvent: any = document.createEvent('MouseEvent');
mouseEvent.initMouseEvent(name, !0, !0, window, 0, 0, 0, x, y, !1, !1, !1, !1, 0, null);
mouseEvent.dataTransfer = data;
target.dispatchEvent(mouseEvent);
@@ -81,7 +81,7 @@ export class DropActions {
dropFile(dropArea, filePath) {
browser.setFileDetector(new remote.FileDetector());
let absolutePath = path.resolve(path.join(TestConfig.main.rootPath, filePath));
const absolutePath = path.resolve(path.join(TestConfig.main.rootPath, filePath));
fs.accessSync(absolutePath, fs.constants.F_OK);
return dropArea.getWebElement().then((element) => {
@@ -95,7 +95,7 @@ export class DropActions {
dropFolder(dropArea, folderPath) {
browser.setFileDetector(new remote.FileDetector());
let absolutePath = path.resolve(path.join(TestConfig.main.rootPath, folderPath));
const absolutePath = path.resolve(path.join(TestConfig.main.rootPath, folderPath));
fs.accessSync(absolutePath, fs.constants.F_OK);
return dropArea.getWebElement().then((element) => {
+8 -8
View File
@@ -26,9 +26,9 @@ import { browser } from 'protractor';
export class UsersActions {
async createTenantAndUser(alfrescoJsApi) {
let newTenant = await alfrescoJsApi.activiti.adminTenantsApi.createTenant(new Tenant());
const newTenant = await alfrescoJsApi.activiti.adminTenantsApi.createTenant(new Tenant());
let user = new User({ tenantId: newTenant.id });
const user = new User({ tenantId: newTenant.id });
await alfrescoJsApi.activiti.adminUsersApi.createNewUser(user);
@@ -36,7 +36,7 @@ export class UsersActions {
}
async createApsUser(alfrescoJsApi, tenantId) {
let user = new User({ tenantId: tenantId });
const user = new User({ tenantId: tenantId });
await alfrescoJsApi.activiti.adminUsersApi.createNewUser(user);
@@ -45,9 +45,9 @@ export class UsersActions {
async getApsUserByEmail(alfrescoJsApi, email) {
let users = await alfrescoJsApi.activiti.adminUsersApi.getUsers();
const users = await alfrescoJsApi.activiti.adminUsersApi.getUsers();
let user = users.data.filter((currentUser) => {
const user = users.data.filter((currentUser) => {
return currentUser.email === email;
});
@@ -55,7 +55,7 @@ export class UsersActions {
}
async createApsUserWithName(alfrescoJsApi, tenantId, email, firstName, lastName) {
let user = new User({ tenantId: tenantId , email: email, firstName: firstName, lastName: lastName});
const user = new User({ tenantId: tenantId , email: email, firstName: firstName, lastName: lastName});
await alfrescoJsApi.activiti.adminUsersApi.createNewUser(user);
@@ -69,8 +69,8 @@ export class UsersActions {
async changeProfilePictureAps(alfrescoJsApi, fileLocation) {
browser.setFileDetector(new remote.FileDetector());
let pathFile = path.join(TestConfig.main.rootPath + fileLocation);
let file = fs.createReadStream(pathFile);
const pathFile = path.join(TestConfig.main.rootPath + fileLocation);
const file = fs.createReadStream(pathFile);
return alfrescoJsApi.activiti.profileApi.uploadProfilePicture(file);
}