enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions

View File

@@ -40,21 +40,21 @@ describe('Version component actions', () => {
const versionManagePage = new VersionManagePage();
const navigationBarPage = new NavigationBarPage();
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let txtFileModel = new FileModel({
const txtFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.TXT.file_name,
'location': resources.Files.ADF_DOCUMENTS.TXT.file_location
});
let fileModelVersionTwo = new FileModel({
const fileModelVersionTwo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -67,7 +67,7 @@ describe('Version component actions', () => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
let txtUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, txtFileModel.location, txtFileModel.name, '-my-');
const txtUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, txtFileModel.location, txtFileModel.name, '-my-');
Object.assign(txtFileModel, txtUploadedFile.entry);

View File

@@ -47,32 +47,32 @@ describe('Version component permissions', () => {
const contentServices = new ContentServicesPage();
let site;
let acsUser = new AcsUserModel();
let consumerUser = new AcsUserModel();
let collaboratorUser = new AcsUserModel();
let contributorUser = new AcsUserModel();
let managerUser = new AcsUserModel();
let fileCreatorUser = new AcsUserModel();
const acsUser = new AcsUserModel();
const consumerUser = new AcsUserModel();
const collaboratorUser = new AcsUserModel();
const contributorUser = new AcsUserModel();
const managerUser = new AcsUserModel();
const fileCreatorUser = new AcsUserModel();
let newVersionFile = new FileModel({
const newVersionFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG_B.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG_B.file_location
});
let lockFileModel = new FileModel({
const lockFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG_C.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG_C.file_location
});
let differentCreatorFile = new FileModel({
const differentCreatorFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG_D.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG_D.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
let nodeActions = new NodeActions();
const uploadActions = new UploadActions();
const nodeActions = new NodeActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -118,7 +118,7 @@ describe('Version component permissions', () => {
role: CONSTANTS.CS_USER_ROLES.MANAGER
});
let lockFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, lockFileModel.location, lockFileModel.name, site.entry.guid);
const lockFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, lockFileModel.location, lockFileModel.name, site.entry.guid);
Object.assign(lockFileModel, lockFileUploaded.entry);
nodeActions.lockNode(this.alfrescoJsApi, lockFileModel.id);
@@ -132,17 +132,17 @@ describe('Version component permissions', () => {
describe('Manager', () => {
let sameCreatorFile = new FileModel({
const sameCreatorFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
await this.alfrescoJsApi.login(managerUser.id, managerUser.password);
let sameCreatorFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, sameCreatorFile.location, sameCreatorFile.name, site.entry.guid);
const sameCreatorFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, sameCreatorFile.location, sameCreatorFile.name, site.entry.guid);
Object.assign(sameCreatorFile, sameCreatorFileUploaded.entry);
loginPage.loginToContentServicesUsingUserModel(managerUser);
@@ -239,17 +239,17 @@ describe('Version component permissions', () => {
});
describe('Contributor', () => {
let sameCreatorFile = new FileModel({
const sameCreatorFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
await this.alfrescoJsApi.login(contributorUser.id, contributorUser.password);
let sameCreatorFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, sameCreatorFile.location, sameCreatorFile.name, site.entry.guid);
const sameCreatorFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, sameCreatorFile.location, sameCreatorFile.name, site.entry.guid);
Object.assign(sameCreatorFile, sameCreatorFileUploaded.entry);
loginPage.loginToContentServicesUsingUserModel(contributorUser);
@@ -299,17 +299,17 @@ describe('Version component permissions', () => {
});
describe('Collaborator', () => {
let sameCreatorFile = new FileModel({
const sameCreatorFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
await this.alfrescoJsApi.login(collaboratorUser.id, collaboratorUser.password);
let sameCreatorFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, sameCreatorFile.location, sameCreatorFile.name, site.entry.guid);
const sameCreatorFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, sameCreatorFile.location, sameCreatorFile.name, site.entry.guid);
Object.assign(sameCreatorFile, sameCreatorFileUploaded.entry);
loginPage.loginToContentServicesUsingUserModel(collaboratorUser);

View File

@@ -39,21 +39,21 @@ describe('Version Properties', () => {
const versionManagePage = new VersionManagePage();
const navigationBarPage = new NavigationBarPage();
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let txtFileModel = new FileModel({
const txtFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.TXT_0B.file_name,
'location': resources.Files.ADF_DOCUMENTS.TXT_0B.file_location
});
let fileModelVersionTwo = new FileModel({
const fileModelVersionTwo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -66,7 +66,7 @@ describe('Version Properties', () => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
let txtUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, txtFileModel.location, txtFileModel.name, '-my-');
const txtUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, txtFileModel.location, txtFileModel.name, '-my-');
Object.assign(txtFileModel, txtUploadedFile.entry);

View File

@@ -40,36 +40,36 @@ describe('Version component', () => {
const navigationBarPage = new NavigationBarPage();
const versionManagePage = new VersionManagePage();
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let txtFileModel = new FileModel({
const txtFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.TXT.file_name,
'location': resources.Files.ADF_DOCUMENTS.TXT.file_location
});
let fileModelVersionTwo = new FileModel({
const fileModelVersionTwo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
let fileModelVersionThree = new FileModel({
const fileModelVersionThree = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG_B.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG_B.file_location
});
let fileModelVersionFor = new FileModel({
const fileModelVersionFor = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG_C.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG_C.file_location
});
let fileModelVersionFive = new FileModel({
const fileModelVersionFive = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG_D.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG_D.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',