enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions

View File

@@ -41,20 +41,20 @@ describe('Aspect oriented config', () => {
const metadataViewPage = new MetadataViewPage();
const navigationBarPage = new NavigationBarPage();
const configEditorPage = new ConfigEditorPage();
let contentServicesPage = new ContentServicesPage();
let modelOneName = 'modelOne', emptyAspectName = 'emptyAspect';
let defaultModel = 'cm', defaultEmptyPropertiesAspect = 'taggable', aspectName = 'Taggable';
const contentServicesPage = new ContentServicesPage();
const modelOneName = 'modelOne', emptyAspectName = 'emptyAspect';
const defaultModel = 'cm', defaultEmptyPropertiesAspect = 'taggable', aspectName = 'Taggable';
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let pngFileModel = new FileModel({
const pngFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -77,11 +77,11 @@ describe('Aspect oriented config', () => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
let uploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
const uploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
loginPage.loginToContentServicesUsingUserModel(acsUser);
let aspects = await this.alfrescoJsApi.core.nodesApi.getNode(uploadedFile.entry.id);
const aspects = await this.alfrescoJsApi.core.nodesApi.getNode(uploadedFile.entry.id);
aspects.entry.aspectNames.push(modelOneName.concat(':', emptyAspectName));

View File

@@ -45,7 +45,7 @@ describe('CardView Component', () => {
describe('key-value pair ', () => {
it('[C279938] Should the label be present', () => {
let label = element(by.css('div[data-automation-id="card-key-value-pairs-label-key-value-pairs"]'));
const label = element(by.css('div[data-automation-id="card-key-value-pairs-label-key-value-pairs"]'));
Util.waitUntilElementIsPresent(label);
});
@@ -67,7 +67,7 @@ describe('CardView Component', () => {
describe('SelectBox', () => {
it('[C279939] Should the label be present', () => {
let label = element(by.css('div[data-automation-id="card-select-label-select"]'));
const label = element(by.css('div[data-automation-id="card-select-label-select"]'));
Util.waitUntilElementIsPresent(label);
});
@@ -84,7 +84,7 @@ describe('CardView Component', () => {
describe('Text', () => {
it('[C279937] Should the label be present', () => {
let label = element(by.css('div[data-automation-id="card-textitem-label-name"]'));
const label = element(by.css('div[data-automation-id="card-textitem-label-name"]'));
Util.waitUntilElementIsPresent(label);
});
@@ -115,7 +115,7 @@ describe('CardView Component', () => {
describe('Int', () => {
it('[C279940] Should the label be present', () => {
let label = element(by.css('div[data-automation-id="card-textitem-label-int"]'));
const label = element(by.css('div[data-automation-id="card-textitem-label-int"]'));
Util.waitUntilElementIsPresent(label);
});
@@ -189,7 +189,7 @@ describe('CardView Component', () => {
describe('Float', () => {
it('[C279941] Should the label be present', () => {
let label = element(by.css('div[data-automation-id="card-textitem-label-float"]'));
const label = element(by.css('div[data-automation-id="card-textitem-label-float"]'));
Util.waitUntilElementIsPresent(label);
});
@@ -239,7 +239,7 @@ describe('CardView Component', () => {
describe('Boolean', () => {
it('[C279942] Should the label be present', () => {
let label = element(by.css('div[data-automation-id="card-boolean-label-boolean"]'));
const label = element(by.css('div[data-automation-id="card-boolean-label-boolean"]'));
Util.waitUntilElementIsPresent(label);
});
@@ -258,11 +258,11 @@ describe('CardView Component', () => {
describe('Date and DateTime', () => {
it('[C279961] Should the label be present', () => {
let labelDate = element(by.css('div[data-automation-id="card-dateitem-label-date"]'));
const labelDate = element(by.css('div[data-automation-id="card-dateitem-label-date"]'));
Util.waitUntilElementIsPresent(labelDate);
let labelDatetime = element(by.css('div[data-automation-id="card-dateitem-label-datetime"]'));
const labelDatetime = element(by.css('div[data-automation-id="card-dateitem-label-datetime"]'));
Util.waitUntilElementIsPresent(labelDatetime);
});
@@ -277,11 +277,11 @@ describe('CardView Component', () => {
it('[C279936] Should not be possible edit any parameter when editable property is false', () => {
cardViewPageComponent.disableEdit();
let editIconText = element(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-name"]'));
let editIconInt = element(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-int"]'));
let editIconFloat = element(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-float"]'));
let editIconKey = element(by.css('mat-icon[data-automation-id="card-key-value-pairs-button-key-value-pairs"]'));
let editIconData = element(by.css('mat-datetimepicker-toggle'));
const editIconText = element(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-name"]'));
const editIconInt = element(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-int"]'));
const editIconFloat = element(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-float"]'));
const editIconKey = element(by.css('mat-icon[data-automation-id="card-key-value-pairs-button-key-value-pairs"]'));
const editIconData = element(by.css('mat-datetimepicker-toggle'));
Util.waitUntilElementIsNotVisible(editIconText);
Util.waitUntilElementIsNotVisible(editIconInt);

View File

@@ -52,19 +52,19 @@ describe('permissions', () => {
const metadataViewPage = new MetadataViewPage();
const navigationBarPage = new NavigationBarPage();
let consumerUser = new AcsUserModel();
let collaboratorUser = new AcsUserModel();
let contributorUser = new AcsUserModel();
const consumerUser = new AcsUserModel();
const collaboratorUser = new AcsUserModel();
const contributorUser = new AcsUserModel();
let site;
let pngFileModel = new FileModel({
const pngFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',

View File

@@ -33,7 +33,7 @@ import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
describe('CardView Component - properties', () => {
let METADATA = {
const METADATA = {
DATA_FORMAT: 'mmm dd yyyy',
TITLE: 'Details',
COMMENTS_TAB: 'COMMENTS',
@@ -46,22 +46,22 @@ describe('CardView Component - properties', () => {
EDIT_BUTTON_TOOLTIP: 'Edit'
};
let loginPage = new LoginPage();
let navigationBarPage = new NavigationBarPage();
let viewerPage = new ViewerPage();
let metadataViewPage = new MetadataViewPage();
const loginPage = new LoginPage();
const navigationBarPage = new NavigationBarPage();
const viewerPage = new ViewerPage();
const metadataViewPage = new MetadataViewPage();
const contentServicesPage = new ContentServicesPage();
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let pngFileModel = new FileModel({
const pngFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -74,7 +74,7 @@ describe('CardView Component - properties', () => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
let pdfUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
const pdfUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
Object.assign(pngFileModel, pdfUploadedFile.entry);

View File

@@ -54,16 +54,16 @@ describe('Metadata component', () => {
const metadataViewPage = new MetadataViewPage();
const navigationBarPage = new NavigationBarPage();
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let folderName = 'Metadata Folder';
const folderName = 'Metadata Folder';
let pngFileModel = new FileModel({
const pngFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
let fileUrl;
@@ -80,7 +80,7 @@ describe('Metadata component', () => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
let pngUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
const pngUploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
Object.assign(pngFileModel, pngUploadedFile.entry);