enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions

View File

@@ -38,59 +38,59 @@ import { browser } from 'protractor';
xdescribe('Viewer', () => {
let viewerPage = new ViewerPage();
let navigationBarPage = new NavigationBarPage();
let loginPage = new LoginPage();
let contentServicesPage = new ContentServicesPage();
let uploadActions = new UploadActions();
const viewerPage = new ViewerPage();
const navigationBarPage = new NavigationBarPage();
const loginPage = new LoginPage();
const contentServicesPage = new ContentServicesPage();
const uploadActions = new UploadActions();
let site;
let acsUser = new AcsUserModel();
const acsUser = new AcsUserModel();
let pngFileUploaded;
const contentList = contentServicesPage.getDocumentList();
const shareDialog = new ShareDialog();
const about = new AboutPage();
let pngFileInfo = new FileModel({
const pngFileInfo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
let archiveFolderInfo = new FolderModel({
const archiveFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.ARCHIVE_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.ARCHIVE_FOLDER.folder_location
});
let excelFolderInfo = new FolderModel({
const excelFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.EXCEL_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.EXCEL_FOLDER.folder_location
});
let otherFolderInfo = new FolderModel({
const otherFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.OTHER_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.OTHER_FOLDER.folder_location
});
let pptFolderInfo = new FolderModel({
const pptFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.PPT_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.PPT_FOLDER.folder_location
});
let textFolderInfo = new FolderModel({
const textFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.TEXT_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.TEXT_FOLDER.folder_location
});
let wordFolderInfo = new FolderModel({
const wordFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.WORD_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.WORD_FOLDER.folder_location
});
let imgFolderInfo = new FolderModel({
const imgFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.IMG_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.IMG_FOLDER.folder_location
});
let imgRenditionFolderInfo = new FolderModel({
const imgRenditionFolderInfo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.IMG_RENDITION_FOLDER.folder_name,
'location': resources.Files.ADF_DOCUMENTS.IMG_RENDITION_FOLDER.folder_location
});
@@ -394,7 +394,7 @@ xdescribe('Viewer', () => {
describe('Display files via API', () => {
let wordFileInfo = new FileModel({
const wordFileInfo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.DOCX_SUPPORTED.file_name,
'location': resources.Files.ADF_DOCUMENTS.DOCX_SUPPORTED.file_location
});
@@ -439,7 +439,7 @@ xdescribe('Viewer', () => {
shareDialog.checkDialogIsDisplayed();
shareDialog.clickShareLinkButton();
browser.controlFlow().execute(async () => {
let sharedLink = await shareDialog.getShareLink();
const sharedLink = await shareDialog.getShareLink();
await browser.get(sharedLink);
viewerPage.checkFileIsLoaded();
@@ -456,7 +456,7 @@ xdescribe('Viewer', () => {
describe('Viewer - Code editor extension', () => {
let jsFileInfo = new FileModel({
const jsFileInfo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.JS.file_name,
'location': resources.Files.ADF_DOCUMENTS.JS.file_location
});

View File

@@ -33,19 +33,19 @@ import { UploadActions } from '../../actions/ACS/upload.actions';
describe('Content Services Viewer', () => {
let acsUser = new AcsUserModel();
let viewerPage = new ViewerPage();
let contentServicesPage = new ContentServicesPage();
let loginPage = new LoginPage();
const acsUser = new AcsUserModel();
const viewerPage = new ViewerPage();
const contentServicesPage = new ContentServicesPage();
const loginPage = new LoginPage();
let zoom;
let pdfFile = new FileModel({
const pdfFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PDF.file_name,
'firstPageText': resources.Files.ADF_DOCUMENTS.PDF.first_page_text,
'secondPageText': resources.Files.ADF_DOCUMENTS.PDF.second_page_text,
'lastPageNumber': resources.Files.ADF_DOCUMENTS.PDF.last_page_number
});
let protectedFile = new FileModel({
const protectedFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PDF_PROTECTED.file_name,
'firstPageText': resources.Files.ADF_DOCUMENTS.PDF_PROTECTED.first_page_text,
'secondPageText': resources.Files.ADF_DOCUMENTS.PDF_PROTECTED.second_page_text,
@@ -53,31 +53,31 @@ describe('Content Services Viewer', () => {
'password': resources.Files.ADF_DOCUMENTS.PDF_PROTECTED.password,
'location': resources.Files.ADF_DOCUMENTS.PDF_PROTECTED.file_location
});
let docxFile = new FileModel({
const docxFile = new FileModel({
'location': resources.Files.ADF_DOCUMENTS.DOCX_SUPPORTED.file_location,
'name': resources.Files.ADF_DOCUMENTS.DOCX_SUPPORTED.file_name,
'firstPageText': resources.Files.ADF_DOCUMENTS.DOCX_SUPPORTED.first_page_text
});
let jpgFile = new FileModel({
const jpgFile = new FileModel({
'location': resources.Files.ADF_DOCUMENTS.JPG.file_location,
'name': resources.Files.ADF_DOCUMENTS.JPG.file_name
});
let mp4File = new FileModel({
const mp4File = new FileModel({
'location': resources.Files.ADF_DOCUMENTS.MP4.file_location,
'name': resources.Files.ADF_DOCUMENTS.MP4.file_name
});
let unsupportedFile = new FileModel({
const unsupportedFile = new FileModel({
'location': resources.Files.ADF_DOCUMENTS.UNSUPPORTED.file_location,
'name': resources.Files.ADF_DOCUMENTS.UNSUPPORTED.file_name
});
let pptFile = new FileModel({
const pptFile = new FileModel({
'location': resources.Files.ADF_DOCUMENTS.PPT.file_location,
'name': resources.Files.ADF_DOCUMENTS.PPT.file_name,
'firstPageText': resources.Files.ADF_DOCUMENTS.PPT.first_page_text
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -90,25 +90,25 @@ describe('Content Services Viewer', () => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
let pdfFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, pdfFile.location, pdfFile.name, '-my-');
const pdfFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, pdfFile.location, pdfFile.name, '-my-');
Object.assign(pdfFile, pdfFileUploaded.entry);
let protectedFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, protectedFile.location, protectedFile.name, '-my-');
const protectedFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, protectedFile.location, protectedFile.name, '-my-');
Object.assign(protectedFile, protectedFileUploaded.entry);
let docxFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, docxFile.location, docxFile.name, '-my-');
const docxFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, docxFile.location, docxFile.name, '-my-');
Object.assign(docxFile, docxFileUploaded.entry);
let jpgFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, jpgFile.location, jpgFile.name, '-my-');
const jpgFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, jpgFile.location, jpgFile.name, '-my-');
Object.assign(jpgFile, jpgFileUploaded.entry);
let mp4FileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, mp4File.location, mp4File.name, '-my-');
const mp4FileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, mp4File.location, mp4File.name, '-my-');
Object.assign(mp4File, mp4FileUploaded.entry);
let pptFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, pptFile.location, pptFile.name, '-my-');
const pptFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, pptFile.location, pptFile.name, '-my-');
Object.assign(pptFile, pptFileUploaded.entry);
let unsupportedFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, unsupportedFile.location, unsupportedFile.name, '-my-');
const unsupportedFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, unsupportedFile.location, unsupportedFile.name, '-my-');
Object.assign(unsupportedFile, unsupportedFileUploaded.entry);
loginPage.loginToContentServicesUsingUserModel(acsUser);
@@ -119,7 +119,7 @@ describe('Content Services Viewer', () => {
});
afterAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
await uploadActions.deleteFilesOrFolder(this.alfrescoJsApi, pdfFile.getId());
await uploadActions.deleteFilesOrFolder(this.alfrescoJsApi, protectedFile.getId());

View File

@@ -31,14 +31,14 @@ import { UploadActions } from '../../actions/ACS/upload.actions';
describe('Viewer', () => {
let viewerPage = new ViewerPage();
let loginPage = new LoginPage();
let contentServicesPage = new ContentServicesPage();
let uploadActions = new UploadActions();
let acsUser = new AcsUserModel();
const viewerPage = new ViewerPage();
const loginPage = new LoginPage();
const contentServicesPage = new ContentServicesPage();
const uploadActions = new UploadActions();
const acsUser = new AcsUserModel();
let txtFileUploaded;
let txtFileInfo = new FileModel({
const txtFileInfo = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.TXT.file_name,
'location': resources.Files.ADF_DOCUMENTS.TXT.file_location
});

View File

@@ -33,25 +33,25 @@ import { UploadActions } from '../../actions/ACS/upload.actions';
describe('Viewer - properties', () => {
let acsUser = new AcsUserModel();
let viewerPage = new ViewerPage();
let contentServicesPage = new ContentServicesPage();
let loginPage = new LoginPage();
let navigationBarPage = new NavigationBarPage();
let dataTable = new DataTableComponentPage();
const acsUser = new AcsUserModel();
const viewerPage = new ViewerPage();
const contentServicesPage = new ContentServicesPage();
const loginPage = new LoginPage();
const navigationBarPage = new NavigationBarPage();
const dataTable = new DataTableComponentPage();
let pngFile = new FileModel({
const pngFile = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.PNG.file_name,
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
let fileForOverlay = new FileModel({
const fileForOverlay = new FileModel({
'name': 'fileForOverlay.png',
'location': resources.Files.ADF_DOCUMENTS.PNG.file_location
});
beforeAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -85,7 +85,7 @@ describe('Viewer - properties', () => {
});
afterAll(async (done) => {
let uploadActions = new UploadActions();
const uploadActions = new UploadActions();
await uploadActions.deleteFilesOrFolder(this.alfrescoJsApi, pngFile.getId());