inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

enable prefer-const rule for tslint, fix issues (#4409)

Browse Source 
* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
e2e/search/components/search-checkList.e2e.ts
View File

@@ -42,17 +42,17 @@ describe('Search Checklist Component', () => {
const searchDialog = new SearchDialog();
const searchResults = new SearchResultsPage();
let acsUser = new AcsUserModel();
let uploadActions = new UploadActions();
const acsUser = new AcsUserModel();
const uploadActions = new UploadActions();
let filterType = {
const filterType = {
folder: 'Folder',
document: 'Document',
custom: 'TEST_NAME'
};
let randomName = Util.generateRandomString();
let nodeNames = {
const randomName = Util.generateRandomString();
const nodeNames = {
document: `${randomName}.txt`,
folder: `${randomName}Folder`
};
@@ -135,7 +135,7 @@ describe('Search Checklist Component', () => {
let jsonFile;
beforeEach(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});
@@ -299,7 +299,7 @@ describe('Search Checklist Component', () => {
let jsonFile;
beforeEach(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});

34
e2e/search/components/search-date-range.e2e.ts
View File

@@ -33,15 +33,15 @@ import { DateUtil } from '../../util/dateUtil';
describe('Search Date Range Filter', () => {
let loginPage = new LoginPage();
let searchDialog = new SearchDialog();
let searchFilters = new SearchFiltersPage();
let dateRangeFilter = searchFilters.createdDateRangeFilterPage();
let searchResults = new SearchResultsPage();
let datePicker = new DatePickerPage();
let navigationBar = new NavigationBarPage();
let configEditor = new ConfigEditorPage();
let dataTable = new DataTableComponentPage();
const loginPage = new LoginPage();
const searchDialog = new SearchDialog();
const searchFilters = new SearchFiltersPage();
const dateRangeFilter = searchFilters.createdDateRangeFilterPage();
const searchResults = new SearchResultsPage();
const datePicker = new DatePickerPage();
const navigationBar = new NavigationBarPage();
const configEditor = new ConfigEditorPage();
const dataTable = new DataTableComponentPage();
beforeAll(async (done) => {
@@ -89,7 +89,7 @@ describe('Search Date Range Filter', () => {
});
it('[C277105] Should be able to type a date', () => {
let date = '01-May-18';
const date = '01-May-18';
dateRangeFilter.putFromDate(date);
browser.controlFlow().execute(async () => {
await expect(dateRangeFilter.getFromCalendarSelectedDate()).toEqual(dateRangeFilter.getFromDate());
@@ -138,11 +138,11 @@ describe('Search Date Range Filter', () => {
searchResults.sortByCreated(true);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Created');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Created');
for (const currentResult of results) {
currentResult.getAttribute('title').then(async (currentDate) => {
let currentDateFormatted = DateUtil.parse(currentDate, 'MMM DD, YYYY, h:mm:ss a');
const currentDateFormatted = DateUtil.parse(currentDate, 'MMM DD, YYYY, h:mm:ss a');
await expect(currentDateFormatted <= DateUtil.parse(toDate, 'DD-MM-YY')).toBe(true);
await expect(currentDateFormatted >= DateUtil.parse(fromDate, 'DD-MM-YY')).toBe(true);
@@ -162,8 +162,8 @@ describe('Search Date Range Filter', () => {
});
it('[C277114] Should display warning message if user doesn\'t set the date range properly', () => {
let toDate = '01-May-18';
let fromDate = '16-May-18';
const toDate = '01-May-18';
const fromDate = '16-May-18';
dateRangeFilter.checkToFieldIsDisplayed()
.putToDate(toDate)
@@ -193,7 +193,7 @@ describe('Search Date Range Filter', () => {
let jsonFile;
beforeAll(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});
@@ -213,7 +213,7 @@ describe('Search Date Range Filter', () => {
dateRangeFilter.checkFromFieldIsDisplayed()
.openFromDatePicker();
let todayDate = DateUtil.formatDate('MM-DD-YY');
const todayDate = DateUtil.formatDate('MM-DD-YY');
datePicker.selectTodayDate();
browser.controlFlow().execute(async () => {

66
e2e/search/components/search-number-range.e2e.ts
View File

@@ -114,7 +114,7 @@ describe('Search Number Range Filter', () => {
});
it('[C276922] Should be keep value when Number Range widget is collapsed', () => {
let size = 5;
const size = 5;
sizeRangeFilter.putFromNumber(size);
sizeRangeFilter.putToNumber(size);
searchFilters.clickSizeRangeFilterHeader()
@@ -159,8 +159,8 @@ describe('Search Number Range Filter', () => {
});
it('[C276943] Should be able to put a big value in To field', () => {
let toSize = 999999999;
let fromSize = 0;
const toSize = 999999999;
const fromSize = 0;
sizeRangeFilter.checkToFieldIsDisplayed()
.putToNumber(toSize)
.putFromNumber(fromSize);
@@ -172,10 +172,10 @@ describe('Search Number Range Filter', () => {
searchResults.sortBySize(false);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) <= toSize).toBe(true);
}
@@ -186,9 +186,9 @@ describe('Search Number Range Filter', () => {
});
it('[C276944] Should be able to filter by name when size range filter is applied', () => {
let nameFilter = searchFilters.textFiltersPage();
let toSize = 40;
let fromSize = 0;
const nameFilter = searchFilters.textFiltersPage();
const toSize = 40;
const fromSize = 0;
searchFilters.checkNameFilterIsDisplayed()
.checkNameFilterIsExpanded();
nameFilter.searchByName('*');
@@ -203,10 +203,10 @@ describe('Search Number Range Filter', () => {
searchResults.sortBySize(false);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) <= toSize).toBe(true);
}
@@ -221,10 +221,10 @@ describe('Search Number Range Filter', () => {
searchResults.sortBySize(false);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) <= toSize).toBe(true);
}
@@ -234,10 +234,10 @@ describe('Search Number Range Filter', () => {
});
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Display name');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Display name');
for (const currentResult of results) {
try {
let name = await currentResult.getAttribute('title');
const name = await currentResult.getAttribute('title');
if (name && name.trim() !== '') {
await expect(/z*/i.test(name)).toBe(true);
}
@@ -277,10 +277,10 @@ describe('Search Number Range Filter', () => {
searchResults.sortBySize(false);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(currentSize === '0').toBe(true);
}
@@ -315,11 +315,11 @@ describe('Search Number Range Filter', () => {
searchResults.sortBySize(false);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) <= 1000).toBe(true);
}
@@ -334,11 +334,11 @@ describe('Search Number Range Filter', () => {
expect(sizeRangeFilter.getToNumber()).toEqual('');
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) >= 1000).toBe(true);
}
@@ -394,7 +394,7 @@ describe('Search Number Range Filter', () => {
let jsonFile;
beforeEach(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});
@@ -414,8 +414,8 @@ describe('Search Number Range Filter', () => {
.clickSizeRangeFilterHeader()
.checkSizeRangeFilterIsExpanded();
let fromYear = (new Date()).getFullYear();
let toYear = fromYear + 1;
const fromYear = (new Date()).getFullYear();
const toYear = fromYear + 1;
sizeRangeFilter.checkToFieldIsDisplayed()
.putToNumber(toYear)
@@ -427,10 +427,10 @@ describe('Search Number Range Filter', () => {
searchResults.sortByCreated(false);
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Created');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Created');
for (const currentResult of results) {
currentResult.getAttribute('title').then(async (currentDate) => {
let currentDateFormatted = DateUtil.parse(currentDate, 'MMM DD, YYYY, h:mm:ss a');
const currentDateFormatted = DateUtil.parse(currentDate, 'MMM DD, YYYY, h:mm:ss a');
await expect(currentDateFormatted.getFullYear() <= toYear).toBe(true);
await expect(currentDateFormatted.getFullYear() >= fromYear).toBe(true);

14
e2e/search/components/search-radio.e2e.ts
View File

@@ -42,10 +42,10 @@ describe('Search Radio Component', () => {
const searchDialog = new SearchDialog();
const searchResults = new SearchResultsPage();
let acsUser = new AcsUserModel();
let uploadActions = new UploadActions();
const acsUser = new AcsUserModel();
const uploadActions = new UploadActions();
let filterType = {
const filterType = {
none: 'None',
all: 'All',
folder: 'Folder',
@@ -53,8 +53,8 @@ describe('Search Radio Component', () => {
custom: 'TEST_NAME'
};
let randomName = Util.generateRandomString();
let nodeNames = {
const randomName = Util.generateRandomString();
const nodeNames = {
document: `${randomName}.txt`,
folder: `${randomName}Folder`
};
@@ -137,7 +137,7 @@ describe('Search Radio Component', () => {
let jsonFile;
beforeEach(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});
@@ -281,7 +281,7 @@ describe('Search Radio Component', () => {
let jsonFile;
beforeEach(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});

26
e2e/search/components/search-slider.e2e.ts
View File

@@ -106,7 +106,7 @@ describe('Search Number Range Filter', () => {
});
it('[C276972] Should be keep value when Search Size Slider is collapsed', () => {
let size = 5;
const size = 5;
sizeSliderFilter.checkSliderIsDisplayed().setValue(size);
searchFilters.clickSizeSliderFilterHeader()
.checkSizeSliderFilterIsCollapsed()
@@ -117,16 +117,16 @@ describe('Search Number Range Filter', () => {
});
it('[C276981] Should be able to clear value in Search Size Slider', () => {
let size = 5;
const size = 5;
sizeSliderFilter.checkSliderIsDisplayed().setValue(size);
searchResults.sortBySize(false)
.tableIsLoaded();
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) <= 5000).toBe(true);
}
@@ -142,11 +142,11 @@ describe('Search Number Range Filter', () => {
.tableIsLoaded();
browser.controlFlow().execute(async () => {
let results = await dataTable.geCellElementDetail('Size');
for (let currentResult of results) {
const results = await dataTable.geCellElementDetail('Size');
for (const currentResult of results) {
try {
let currentSize = await currentResult.getAttribute('title');
const currentSize = await currentResult.getAttribute('title');
if (currentSize && currentSize.trim() !== '') {
await expect(parseInt(currentSize, 10) >= 5000).toBe(true);
}
@@ -160,7 +160,7 @@ describe('Search Number Range Filter', () => {
let jsonFile;
beforeEach(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});
@@ -184,7 +184,7 @@ describe('Search Number Range Filter', () => {
});
it('[C276985] Should be able to set min value for Search Size Slider', () => {
let minSize = 3;
const minSize = 3;
jsonFile.categories[2].component.settings.min = minSize;
navigationBar.clickConfigEditorButton();
@@ -206,7 +206,7 @@ describe('Search Number Range Filter', () => {
});
it('[C276986] Should be able to set max value for Search Size Slider', () => {
let maxSize = 50;
const maxSize = 50;
jsonFile.categories[2].component.settings.max = maxSize;
navigationBar.clickConfigEditorButton();
@@ -228,7 +228,7 @@ describe('Search Number Range Filter', () => {
});
it('[C276987] Should be able to set steps for Search Size Slider', () => {
let step = 10;
const step = 10;
jsonFile.categories[2].component.settings.step = step;
navigationBar.clickConfigEditorButton();
@@ -244,7 +244,7 @@ describe('Search Number Range Filter', () => {
.clickSizeSliderFilterHeader()
.checkSizeSliderFilterIsExpanded();
let randomValue = 5;
const randomValue = 5;
sizeSliderFilter.checkSliderIsDisplayed()
.setValue(randomValue);
expect(sizeSliderFilter.getValue()).toEqual(`0`);

24
e2e/search/components/search-sorting-picker.e2e.ts
View File

@@ -113,7 +113,7 @@ describe('Search Sorting Picker', () => {
});
it('[C277271] Should be able to add a custom search sorter in the "sort by" option', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
@@ -133,12 +133,12 @@ describe('Search Sorting Picker', () => {
});
it('[C277272] Should be able to exclude a standard search sorter from the sorting option', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
configEditor.clickClearButton();
let removedOption = jsonFile.sorting.options.splice(0, 1);
const removedOption = jsonFile.sorting.options.splice(0, 1);
configEditor.enterBigConfigurationText(JSON.stringify(jsonFile));
configEditor.clickSaveButton();
@@ -153,7 +153,7 @@ describe('Search Sorting Picker', () => {
});
it('[C277273] Should be able to set a default order for a search sorting option', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
@@ -200,7 +200,7 @@ describe('Search Sorting Picker', () => {
it('[C277286] Should be able to sort the search results by "Created Date" ASC', () => {
searchResults.sortByCreated(true);
browser.controlFlow().execute(async () => {
let results = await searchResults. dataTable.geCellElementDetail('Created');
const results = await searchResults. dataTable.geCellElementDetail('Created');
expect(contentServices.checkElementsDateSortedAsc(results)).toBe(true);
});
});
@@ -208,13 +208,13 @@ describe('Search Sorting Picker', () => {
it('[C277287] Should be able to sort the search results by "Created Date" DESC', () => {
searchResults.sortByCreated(false);
browser.controlFlow().execute(async () => {
let results = await searchResults. dataTable.geCellElementDetail('Created');
const results = await searchResults. dataTable.geCellElementDetail('Created');
expect(contentServices.checkElementsDateSortedDesc(results)).toBe(true);
});
});
it('[C277288] Should be able to sort the search results by "Modified Date" ASC', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
@@ -231,11 +231,11 @@ describe('Search Sorting Picker', () => {
.sortBy(true, 'Modified Date');
browser.controlFlow().execute(async () => {
let idList = await contentServices.getElementsDisplayedId();
let numberOfElements = await contentServices.numberOfResultsDisplayed();
const idList = await contentServices.getElementsDisplayedId();
const numberOfElements = await contentServices.numberOfResultsDisplayed();
let nodeList = await nodeActions.getNodesDisplayed(this.alfrescoJsApi, idList, numberOfElements);
let modifiedDateList = [];
const nodeList = await nodeActions.getNodesDisplayed(this.alfrescoJsApi, idList, numberOfElements);
const modifiedDateList = [];
for (let i = 0; i < nodeList.length; i++) {
modifiedDateList.push(new Date(nodeList[i].entry.modifiedAt));
}
@@ -254,7 +254,7 @@ describe('Search Sorting Picker', () => {
});
it('[C277301] Should be able to change default sorting option for the search results', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();

12
e2e/search/components/search-text.e2e.ts
View File

@@ -39,12 +39,12 @@ describe('Search component - Text widget', () => {
const navigationBarPage = new NavigationBarPage();
const searchFiltersPage = new SearchFiltersPage();
let loginPage = new LoginPage();
let searchDialog = new SearchDialog();
let searchResultPage = new SearchResultsPage();
const loginPage = new LoginPage();
const searchDialog = new SearchDialog();
const searchResultPage = new SearchResultsPage();
let acsUser = new AcsUserModel();
let newFolderModel = new FolderModel({'name': 'newFolder', 'description': 'newDescription'});
const acsUser = new AcsUserModel();
const newFolderModel = new FolderModel({'name': 'newFolder', 'description': 'newDescription'});
beforeAll(async (done) => {
@@ -88,7 +88,7 @@ describe('Search component - Text widget', () => {
let jsonFile;
beforeAll(() => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
});