enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-27 09:55:30 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions
@@ -113,7 +113,7 @@ describe('Search Sorting Picker', () => {
});
it('[C277271] Should be able to add a custom search sorter in the "sort by" option', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
@@ -133,12 +133,12 @@ describe('Search Sorting Picker', () => {
});
it('[C277272] Should be able to exclude a standard search sorter from the sorting option', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
configEditor.clickClearButton();
let removedOption = jsonFile.sorting.options.splice(0, 1);
const removedOption = jsonFile.sorting.options.splice(0, 1);
configEditor.enterBigConfigurationText(JSON.stringify(jsonFile));
configEditor.clickSaveButton();
@@ -153,7 +153,7 @@ describe('Search Sorting Picker', () => {
});
it('[C277273] Should be able to set a default order for a search sorting option', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
@@ -200,7 +200,7 @@ describe('Search Sorting Picker', () => {
it('[C277286] Should be able to sort the search results by "Created Date" ASC', () => {
searchResults.sortByCreated(true);
browser.controlFlow().execute(async () => {
let results = await searchResults. dataTable.geCellElementDetail('Created');
const results = await searchResults. dataTable.geCellElementDetail('Created');
expect(contentServices.checkElementsDateSortedAsc(results)).toBe(true);
});
});
@@ -208,13 +208,13 @@ describe('Search Sorting Picker', () => {
it('[C277287] Should be able to sort the search results by "Created Date" DESC', () => {
searchResults.sortByCreated(false);
browser.controlFlow().execute(async () => {
let results = await searchResults. dataTable.geCellElementDetail('Created');
const results = await searchResults. dataTable.geCellElementDetail('Created');
expect(contentServices.checkElementsDateSortedDesc(results)).toBe(true);
});
});
it('[C277288] Should be able to sort the search results by "Modified Date" ASC', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();
@@ -231,11 +231,11 @@ describe('Search Sorting Picker', () => {
.sortBy(true, 'Modified Date');
browser.controlFlow().execute(async () => {
let idList = await contentServices.getElementsDisplayedId();
let numberOfElements = await contentServices.numberOfResultsDisplayed();
const idList = await contentServices.getElementsDisplayedId();
const numberOfElements = await contentServices.numberOfResultsDisplayed();
let nodeList = await nodeActions.getNodesDisplayed(this.alfrescoJsApi, idList, numberOfElements);
let modifiedDateList = [];
const nodeList = await nodeActions.getNodesDisplayed(this.alfrescoJsApi, idList, numberOfElements);
const modifiedDateList = [];
for (let i = 0; i < nodeList.length; i++) {
modifiedDateList.push(new Date(nodeList[i].entry.modifiedAt));
}
@@ -254,7 +254,7 @@ describe('Search Sorting Picker', () => {
});
it('[C277301] Should be able to change default sorting option for the search results', () => {
let searchConfiguration = new SearchConfiguration();
const searchConfiguration = new SearchConfiguration();
jsonFile = searchConfiguration.getConfiguration();
navigationBar.clickConfigEditorButton();
configEditor.clickSearchConfiguration();