enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions

View File

@@ -43,11 +43,11 @@ describe('ContentColumnList', () => {
});
it('should register column within parent document list', () => {
let columns = documentList.data.getColumns();
const columns = documentList.data.getColumns();
expect(columns.length).toBe(0);
let column = <DataColumn> {};
let result = columnList.registerColumn(column);
const column = <DataColumn> {};
const result = columnList.registerColumn(column);
expect(result).toBeTruthy();
expect(columns.length).toBe(1);
@@ -56,13 +56,13 @@ describe('ContentColumnList', () => {
it('should require document list instance to register action', () => {
columnList = new ContentColumnListComponent(null, logService);
let col = <DataColumn> {};
const col = <DataColumn> {};
expect(columnList.registerColumn(col)).toBeFalsy();
});
it('should require action instance to register', () => {
spyOn(documentList.actions, 'push').and.callThrough();
let result = columnList.registerColumn(null);
const result = columnList.registerColumn(null);
expect(result).toBeFalsy();
expect(documentList.actions.push).not.toHaveBeenCalled();

View File

@@ -39,7 +39,7 @@ export class ContentColumnListComponent {
*/
registerColumn(column: DataColumn): boolean {
if (this.documentList && column) {
let columns = this.documentList.data.getColumns();
const columns = this.documentList.data.getColumns();
columns.push(column);
return true;
}

View File

@@ -45,18 +45,18 @@ describe('ContentColumn', () => {
it('should register model within parent column list', () => {
spyOn(columnList, 'registerColumn').and.callThrough();
let column = new ContentColumnComponent(columnList, logService);
const column = new ContentColumnComponent(columnList, logService);
column.ngAfterContentInit();
expect(columnList.registerColumn).toHaveBeenCalled();
let columns = documentList.data.getColumns();
const columns = documentList.data.getColumns();
expect(columns.length).toBe(1);
expect(columns[0]).toBe(column);
});
it('should setup screen reader title for thumbnail column', () => {
let column = new ContentColumnComponent(columnList, logService);
const column = new ContentColumnComponent(columnList, logService);
column.key = '$thumbnail';
column.ngOnInit();
@@ -64,7 +64,7 @@ describe('ContentColumn', () => {
});
it('should register on init', () => {
let column = new ContentColumnComponent(columnList, logService);
const column = new ContentColumnComponent(columnList, logService);
spyOn(column, 'register').and.callThrough();
column.ngAfterContentInit();