inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

enable prefer-const rule for tslint, fix issues (#4409)

Browse Source 
* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
lib/content-services/search/components/search-control.component.spec.ts
View File

@@ -103,7 +103,7 @@ describe('SearchControlComponent', () => {
});
function typeWordIntoSearchInput(word: string): void {
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
inputDebugElement.nativeElement.value = word;
inputDebugElement.nativeElement.focus();
inputDebugElement.nativeElement.dispatchEvent(new Event('input'));
@@ -120,7 +120,7 @@ describe('SearchControlComponent', () => {
of({ entry: { list: [] } })
);
let searchDisposable = component.searchChange.subscribe((value) => {
const searchDisposable = component.searchChange.subscribe((value) => {
expect(value).toBe('customSearchTerm');
searchDisposable.unsubscribe();
done();
@@ -161,7 +161,7 @@ describe('SearchControlComponent', () => {
it('should still fire an event when user inputs a search term less than 3 characters', (done) => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
let searchDisposable = component.searchChange.subscribe((value) => {
const searchDisposable = component.searchChange.subscribe((value) => {
expect(value).toBe('cu');
searchDisposable.unsubscribe();
});
@@ -182,7 +182,7 @@ describe('SearchControlComponent', () => {
});
it('search button should be hide', () => {
let searchButton: any = element.querySelector('#adf-search-button');
const searchButton: any = element.querySelector('#adf-search-button');
expect(searchButton).toBe(null);
});
@@ -202,7 +202,7 @@ describe('SearchControlComponent', () => {
it('should set browser autocomplete to off by default', async(() => {
fixture.detectChanges();
let attr = element.querySelector('#adf-control-input').getAttribute('autocomplete');
const attr = element.querySelector('#adf-control-input').getAttribute('autocomplete');
expect(attr).toBe('off');
}));
@@ -219,7 +219,7 @@ describe('SearchControlComponent', () => {
}));
xit('should fire a search when a enter key is pressed', (done) => {
let searchDisposable = component.submit.subscribe((value) => {
const searchDisposable = component.submit.subscribe((value) => {
expect(value).toBe('TEST');
searchDisposable.unsubscribe();
done();
@@ -229,9 +229,9 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('TEST');
let enterKeyEvent: any = new Event('keyup');
const enterKeyEvent: any = new Event('keyup');
enterKeyEvent.keyCode = '13';
inputDebugElement.nativeElement.dispatchEvent(enterKeyEvent);
});
@@ -253,7 +253,7 @@ describe('SearchControlComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let resultElement: Element = element.querySelector('#autocomplete-search-result-list');
const resultElement: Element = element.querySelector('#autocomplete-search-result-list');
expect(resultElement).not.toBe(null);
done();
});
@@ -268,7 +268,7 @@ describe('SearchControlComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let noResultElement: Element = element.querySelector('#search_no_result');
const noResultElement: Element = element.querySelector('#search_no_result');
expect(noResultElement).not.toBe(null);
done();
});
@@ -279,7 +279,7 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('NO RES');
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -300,12 +300,12 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('TEST');
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let resultElement: HTMLElement = <HTMLElement> element.querySelector('#result_option_0');
const resultElement: HTMLElement = <HTMLElement> element.querySelector('#result_option_0');
resultElement.focus();
expect(resultElement).not.toBe(null);
inputDebugElement.nativeElement.dispatchEvent(new KeyboardEvent('keypress', { key: 'TAB' }));
@@ -321,14 +321,14 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('TEST');
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let resultElement: HTMLElement = <HTMLElement> element.querySelector('#result_option_0');
expect(resultElement).not.toBeNull();
let escapeEvent: any = new Event('ESCAPE');
const escapeEvent: any = new Event('ESCAPE');
escapeEvent.keyCode = 27;
inputDebugElement.triggerEventHandler('keydown', escapeEvent);
fixture.whenStable().then(() => {
@@ -345,14 +345,14 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('TEST');
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let resultElement: HTMLElement = <HTMLElement> element.querySelector('#result_option_0');
expect(resultElement).not.toBeNull();
let escapeEvent: any = new Event('ENTER');
const escapeEvent: any = new Event('ENTER');
escapeEvent.keyCode = 13;
inputDebugElement.triggerEventHandler('keydown', escapeEvent);
fixture.whenStable().then(() => {
@@ -369,8 +369,8 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
let escapeEvent: any = new Event('ESCAPE');
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const escapeEvent: any = new Event('ESCAPE');
escapeEvent.keyCode = 27;
inputDebugElement.nativeElement.focus();
inputDebugElement.nativeElement.dispatchEvent(escapeEvent);
@@ -399,7 +399,7 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
typeWordIntoSearchInput('TEST');
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -415,7 +415,7 @@ describe('SearchControlComponent', () => {
xit('should select the second item on autocomplete list when ARROW DOWN is pressed on list', (done) => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('TEST');
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -426,7 +426,7 @@ describe('SearchControlComponent', () => {
fixture.detectChanges();
expect(document.activeElement.id).toBe('result_option_0');
let firstElement = debugElement.query(By.css('#result_option_0'));
const firstElement = debugElement.query(By.css('#result_option_0'));
firstElement.triggerEventHandler('keyup.arrowdown', { target: firstElement.nativeElement });
fixture.detectChanges();
expect(document.activeElement.id).toBe('result_option_1');
@@ -437,7 +437,7 @@ describe('SearchControlComponent', () => {
xit('should focus the input search when ARROW UP is pressed on the first list item', (done) => {
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
fixture.detectChanges();
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
typeWordIntoSearchInput('TEST');
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -448,7 +448,7 @@ describe('SearchControlComponent', () => {
fixture.detectChanges();
expect(document.activeElement.id).toBe('result_option_0');
let firstElement = debugElement.query(By.css('#result_option_0'));
const firstElement = debugElement.query(By.css('#result_option_0'));
firstElement.triggerEventHandler('keyup.arrowup', { target: firstElement.nativeElement });
fixture.detectChanges();
expect(document.activeElement.id).toBe('adf-control-input');
@@ -465,7 +465,7 @@ describe('SearchControlComponent', () => {
tick(100);
let searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
const searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
component.subscriptAnimationState = 'active';
fixture.detectChanges();
@@ -490,7 +490,7 @@ describe('SearchControlComponent', () => {
tick(100);
let searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
const searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
searchButton.triggerEventHandler('click', null);
tick(100);
@@ -506,10 +506,10 @@ describe('SearchControlComponent', () => {
fixture.detectChanges();
tick(100);
let searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
const searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
searchButton.triggerEventHandler('click', null);
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
tick(100);
fixture.detectChanges();
@@ -525,7 +525,7 @@ describe('SearchControlComponent', () => {
tick(100);
let searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
const searchButton: DebugElement = debugElement.query(By.css('#adf-search-button'));
component.subscriptAnimationState = 'active';
fixture.detectChanges();
@@ -554,7 +554,7 @@ describe('SearchControlComponent', () => {
tick(100);
let inputDebugElement = debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = debugElement.query(By.css('#adf-control-input'));
component.subscriptAnimationState = 'active';
fixture.detectChanges();
@@ -579,7 +579,7 @@ describe('SearchControlComponent', () => {
it('should emit a option clicked event when item is clicked', (done) => {
spyOn(component, 'isSearchBarActive').and.returnValue(true);
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
let clickDisposable = component.optionClicked.subscribe((item) => {
const clickDisposable = component.optionClicked.subscribe((item) => {
expect(item.entry.id).toBe('123');
clickDisposable.unsubscribe();
done();
@@ -589,7 +589,7 @@ describe('SearchControlComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let firstOption: DebugElement = debugElement.query(By.css('#result_name_0'));
const firstOption: DebugElement = debugElement.query(By.css('#result_name_0'));
firstOption.nativeElement.click();
});
});
@@ -597,7 +597,7 @@ describe('SearchControlComponent', () => {
it('should set deactivate the search after element is clicked', (done) => {
spyOn(component, 'isSearchBarActive').and.returnValue(true);
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
let clickDisposable = component.optionClicked.subscribe((item) => {
const clickDisposable = component.optionClicked.subscribe((item) => {
expect(component.subscriptAnimationState).toBe('inactive');
clickDisposable.unsubscribe();
done();
@@ -608,7 +608,7 @@ describe('SearchControlComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
let firstOption: DebugElement = debugElement.query(By.css('#result_name_0'));
const firstOption: DebugElement = debugElement.query(By.css('#result_name_0'));
firstOption.nativeElement.click();
});
});
@@ -616,7 +616,7 @@ describe('SearchControlComponent', () => {
it('should NOT reset the search term after element is clicked', (done) => {
spyOn(component, 'isSearchBarActive').and.returnValue(true);
searchServiceSpy.and.returnValue(of(JSON.parse(JSON.stringify(results))));
let clickDisposable = component.optionClicked.subscribe((item) => {
const clickDisposable = component.optionClicked.subscribe((item) => {
expect(component.searchTerm).not.toBeFalsy();
expect(component.searchTerm).toBe('TEST');
clickDisposable.unsubscribe();
@@ -628,7 +628,7 @@ describe('SearchControlComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
let firstOption: DebugElement = debugElement.query(By.css('#result_name_0'));
const firstOption: DebugElement = debugElement.query(By.css('#result_name_0'));
firstOption.nativeElement.click();
});
});
@@ -649,7 +649,7 @@ describe('SearchControlComponent', () => {
searchServiceSpy.and.returnValue(of(noResult));
fixtureCustom.detectChanges();
let inputDebugElement = fixtureCustom.debugElement.query(By.css('#adf-control-input'));
const inputDebugElement = fixtureCustom.debugElement.query(By.css('#adf-control-input'));
inputDebugElement.nativeElement.value = 'SOMETHING';
inputDebugElement.nativeElement.focus();
inputDebugElement.nativeElement.dispatchEvent(new Event('input'));

6
lib/content-services/search/components/search-control.component.ts
View File

@@ -217,20 +217,20 @@ export class SearchControlComponent implements OnInit, OnDestroy {
selectFirstResult() {
if ( this.listResultElement && this.listResultElement.length > 0) {
let firstElement: MatListItem = <MatListItem> this.listResultElement.first;
const firstElement: MatListItem = <MatListItem> this.listResultElement.first;
firstElement._getHostElement().focus();
}
}
onRowArrowDown($event: KeyboardEvent): void {
let nextElement: any = this.getNextElementSibling(<Element> $event.target);
const nextElement: any = this.getNextElementSibling(<Element> $event.target);
if (nextElement) {
nextElement.focus();
}
}
onRowArrowUp($event: KeyboardEvent): void {
let previousElement: any = this.getPreviousElementSibling(<Element> $event.target);
const previousElement: any = this.getPreviousElementSibling(<Element> $event.target);
if (previousElement) {
previousElement.focus();
} else {

4
lib/content-services/search/components/search-date-range/search-date-range.component.spec.ts
View File

@@ -29,8 +29,8 @@ describe('SearchDateRangeComponent', () => {
describe('component class', () => {
let component: SearchDateRangeComponent;
let fromDate = '2016-10-16';
let toDate = '2017-10-16';
const fromDate = '2016-10-16';
const toDate = '2017-10-16';
const localeFixture = 'it';
const dateFormatFixture = 'DD-MMM-YY';

2
lib/content-services/search/components/search-filter/models/search-filter-list.model.ts
View File

@@ -127,7 +127,7 @@ export class SearchFilterList<T> implements Iterable<T> {
[Symbol.iterator](): Iterator<T> {
let pointer = 0;
let items = this.visibleItems;
const items = this.visibleItems;
return {
next(): IteratorResult<T> {

2
lib/content-services/search/components/search-filter/search-filter.component.spec.ts
View File

@@ -589,7 +589,7 @@ describe('SearchFilterComponent', () => {
expect(queryBuilder.removeUserFacetBucket).toHaveBeenCalledTimes(3);
expect(queryBuilder.update).toHaveBeenCalled();
for (let entry of component.responseFacets[0].buckets.items) {
for (const entry of component.responseFacets[0].buckets.items) {
expect(entry.checked).toBeFalsy();
}
});

6
lib/content-services/search/components/search-filter/search-filter.component.ts
View File

@@ -93,7 +93,7 @@ export class SearchFilterComponent implements OnInit, OnDestroy {
private updateSelectedBuckets() {
if (this.responseFacets) {
this.selectedBuckets = [];
for (let field of this.responseFacets) {
for (const field of this.responseFacets) {
if (field.buckets) {
this.selectedBuckets.push(
...this.queryBuilder.getUserFacetBuckets(field.field)
@@ -146,7 +146,7 @@ export class SearchFilterComponent implements OnInit, OnDestroy {
resetSelectedBuckets(field: FacetField) {
if (field && field.buckets) {
for (let bucket of field.buckets.items) {
for (const bucket of field.buckets.items) {
bucket.checked = false;
this.queryBuilder.removeUserFacetBucket(field, bucket);
}
@@ -158,7 +158,7 @@ export class SearchFilterComponent implements OnInit, OnDestroy {
resetAllSelectedBuckets() {
this.responseFacets.forEach((field) => {
if (field && field.buckets) {
for (let bucket of field.buckets.items) {
for (const bucket of field.buckets.items) {
bucket.checked = false;
this.queryBuilder.removeUserFacetBucket(field, bucket);
}

4
lib/content-services/search/components/search-trigger.directive.ts
View File

@@ -162,7 +162,7 @@ export class SearchTriggerDirective implements ControlValueAccessor, OnDestroy {
handleInput(event: KeyboardEvent): void {
if (document.activeElement === event.target) {
let inputValue: string = (event.target as HTMLInputElement).value;
const inputValue: string = (event.target as HTMLInputElement).value;
this.onChange(inputValue);
if (inputValue) {
this.searchPanel.keyPressedStream.next(inputValue);
@@ -177,7 +177,7 @@ export class SearchTriggerDirective implements ControlValueAccessor, OnDestroy {
private isPanelOptionClicked(event: MouseEvent) {
let isPanelOption: boolean = false;
if ( event ) {
let clickTarget = event.target as HTMLElement;
const clickTarget = event.target as HTMLElement;
isPanelOption = !this.isNoResultOption(event) &&
!!this.searchPanel.panel &&
!!this.searchPanel.panel.nativeElement.contains(clickTarget);

10
lib/content-services/search/components/search.component.spec.ts
View File

@@ -87,7 +87,7 @@ describe('SearchComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let message: HTMLElement = <HTMLElement> element.querySelector('#component-result-message');
const message: HTMLElement = <HTMLElement> element.querySelector('#component-result-message');
expect(message.textContent).toBe('ERROR');
done();
});
@@ -103,13 +103,13 @@ describe('SearchComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let optionShowed = element.querySelectorAll('#autocomplete-search-result-list');
const optionShowed = element.querySelectorAll('#autocomplete-search-result-list');
expect(optionShowed).not.toBeNull();
component.forceHidePanel();
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let elementList = element.querySelector('#adf-search-results-content');
const elementList = element.querySelector('#adf-search-results-content');
expect(elementList.classList).toContain('adf-search-hide');
done();
});
@@ -125,9 +125,9 @@ describe('SearchComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
let optionShowed = element.querySelectorAll('#autocomplete-search-result-list > li').length;
const optionShowed = element.querySelectorAll('#autocomplete-search-result-list > li').length;
expect(optionShowed).toBe(1);
let folderOption: HTMLElement = <HTMLElement> element.querySelector('#result_option_0');
const folderOption: HTMLElement = <HTMLElement> element.querySelector('#result_option_0');
expect(folderOption.textContent.trim()).toBe('MyDoc');
done();
});

2
lib/content-services/search/search-query-builder.service.ts
View File

@@ -208,7 +208,7 @@ export class SearchQueryBuilderService {
* @returns The finished query
*/
buildQuery(): QueryBody {
let query = this.getFinalQuery();
const query = this.getFinalQuery();
const include = this.config.include || [];
if (include.length === 0) {