inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

enable prefer-const rule for tslint, fix issues (#4409)

Browse Source 
* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

84
lib/core/datatable/components/datatable/datatable.component.spec.ts
View File

@@ -105,7 +105,7 @@ describe('DataTable', () => {
}));
it('should use the cardview style if cardview is true', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
[
{ name: '1' },
{ name: '2' }
@@ -125,7 +125,7 @@ describe('DataTable', () => {
});
it('should use the cardview style if cardview is false', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
[
{ name: '1' },
{ name: '2' }
@@ -144,7 +144,7 @@ describe('DataTable', () => {
});
it('should hide the header if showHeader is false', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
[
{ name: '1' },
{ name: '2' }
@@ -164,7 +164,7 @@ describe('DataTable', () => {
});
it('should hide the header if there are no elements inside', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
);
dataTable.ngOnChanges({
@@ -177,7 +177,7 @@ describe('DataTable', () => {
});
it('should hide the header if noPermission is true', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
);
dataTable.noPermission = true;
@@ -193,7 +193,7 @@ describe('DataTable', () => {
});
it('should show the header if showHeader is true', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
[
{ name: '1' },
{ name: '2' }
@@ -234,7 +234,7 @@ describe('DataTable', () => {
});
it('should change the rows on changing of the data', () => {
let newData = new ObjectDataTableAdapter(
const newData = new ObjectDataTableAdapter(
[
{ name: 'TEST' },
{ name: 'FAKE' }
@@ -531,7 +531,7 @@ describe('DataTable', () => {
dataTable.actions = true;
fixture.detectChanges();
let actions = element.querySelectorAll('[id^=action_menu_right]');
const actions = element.querySelectorAll('[id^=action_menu_right]');
expect(actions.length).toBe(4);
});
@@ -550,26 +550,26 @@ describe('DataTable', () => {
dataTable.actionsPosition = 'left';
fixture.detectChanges();
let actions = element.querySelectorAll('[id^=action_menu_left]');
const actions = element.querySelectorAll('[id^=action_menu_left]');
expect(actions.length).toBe(4);
});
it('should initialize default adapter', () => {
let table = new DataTableComponent(null, null);
const table = new DataTableComponent(null, null);
expect(table.data).toBeUndefined();
table.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
expect(table.data).toEqual(jasmine.any(ObjectDataTableAdapter));
});
it('should initialize with custom data', () => {
let data = new ObjectDataTableAdapter([], []);
const data = new ObjectDataTableAdapter([], []);
dataTable.data = data;
dataTable.ngAfterContentInit();
expect(dataTable.data).toBe(data);
});
it('should emit row click event', (done) => {
let row = <DataRow> {};
const row = <DataRow> {};
dataTable.rowClick.subscribe((e) => {
expect(e.value).toBe(row);
@@ -582,7 +582,7 @@ describe('DataTable', () => {
it('should emit double click if there are two single click in 250ms', (done) => {
let row = <DataRow> {};
const row = <DataRow> {};
dataTable.ngOnChanges({});
dataTable.rowDblClick.subscribe(() => {
@@ -599,7 +599,7 @@ describe('DataTable', () => {
it('should emit double click if there are more than two single click in 250ms', (done) => {
let row = <DataRow> {};
const row = <DataRow> {};
dataTable.ngOnChanges({});
dataTable.rowDblClick.subscribe(() => {
@@ -618,7 +618,7 @@ describe('DataTable', () => {
it('should emit single click if there are two single click in more than 250ms', (done) => {
let row = <DataRow> {};
const row = <DataRow> {};
let clickCount = 0;
dataTable.ngOnChanges({});
@@ -638,7 +638,7 @@ describe('DataTable', () => {
});
it('should emit row-click dom event', (done) => {
let row = <DataRow> {};
const row = <DataRow> {};
fixture.nativeElement.addEventListener('row-click', (e) => {
expect(e.detail.value).toBe(row);
@@ -650,7 +650,7 @@ describe('DataTable', () => {
});
it('should emit row-dblclick dom event', (done) => {
let row = <DataRow> {};
const row = <DataRow> {};
fixture.nativeElement.addEventListener('row-dblclick', (e) => {
expect(e.detail.value).toBe(row);
@@ -662,14 +662,14 @@ describe('DataTable', () => {
});
it('should prevent default behaviour on row click event', () => {
let e = jasmine.createSpyObj('event', ['preventDefault']);
const e = jasmine.createSpyObj('event', ['preventDefault']);
dataTable.ngAfterContentInit();
dataTable.onRowClick(null, e);
expect(e.preventDefault).toHaveBeenCalled();
});
it('should prevent default behaviour on row double-click event', () => {
let e = jasmine.createSpyObj('event', ['preventDefault']);
const e = jasmine.createSpyObj('event', ['preventDefault']);
dataTable.ngOnChanges({});
dataTable.ngAfterContentInit();
dataTable.onRowDblClick(null, e);
@@ -678,7 +678,7 @@ describe('DataTable', () => {
it('should not sort if column is missing', () => {
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
let adapter = dataTable.data;
const adapter = dataTable.data;
spyOn(adapter, 'setSorting').and.callThrough();
dataTable.onColumnHeaderClick(null);
expect(adapter.setSorting).not.toHaveBeenCalled();
@@ -686,10 +686,10 @@ describe('DataTable', () => {
it('should not sort upon clicking non-sortable column header', () => {
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
let adapter = dataTable.data;
const adapter = dataTable.data;
spyOn(adapter, 'setSorting').and.callThrough();
let column = new ObjectDataColumn({
const column = new ObjectDataColumn({
key: 'column_1'
});
@@ -699,10 +699,10 @@ describe('DataTable', () => {
it('should set sorting upon column header clicked', () => {
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
let adapter = dataTable.data;
const adapter = dataTable.data;
spyOn(adapter, 'setSorting').and.callThrough();
let column = new ObjectDataColumn({
const column = new ObjectDataColumn({
key: 'column_1',
sortable: true
});
@@ -719,12 +719,12 @@ describe('DataTable', () => {
it('should invert sorting upon column header clicked', () => {
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
let adapter = dataTable.data;
let sorting = new DataSorting('column_1', 'asc');
const adapter = dataTable.data;
const sorting = new DataSorting('column_1', 'asc');
spyOn(adapter, 'setSorting').and.callThrough();
spyOn(adapter, 'getSorting').and.returnValue(sorting);
let column = new ObjectDataColumn({
const column = new ObjectDataColumn({
key: 'column_1',
sortable: true
});
@@ -759,7 +759,7 @@ describe('DataTable', () => {
});
it('should reset selection upon data rows change', () => {
let data = new ObjectDataTableAdapter([{}, {}, {}], []);
const data = new ObjectDataTableAdapter([{}, {}, {}], []);
dataTable.data = data;
dataTable.multiselect = true;
@@ -775,8 +775,8 @@ describe('DataTable', () => {
});
it('should update rows on "select all" click', () => {
let data = new ObjectDataTableAdapter([{}, {}, {}], []);
let rows = data.getRows();
const data = new ObjectDataTableAdapter([{}, {}, {}], []);
const rows = data.getRows();
dataTable.data = data;
dataTable.multiselect = true;
@@ -804,8 +804,8 @@ describe('DataTable', () => {
});
it('should require multiselect option to toggle row state', () => {
let data = new ObjectDataTableAdapter([{}, {}, {}], []);
let rows = data.getRows();
const data = new ObjectDataTableAdapter([{}, {}, {}], []);
const rows = data.getRows();
dataTable.data = data;
dataTable.multiselect = false;
@@ -825,9 +825,9 @@ describe('DataTable', () => {
});
it('should use special material url scheme', () => {
let column = <DataColumn> {};
const column = <DataColumn> {};
let row = {
const row = {
getValue: function (key: string) {
return 'material-icons://android';
}
@@ -837,9 +837,9 @@ describe('DataTable', () => {
});
it('should not use special material url scheme', () => {
let column = <DataColumn> {};
const column = <DataColumn> {};
let row = {
const row = {
getValue: function (key: string) {
return 'http://www.google.com';
}
@@ -849,9 +849,9 @@ describe('DataTable', () => {
});
it('should parse icon value', () => {
let column = <DataColumn> {};
const column = <DataColumn> {};
let row = {
const row = {
getValue: function (key: string) {
return 'material-icons://android';
}
@@ -861,9 +861,9 @@ describe('DataTable', () => {
});
it('should not parse icon value', () => {
let column = <DataColumn> {};
const column = <DataColumn> {};
let row = {
const row = {
getValue: function (key: string) {
return 'http://www.google.com';
}
@@ -898,7 +898,7 @@ describe('DataTable', () => {
});
it('should replace image source with fallback thumbnail on error', () => {
let event = <any> {
const event = <any> {
target: {
src: 'missing-image'
}
@@ -911,7 +911,7 @@ describe('DataTable', () => {
it('should replace image source with miscellaneous icon when fallback is not available', () => {
const originalSrc = 'missing-image';
let event = <any> {
const event = <any> {
target: {
src: originalSrc
}

28
lib/core/datatable/components/datatable/datatable.component.ts
View File

@@ -239,7 +239,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
}
ngDoCheck() {
let changes = this.differ.diff(this.rows);
const changes = this.differ.diff(this.rows);
if (changes) {
this.setTableRows(this.rows);
}
@@ -261,7 +261,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
private initAndSubscribeClickStream() {
this.unsubscribeClickStream();
let singleClickStream = this.click$
const singleClickStream = this.click$
.pipe(
buffer(
this.click$.pipe(
@@ -273,7 +273,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
);
this.singleClickStreamSub = singleClickStream.subscribe((dataRowEvents: DataRowEvent[]) => {
let event: DataRowEvent = dataRowEvents[0];
const event: DataRowEvent = dataRowEvents[0];
this.handleRowSelection(event.value, <MouseEvent | KeyboardEvent> event.event);
this.rowClick.emit(event);
if (!event.defaultPrevented) {
@@ -286,7 +286,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
}
});
let multiClickStream = this.click$
const multiClickStream = this.click$
.pipe(
buffer(
this.click$.pipe(
@@ -298,7 +298,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
);
this.multiClickStreamSub = multiClickStream.subscribe((dataRowEvents: DataRowEvent[]) => {
let event: DataRowEvent = dataRowEvents[0];
const event: DataRowEvent = dataRowEvents[0];
this.rowDblClick.emit(event);
if (!event.defaultPrevented) {
this.elementRef.nativeElement.dispatchEvent(
@@ -428,7 +428,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
if (event) {
event.preventDefault();
}
let dataRowEvent = new DataRowEvent(row, event, this);
const dataRowEvent = new DataRowEvent(row, event, this);
this.clickObserver.next(dataRowEvent);
}
@@ -471,7 +471,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
onColumnHeaderClick(column: DataColumn) {
if (column && column.sortable) {
let current = this.data.getSorting();
const current = this.data.getSorting();
let newDirection = 'asc';
if (current && column.key === current.key) {
newDirection = current.direction === 'asc' ? 'desc' : 'asc';
@@ -485,7 +485,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
this.isSelectAllChecked = matCheckboxChange.checked;
if (this.multiselect) {
let rows = this.data.getRows();
const rows = this.data.getRows();
if (rows && rows.length > 0) {
for (let i = 0; i < rows.length; i++) {
this.selectRow(rows[i], matCheckboxChange.checked);
@@ -510,7 +510,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
onImageLoadingError(event: Event, row: DataRow) {
if (event) {
let element = <any> event.target;
const element = <any> event.target;
if (this.fallbackThumbnail) {
element.src = this.fallbackThumbnail;
@@ -522,7 +522,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
isIconValue(row: DataRow, col: DataColumn): boolean {
if (row && col) {
let value = row.getValue(col.key);
const value = row.getValue(col.key);
return value && value.startsWith('material-icons://');
}
return false;
@@ -530,7 +530,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
asIconValue(row: DataRow, col: DataColumn): string {
if (this.isIconValue(row, col)) {
let value = row.getValue(col.key) || '';
const value = row.getValue(col.key) || '';
return value.replace('material-icons://', '');
}
return null;
@@ -542,14 +542,14 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
isColumnSorted(col: DataColumn, direction: string): boolean {
if (col && direction) {
let sorting = this.data.getSorting();
const sorting = this.data.getSorting();
return sorting && sorting.key === col.key && sorting.direction === direction;
}
return false;
}
getContextMenuActions(row: DataRow, col: DataColumn): any[] {
let event = new DataCellEvent(row, col, []);
const event = new DataCellEvent(row, col, []);
this.showRowContextMenu.emit(event);
return event.value.actions;
}
@@ -558,7 +558,7 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck,
const id = row.getValue('id');
if (!this.rowMenuCache[id]) {
let event = new DataCellEvent(row, col, []);
const event = new DataCellEvent(row, col, []);
this.showRowActionsMenu.emit(event);
if (!this.rowMenuCacheEnabled) {
return event.value.actions;