enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class

lib/core/datatable/data/object-datatable-adapter.spec.ts

@@ -25,20 +25,20 @@ import { ObjectDataColumn } from './object-datacolumn.model';
 describe('ObjectDataTableAdapter', () => {
 
     it('should init with empty row collection', () => {
-        let adapter = new ObjectDataTableAdapter(null, []);
+        const adapter = new ObjectDataTableAdapter(null, []);
         expect(adapter.getRows()).toBeDefined();
         expect(adapter.getRows().length).toBe(0);
     });
 
     it('should init with empty column collection', () => {
-        let adapter = new ObjectDataTableAdapter([], null);
+        const adapter = new ObjectDataTableAdapter([], null);
         expect(adapter.getColumns()).toBeDefined();
         expect(adapter.getColumns().length).toBeDefined();
     });
 
     it('should map rows', () => {
-        let adapter = new ObjectDataTableAdapter([{}, {}], null);
-        let rows = adapter.getRows();
+        const adapter = new ObjectDataTableAdapter([{}, {}], null);
+        const rows = adapter.getRows();
 
         expect(rows.length).toBe(2);
         expect(rows[0] instanceof ObjectDataRow).toBe(true);
@@ -46,11 +46,11 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should map columns without rows', () => {
-        let adapter = new ObjectDataTableAdapter(null, [
+        const adapter = new ObjectDataTableAdapter(null, [
             <DataColumn> {},
             <DataColumn> {}
         ]);
-        let columns = adapter.getColumns();
+        const columns = adapter.getColumns();
 
         expect(columns.length).toBe(2);
         expect(columns[0] instanceof ObjectDataColumn).toBe(true);
@@ -58,13 +58,13 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort by first column if column is available', () => {
-        let adapter = new ObjectDataTableAdapter(null, null);
+        const adapter = new ObjectDataTableAdapter(null, null);
         expect(adapter.getSorting()).toBeUndefined();
     });
 
     it('should apply new rows array', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
-        let newRows = [
+        const adapter = new ObjectDataTableAdapter([], []);
+        const newRows = [
             <DataRow> {},
             <DataRow> {}
         ];
@@ -74,7 +74,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should accept null for new rows array', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         expect(adapter.getRows()).toBeDefined();
         expect(adapter.getRows().length).toBe(0);
 
@@ -84,7 +84,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should reset rows by null value', () => {
-        let adapter = new ObjectDataTableAdapter([{}, {}], []);
+        const adapter = new ObjectDataTableAdapter([{}, {}], []);
         expect(adapter.getRows()).toBeDefined();
         expect(adapter.getRows().length).toBe(2);
 
@@ -94,15 +94,15 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort new row collection', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         spyOn(adapter, 'sort').and.callThrough();
         adapter.setRows([]);
         expect(adapter.sort).toHaveBeenCalled();
     });
 
     it('should apply new columns array', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
-        let columns = [
+        const adapter = new ObjectDataTableAdapter([], []);
+        const columns = [
             <DataColumn> {},
             <DataColumn> {}
         ];
@@ -112,7 +112,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should accept null for new columns array', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         expect(adapter.getColumns()).toBeDefined();
         expect(adapter.getColumns().length).toBe(0);
 
@@ -122,7 +122,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should reset columns by null value', () => {
-        let adapter = new ObjectDataTableAdapter([], [
+        const adapter = new ObjectDataTableAdapter([], [
             <DataColumn> {},
             <DataColumn> {}
         ]);
@@ -135,31 +135,31 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should fail getting value with row not defined', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         expect(() => { adapter.getValue(null, null); }).toThrowError('Row not found');
     });
 
     it('should fail getting value with column not defined', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         expect(() => { adapter.getValue(<DataRow> {}, null); }).toThrowError('Column not found');
     });
 
     it('should get value from row with column key', () => {
-        let value = 'hello world';
+        const value = 'hello world';
 
-        let row = jasmine.createSpyObj('row', ['getValue']);
+        const row = jasmine.createSpyObj('row', ['getValue']);
         row.getValue.and.returnValue(value);
 
-        let adapter = new ObjectDataTableAdapter([], []);
-        let result = adapter.getValue(row, <DataColumn> { key: 'col1' });
+        const adapter = new ObjectDataTableAdapter([], []);
+        const result = adapter.getValue(row, <DataColumn> { key: 'col1' });
 
         expect(row.getValue).toHaveBeenCalledWith('col1');
         expect(result).toBe(value);
     });
 
     it('should set new sorting', () => {
-        let sorting = new DataSorting('key', 'direction');
-        let adapter = new ObjectDataTableAdapter([], []);
+        const sorting = new DataSorting('key', 'direction');
+        const adapter = new ObjectDataTableAdapter([], []);
 
         adapter.setSorting(sorting);
         expect(adapter.getSorting()).toBe(sorting);
@@ -169,7 +169,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort rows with new sorting value', () => {
-        let adapter = new ObjectDataTableAdapter([{}, {}], []);
+        const adapter = new ObjectDataTableAdapter([{}, {}], []);
         spyOn(adapter.getRows(), 'sort').and.stub();
 
         adapter.setSorting(new DataSorting('key', 'direction'));
@@ -177,7 +177,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort rows only when sorting key provided', () => {
-        let adapter = new ObjectDataTableAdapter([{}, {}], []);
+        const adapter = new ObjectDataTableAdapter([{}, {}], []);
         spyOn(adapter.getRows(), 'sort').and.stub();
 
         adapter.setSorting(new DataSorting());
@@ -185,7 +185,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort by first column by default', () => {
-        let adapter = new ObjectDataTableAdapter(
+        const adapter = new ObjectDataTableAdapter(
             [
                 { id: 2, name: 'abs' },
                 { id: 1, name: 'xyz' }
@@ -195,13 +195,13 @@ describe('ObjectDataTableAdapter', () => {
             ]
         );
 
-        let rows = adapter.getRows();
+        const rows = adapter.getRows();
         expect(rows[0].getValue('id')).toBe(1);
         expect(rows[1].getValue('id')).toBe(2);
     });
 
     it('should take first sortable column by default', () => {
-        let adapter = new ObjectDataTableAdapter([], [
+        const adapter = new ObjectDataTableAdapter([], [
             <DataColumn> { key: 'icon' },
             new ObjectDataColumn({ key: 'id', sortable: true })
         ]);
@@ -215,7 +215,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort by dates', () => {
-        let adapter = new ObjectDataTableAdapter(
+        const adapter = new ObjectDataTableAdapter(
             [
                 { id: 1, created: new Date(2016, 7, 6, 15, 7, 2) },
                 { id: 2, created: new Date(2016, 7, 6, 15, 7, 1) }
@@ -228,13 +228,13 @@ describe('ObjectDataTableAdapter', () => {
 
         adapter.setSorting(new DataSorting('created', 'asc'));
 
-        let rows = adapter.getRows();
+        const rows = adapter.getRows();
         expect(rows[0].getValue('id')).toBe(2);
         expect(rows[1].getValue('id')).toBe(1);
     });
 
     it('should be sorting undefined if no sortable found', () => {
-        let adapter = new ObjectDataTableAdapter(
+        const adapter = new ObjectDataTableAdapter(
             [
                 { id: 2, name: 'abs' },
                 { id: 1, name: 'xyz' }
@@ -249,7 +249,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should sort asc and desc', () => {
-        let adapter = new ObjectDataTableAdapter(
+        const adapter = new ObjectDataTableAdapter(
             [
                 { id: 2, name: 'abs' },
                 { id: 1, name: 'xyz' }
@@ -269,7 +269,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should use asc for sort command by default', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         adapter.setSorting(null);
         expect(adapter.getSorting()).toBe(null);
 
@@ -283,7 +283,7 @@ describe('ObjectDataTableAdapter', () => {
     });
 
     it('should use direction for sort command', () => {
-        let adapter = new ObjectDataTableAdapter([], []);
+        const adapter = new ObjectDataTableAdapter([], []);
         adapter.setSorting(null);
         expect(adapter.getSorting()).toBe(null);
 
@@ -305,19 +305,19 @@ describe('ObjectDataRow', () => {
     });
 
     it('should get top level property value', () => {
-        let row = new ObjectDataRow({
+        const row = new ObjectDataRow({
             id: 1
         });
         expect(row.getValue('id')).toBe(1);
     });
 
     it('should not get top level property value', () => {
-        let row = new ObjectDataRow({});
+        const row = new ObjectDataRow({});
         expect(row.getValue('missing')).toBeUndefined();
     });
 
     it('should get nested property value', () => {
-        let row = new ObjectDataRow({
+        const row = new ObjectDataRow({
            name: {
                firstName: 'John',
                lastName: 'Doe'
@@ -328,19 +328,19 @@ describe('ObjectDataRow', () => {
     });
 
     it('should not get nested property value', () => {
-        let row = new ObjectDataRow({});
+        const row = new ObjectDataRow({});
         expect(row.getValue('some.missing.property')).toBeUndefined();
     });
 
     it('should check top level value exists', () => {
-        let row = new ObjectDataRow({ id: 1 });
+        const row = new ObjectDataRow({ id: 1 });
 
         expect(row.hasValue('id')).toBeTruthy();
         expect(row.hasValue('other')).toBeFalsy();
     });
 
     it('should check nested value exists', () => {
-        let row = new ObjectDataRow({
+        const row = new ObjectDataRow({
             name: {
                 firstName: 'John',
                 lastName: 'Doe'
@@ -353,12 +353,12 @@ describe('ObjectDataRow', () => {
     });
 
     it('should generateSchema generate a schema from data', () => {
-        let data =  [
+        const data =  [
             { id: 2, name: 'abs' },
             { id: 1, name: 'xyz' }
         ];
 
-        let schema = ObjectDataTableAdapter.generateSchema(data);
+        const schema = ObjectDataTableAdapter.generateSchema(data);
 
         expect(schema.length).toBe(2);
         expect(schema[0].title).toBe('id');