enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions

View File

@@ -89,14 +89,14 @@ describe('EcmUserService', () => {
it('should retrieve avatar url for current user', () => {
spyOn(contentService, 'getContentUrl').and.returnValue('fake/url/image/for/ecm/user');
let urlRs = service.getUserProfileImage('fake-avatar-id');
const urlRs = service.getUserProfileImage('fake-avatar-id');
expect(urlRs).toEqual('fake/url/image/for/ecm/user');
});
it('should not call content service without avatar id', () => {
spyOn(contentService, 'getContentUrl').and.callThrough();
let urlRs = service.getUserProfileImage(undefined);
const urlRs = service.getUserProfileImage(undefined);
expect(urlRs).toBeUndefined();
expect(contentService.getContentUrl).not.toHaveBeenCalled();
@@ -104,7 +104,7 @@ describe('EcmUserService', () => {
it('should build the body for the content service', () => {
spyOn(contentService, 'getContentUrl').and.callThrough();
let urlRs = service.getUserProfileImage('fake-avatar-id');
const urlRs = service.getUserProfileImage('fake-avatar-id');
expect(urlRs).toBeDefined();
expect(contentService.getContentUrl).toHaveBeenCalledWith({entry: {id: 'fake-avatar-id'}});