enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
This commit is contained in:
Denys Vuika
2019-03-25 12:19:33 +00:00
committed by Eugenio Romano
parent 26c5982a1a
commit a7a48e8b2b
581 changed files with 5435 additions and 5402 deletions

View File

@@ -178,7 +178,7 @@ describe('ChecklistComponent', () => {
}));
showChecklistDialog.click();
let addButtonDialog = <HTMLElement> window.document.querySelector('#add-check');
const addButtonDialog = <HTMLElement> window.document.querySelector('#add-check');
addButtonDialog.click();
fixture.whenStable().then(() => {
@@ -197,7 +197,7 @@ describe('ChecklistComponent', () => {
name: 'fake-check-name'
}));
fixture.detectChanges();
let checklistElementRemove = <HTMLElement> element.querySelector('#remove-fake-check-id');
const checklistElementRemove = <HTMLElement> element.querySelector('#remove-fake-check-id');
expect(checklistElementRemove).toBeDefined();
expect(checklistElementRemove).not.toBeNull();
checklistElementRemove.click();
@@ -220,7 +220,7 @@ describe('ChecklistComponent', () => {
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(checklistComponent.checklist.length).toBe(1);
let checklistElementRemove = <HTMLElement> element.querySelector('#remove-fake-check-id');
const checklistElementRemove = <HTMLElement> element.querySelector('#remove-fake-check-id');
expect(checklistElementRemove).toBeDefined();
expect(checklistElementRemove).not.toBeNull();
checklistElementRemove.click();
@@ -237,7 +237,7 @@ describe('ChecklistComponent', () => {
name: 'fake-check-name'
}));
fixture.detectChanges();
let change = new SimpleChange(null, 'new-fake-task-id', true);
const change = new SimpleChange(null, 'new-fake-task-id', true);
checklistComponent.ngOnChanges({
taskId: change
});
@@ -257,7 +257,7 @@ describe('ChecklistComponent', () => {
}));
fixture.detectChanges();
checklistComponent.taskId = null;
let change = new SimpleChange(null, 'new-fake-task-id', true);
const change = new SimpleChange(null, 'new-fake-task-id', true);
checklistComponent.ngOnChanges({
taskId: change
});
@@ -271,7 +271,7 @@ describe('ChecklistComponent', () => {
it('should emit checklist task created event when the checklist is successfully added', (done) => {
spyOn(service, 'addTask').and.returnValue(of({ id: 'fake-check-added-id', name: 'fake-check-added-name' }));
let disposableCreated = checklistComponent.checklistTaskCreated.subscribe((taskAdded: TaskDetailsModel) => {
const disposableCreated = checklistComponent.checklistTaskCreated.subscribe((taskAdded: TaskDetailsModel) => {
fixture.detectChanges();
expect(taskAdded.id).toEqual('fake-check-added-id');
expect(taskAdded.name).toEqual('fake-check-added-name');
@@ -281,7 +281,7 @@ describe('ChecklistComponent', () => {
done();
});
showChecklistDialog.click();
let addButtonDialog = <HTMLElement> window.document.querySelector('#add-check');
const addButtonDialog = <HTMLElement> window.document.querySelector('#add-check');
addButtonDialog.click();
});
});