enable prefer-const rule for tslint, fix issues (#4409)

* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class

lib/process-services/task-list/services/process-upload.service.ts

@@ -29,11 +29,11 @@ export class ProcessUploadService extends UploadService {
     }
 
     getUploadPromise(file: any): any {
-        let opts = {
+        const opts = {
             isRelatedContent: true
         };
-        let processInstanceId = file.options.parentId;
-        let promise = this.apiService.getInstance().activiti.contentApi.createRelatedContentOnProcessInstance(processInstanceId, file.file, opts);
+        const processInstanceId = file.options.parentId;
+        const promise = this.apiService.getInstance().activiti.contentApi.createRelatedContentOnProcessInstance(processInstanceId, file.file, opts);
 
         promise.catch((err) => this.handleError(err));
 

lib/process-services/task-list/services/task-filter.service.spec.ts

@@ -100,7 +100,7 @@ describe('Activiti Task filter Service', () => {
         it('should call the api with the appId', (done) => {
             spyOn(service, 'callApiTaskFilters').and.returnValue((fakeAppPromise));
 
-            let appId = 1;
+            const appId = 1;
             service.getTaskListFilters(appId).subscribe((res) => {
                 expect(service.callApiTaskFilters).toHaveBeenCalledWith(appId);
                 done();
@@ -108,7 +108,7 @@ describe('Activiti Task filter Service', () => {
         });
 
         it('should return the app filter by id', (done) => {
-            let appId = 1;
+            const appId = 1;
             service.getTaskListFilters(appId).subscribe((res) => {
                 expect(res).toBeDefined();
                 expect(res.length).toEqual(1);
@@ -172,7 +172,7 @@ describe('Activiti Task filter Service', () => {
         });
 
         it('should add a filter', (done) => {
-            let filterFake = new FilterRepresentationModel({
+            const filterFake = new FilterRepresentationModel({
                 name: 'FakeNameFilter',
                 assignment: 'fake-assignment'
             });

lib/process-services/task-list/services/task-filter.service.ts

@@ -36,17 +36,17 @@ export class TaskFilterService {
      * @returns Array of default filters just created
      */
     public createDefaultFilters(appId: number): Observable<FilterRepresentationModel[]> {
-        let involvedTasksFilter = this.getInvolvedTasksFilterInstance(appId);
-        let involvedObservable = this.addFilter(involvedTasksFilter);
+        const involvedTasksFilter = this.getInvolvedTasksFilterInstance(appId);
+        const involvedObservable = this.addFilter(involvedTasksFilter);
 
-        let myTasksFilter = this.getMyTasksFilterInstance(appId);
-        let myTaskObservable = this.addFilter(myTasksFilter);
+        const myTasksFilter = this.getMyTasksFilterInstance(appId);
+        const myTaskObservable = this.addFilter(myTasksFilter);
 
-        let queuedTasksFilter = this.getQueuedTasksFilterInstance(appId);
-        let queuedObservable = this.addFilter(queuedTasksFilter);
+        const queuedTasksFilter = this.getQueuedTasksFilterInstance(appId);
+        const queuedObservable = this.addFilter(queuedTasksFilter);
 
-        let completedTasksFilter = this.getCompletedTasksFilterInstance(appId);
-        let completeObservable = this.addFilter(completedTasksFilter);
+        const completedTasksFilter = this.getCompletedTasksFilterInstance(appId);
+        const completeObservable = this.addFilter(completedTasksFilter);
 
         return new Observable((observer) => {
             forkJoin(
@@ -56,7 +56,7 @@ export class TaskFilterService {
                 completeObservable
             ).subscribe(
                 (res) => {
-                    let filters: FilterRepresentationModel[] = [];
+                    const filters: FilterRepresentationModel[] = [];
                     res.forEach((filter) => {
                         if (filter.name === involvedTasksFilter.name) {
                             involvedTasksFilter.id = filter.id;

lib/process-services/task-list/services/task-upload.service.ts

@@ -29,11 +29,11 @@ export class TaskUploadService extends UploadService {
     }
 
     getUploadPromise(file: any): any {
-        let opts = {
+        const opts = {
             isRelatedContent: true
         };
-        let taskId = file.options.parentId;
-        let promise = this.apiService.getInstance().activiti.contentApi.createRelatedContentOnTask(taskId, file.file, opts);
+        const taskId = file.options.parentId;
+        const promise = this.apiService.getInstance().activiti.contentApi.createRelatedContentOnTask(taskId, file.file, opts);
 
         promise.catch((err) => this.handleError(err));
 

lib/process-services/task-list/services/tasklist.service.spec.ts

@@ -255,7 +255,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should add a task ', (done) => {
-            let taskFake = new TaskDetailsModel({
+            const taskFake = new TaskDetailsModel({
                 id: 123,
                 parentTaskId: 456,
                 name: 'FakeNameTask',
@@ -324,7 +324,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should create a new standalone task ', (done) => {
-            let taskFake = new TaskDetailsModel({
+            const taskFake = new TaskDetailsModel({
                 name: 'FakeNameTask',
                 description: 'FakeDescription',
                 category: '3'
@@ -355,7 +355,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should assign task to a user', (done) => {
-            let testTaskId = '8888';
+            const testTaskId = '8888';
             service.assignTask(testTaskId, fakeUser2).subscribe((res: TaskDetailsModel) => {
                 expect(res).toBeDefined();
                 expect(res.id).toEqual(testTaskId);
@@ -389,7 +389,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should assign task to a userId', (done) => {
-            let testTaskId = '8888';
+            const testTaskId = '8888';
             service.assignTaskByUserId(testTaskId, fakeUser2.id.toString()).subscribe((res: TaskDetailsModel) => {
                 expect(res).toBeDefined();
                 expect(res.id).toEqual(testTaskId);
@@ -421,7 +421,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should claim a task', (done) => {
-            let taskId = '111';
+            const taskId = '111';
 
             service.claimTask(taskId).subscribe(() => {
                 done();
@@ -435,7 +435,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should unclaim a task', (done) => {
-            let taskId = '111';
+            const taskId = '111';
 
             service.unclaimTask(taskId).subscribe(() => {
                 done();
@@ -449,7 +449,7 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should update a task', (done) => {
-            let taskId = '111';
+            const taskId = '111';
 
             service.updateTask(taskId, { property: 'value' }).subscribe(() => {
                 done();
@@ -463,8 +463,8 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should return the filter if it contains task id', (done) => {
-            let taskId = '1';
-            let filterFake = new FilterRepresentationModel({
+            const taskId = '1';
+            const filterFake = new FilterRepresentationModel({
                 name: 'FakeNameFilter',
                 assignment: 'fake-assignment',
                 filter: {
@@ -489,9 +489,9 @@ describe('Activiti TaskList Service', () => {
         });
 
         it('should return the filters if it contains task id', (done) => {
-            let taskId = '1';
+            const taskId = '1';
 
-            let fakeFilterList: FilterRepresentationModel[] = [];
+            const fakeFilterList: FilterRepresentationModel[] = [];
             fakeFilterList.push(fakeRepresentationFilter1, fakeRepresentationFilter2);
             let resultFilter: FilterRepresentationModel = null;
             service.getFilterForTaskById(taskId, fakeFilterList).subscribe((res: FilterRepresentationModel) => {

lib/process-services/task-list/services/tasklist.service.ts

@@ -57,7 +57,7 @@ export class TaskListService {
      * @returns The search query
      */
     private generateTaskRequestNodeFromFilter(filterModel: FilterRepresentationModel): TaskQueryRequestRepresentationModel {
-        let requestNode = {
+        const requestNode = {
             appDefinitionId: filterModel.appId,
             assignment: filterModel.filter.assignment,
             state: filterModel.filter.state,
@@ -73,7 +73,7 @@ export class TaskListService {
      * @returns The filter if it is related or null otherwise
      */
     isTaskRelatedToFilter(taskId: string, filterModel: FilterRepresentationModel): Observable<FilterRepresentationModel> {
-        let requestNodeForFilter = this.generateTaskRequestNodeFromFilter(filterModel);
+        const requestNodeForFilter = this.generateTaskRequestNodeFromFilter(filterModel);
         return from(this.callApiTasksFiltered(requestNodeForFilter))
             .pipe(
                 map((res: any) => {
@@ -185,7 +185,7 @@ export class TaskListService {
      * @returns Array of form details
      */
     getFormList(): Observable<Form[]> {
-        let opts = {
+        const opts = {
             'filter': 'myReusableForms', // String | filter
             'sort': 'modifiedDesc', // String | sort
             'modelType': 2 // Integer | modelType
@@ -194,7 +194,7 @@ export class TaskListService {
         return from(this.apiService.getInstance().activiti.modelsApi.getModels(opts))
             .pipe(
                 map((response: any) => {
-                    let forms: Form[] = [];
+                    const forms: Form[] = [];
                     response.data.forEach((form) => {
                         forms.push(new Form(form.id, form.name));
                     });
@@ -306,7 +306,7 @@ export class TaskListService {
      * @returns Details of the assigned task
      */
     assignTask(taskId: string, requestNode: any): Observable<TaskDetailsModel> {
-        let assignee = { assignee: requestNode.id };
+        const assignee = { assignee: requestNode.id };
         return from(this.callApiAssignTask(taskId, assignee))
             .pipe(
                 map((response: TaskDetailsModel) => {