[ADF-2149] Update ng-packagr to 2.0.0 (#2935)

* ng-packagr version 2.0.0 core fixes

* fix content services jsdoc

* fix process service jsdoc

* last update new build 2.0.0

* fix comment jsdoc

lib/core/form/components/form.component.ts

@@ -253,7 +253,6 @@ export class FormComponent implements OnInit, OnChanges {
     /**
      * Invoked when user clicks outcome button.
      * @param outcome Form outcome model
-     * @returns {boolean} True if outcome action was executed, otherwise false.
      */
     onOutcomeClicked(outcome: FormOutcomeModel): boolean {
         if (!this.readOnly && outcome && this.form) {
@@ -448,7 +447,6 @@ export class FormComponent implements OnInit, OnChanges {
     /**
      * Get custom set of outcomes for a Form Definition.
      * @param form Form definition model.
-     * @returns {FormOutcomeModel[]} Outcomes for a given form definition.
      */
     getFormDefinitionOutcomes(form: FormModel): FormOutcomeModel[] {
         return [

lib/core/form/components/start-form.component.ts

@@ -38,7 +38,6 @@ import { FormOutcomeModel } from './widgets/core/index';
  *  {formSaved} EventEmitter - This event is fired when the form is saved, it pass all the value in the form.
  *  {formCompleted} EventEmitter - This event is fired when the form is completed, it pass all the value in the form.
  *
- * @returns {FormComponent} .
  */
 @Component({
     selector: 'adf-start-form',

lib/core/form/components/widgets/core/form.model.ts

@@ -173,7 +173,6 @@ export class FormModel {
     /**
      * Validates entire form and all form fields.
      *
-     * @returns {void}
      * @memberof FormModel
      */
     validateForm(): void {
@@ -203,8 +202,7 @@ export class FormModel {
     /**
      * Validates a specific form field, triggers form validation.
      *
-     * @param {FormFieldModel} field Form field to validate.
-     * @returns {void}
+     * @param field Form field to validate.
      * @memberof FormModel
      */
     validateField(field: FormFieldModel): void {

lib/core/form/services/activiti-alfresco.service.ts

@@ -39,7 +39,6 @@ export class ActivitiContentService {
      *
      * @param accountId
      * @param folderId
-     * @returns {null}
      */
     getAlfrescoNodes(accountId: string, folderId: string): Observable<[ExternalContent]> {
         let apiService: AlfrescoApi = this.apiService.getInstance();
@@ -54,7 +53,6 @@ export class ActivitiContentService {
      *
      * @param accountId
      * @param folderId
-     * @returns {any}
      */
     getAlfrescoRepositories(tenantId: number, includeAccount: boolean): Observable<any> {
         let apiService: AlfrescoApi = this.apiService.getInstance();
@@ -73,7 +71,6 @@ export class ActivitiContentService {
      * @param accountId
      * @param node
      * @param siteId
-     * @returns {null}
      */
     linkAlfrescoNode(accountId: string, node: ExternalContent, siteId: string): Observable<ExternalContentLink> {
         let apiService: AlfrescoApi = this.apiService.getInstance();

lib/core/form/services/form.service.ts

@@ -109,7 +109,6 @@ export class FormService {
 
     /**
      * Create a Form with a fields for each metadata properties
-     * @returns {Observable<any>}
      */
     createFormFromANode(formName: string): Observable<any> {
         return Observable.create(observer => {
@@ -131,7 +130,6 @@ export class FormService {
 
     /**
      * Create a Form
-     * @returns {Observable<any>}
      */
     createForm(formName: string): Observable<any> {
         let dataModel = {
@@ -155,7 +153,6 @@ export class FormService {
     /**
      * @deprecated in 1.7.0, use saveForm API instead
      * Add Fileds to A form
-     * @returns {Observable<any>}
      */
     addFieldsToAForm(formId: string, formModel: FormDefinitionModel): Observable<any> {
         this.logService.log('addFieldsToAForm is deprecated in 1.7.0, use saveForm API instead');
@@ -166,7 +163,6 @@ export class FormService {
 
     /**
      * Search For A Form by name
-     * @returns {Observable<any>}
      */
     searchFrom(name: string): Observable<any> {
         let opts = {
@@ -184,7 +180,6 @@ export class FormService {
 
     /**
      * Get All the forms
-     * @returns {Observable<any>}
      */
     getForms(): Observable<any> {
         let opts = {
@@ -198,7 +193,6 @@ export class FormService {
 
     /**
      * Get Process Definitions
-     * @returns {Observable<any>}
      */
     getProcessDefinitions(): Observable<any> {
         return Observable.fromPromise(this.processApi.getProcessDefinitions({}))
@@ -214,7 +208,6 @@ export class FormService {
 
     /**
      * Get All the Tasks
-     * @returns {Observable<any>}
      */
     getTasks(): Observable<any> {
         return Observable.fromPromise(this.taskApi.listTasks({}))
@@ -225,7 +218,6 @@ export class FormService {
     /**
      * Get Task
      * @param taskId Task Id
-     * @returns {Observable<any>}
      */
     getTask(taskId: string): Observable<any> {
         return Observable.fromPromise(this.taskApi.getTask(taskId))
@@ -237,7 +229,6 @@ export class FormService {
      * Save Task Form
      * @param taskId Task Id
      * @param formValues Form Values
-     * @returns {Observable<any>}
      */
     saveTaskForm(taskId: string, formValues: FormValues): Observable<any> {
         let body = JSON.stringify({values: formValues});
@@ -251,7 +242,6 @@ export class FormService {
      * @param taskId Task Id
      * @param formValues Form Values
      * @param outcome Form Outcome
-     * @returns {Observable<any>}
      */
     completeTaskForm(taskId: string, formValues: FormValues, outcome?: string): Observable<any> {
         let data: any = {values: formValues};
@@ -267,7 +257,6 @@ export class FormService {
     /**
      * Get Form related to a taskId
      * @param taskId Task Id
-     * @returns {Observable<any>}
      */
     getTaskForm(taskId: string): Observable<any> {
         return Observable.fromPromise(this.taskApi.getTaskForm(taskId))
@@ -278,7 +267,6 @@ export class FormService {
     /**
      * Get Form Definition
      * @param formId Form Id
-     * @returns {Observable<any>}
      */
     getFormDefinitionById(formId: string): Observable<any> {
         return Observable.fromPromise(this.editorApi.getForm(formId))
@@ -289,7 +277,6 @@ export class FormService {
     /**
      * Returns form definition by a given name.
      * @param name
-     * @returns {Promise<T>|Promise<ErrorObservable>}
      */
     getFormDefinitionByName(name: string): Observable<any> {
         let opts = {
@@ -306,7 +293,6 @@ export class FormService {
     /**
      * Get start form instance for a given processId
      * @param processId Process definition ID
-     * @returns {Observable<any>}
      */
     getStartFormInstance(processId: string): Observable<any> {
         return Observable.fromPromise(
@@ -324,7 +310,6 @@ export class FormService {
     /**
      * Get start form definition for a given process
      * @param processId Process definition ID
-     * @returns {Observable<any>}
      */
     getStartFormDefinition(processId: string): Observable<any> {
         return Observable.fromPromise(

lib/core/form/services/node.service.ts

@@ -29,7 +29,6 @@ export class NodeService {
     /**
      * Get All the metadata and the nodeType for a nodeId cleaned by the prefix
      * @param nodeId Node Id
-     * @returns NodeMetadata
      */
     public getNodeMetadata(nodeId: string): Observable<NodeMetadata> {
         return Observable.fromPromise(this.apiService.getInstance().nodes.getNodeInfo(nodeId)).map(this.cleanMetadataFromSemicolon);
@@ -41,7 +40,6 @@ export class NodeService {
      * @param nodeType node type
      * @param nameSpace namespace node
      * @param data data to store
-     * @returns NodeMetadata
      */
     public createNodeMetadata(nodeType: string, nameSpace: any, data: any, path: string, name?: string): Observable<any> {
         let properties = {};
@@ -60,7 +58,6 @@ export class NodeService {
      * @param nodeType node type
      * @param properties namespace node
      * @param path path
-     * @returns NodeMetadata
      */
     public createNode(name: string, nodeType: string, properties: any, path: string): Observable<any> {
         let body = {