ACS-8221: remove internal localized role pipe (#10143)

* remove internal localized role pipe

* remove internal localized role pipe [ci:force]

* performance improvements
This commit is contained in:
Denys Vuika
2024-09-04 11:59:34 -04:00
committed by GitHub
parent a238442d93
commit a86b23f8a1
6 changed files with 97 additions and 101 deletions

View File

@@ -1,50 +0,0 @@
/*!
* @license
* Copyright © 2005-2024 Hyland Software, Inc. and its affiliates. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { LocalizedRolePipe } from './localized-role.pipe';
describe('LocalizedRolePipe', () => {
let translationService: any;
let pipe: LocalizedRolePipe;
beforeEach(() => {
translationService = jasmine.createSpyObj('TranslationService', ['instant']);
pipe = new LocalizedRolePipe(translationService);
});
it('should return null', () => {
expect(pipe.transform(null)).toBeNull();
});
it('should translate value', () => {
translationService.instant.and.returnValue('Consumer');
expect(pipe.transform('ADF.ROLES.CONSUMER')).toEqual('Consumer');
});
it('should return the key when translation not present', () => {
translationService.instant.and.callFake((value) => {
if (value === 'ADF.ROLES.CONSUMER') {
return 'Consumer';
} else {
return value;
}
});
expect(pipe.transform('Contributor')).toBe('ADF.ROLES.CONTRIBUTOR');
expect(pipe.transform('Consumer')).toEqual('Consumer');
});
});

View File

@@ -1,39 +0,0 @@
/*!
* @license
* Copyright © 2005-2024 Hyland Software, Inc. and its affiliates. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Pipe, PipeTransform } from '@angular/core';
import { TranslationService } from '../translation/translation.service';
@Pipe({
name: 'adfLocalizedRole',
standalone: true
})
export class LocalizedRolePipe implements PipeTransform {
constructor(private translationService: TranslationService) {}
transform(value: string): any {
if (value) {
const key = `ADF.ROLES.${value.toUpperCase()}`;
const translation = this.translationService.instant(key);
if (translation) {
return translation;
}
}
return value;
}
}

View File

@@ -28,7 +28,6 @@ import { FileTypePipe } from './file-type.pipe';
import { MultiValuePipe } from './multi-value.pipe';
import { LocalizedDatePipe } from './localized-date.pipe';
import { DecimalNumberPipe } from './decimal-number.pipe';
import { LocalizedRolePipe } from './localized-role.pipe';
import { MomentDatePipe } from './moment-date.pipe';
import { MomentDateTimePipe } from './moment-datetime.pipe';
import { FilterStringPipe } from './filter-string.pipe';
@@ -45,7 +44,6 @@ export const CORE_PIPES = [
FileTypePipe,
MultiValuePipe,
DecimalNumberPipe,
LocalizedRolePipe,
MomentDatePipe,
MomentDateTimePipe,
DateTimePipe,

View File

@@ -26,7 +26,6 @@ export * from './multi-value.pipe';
export * from './text-highlight.pipe';
export * from './time-ago.pipe';
export * from './user-initial.pipe';
export * from './localized-role.pipe';
export * from './pipe.module';
export * from './moment-date.pipe';
export * from './moment-datetime.pipe';