From afbf87788fc1142cbb517912412eefd6d794cc69 Mon Sep 17 00:00:00 2001 From: MichalKinas <113341662+MichalKinas@users.noreply.github.com> Date: Wed, 14 Jun 2023 13:37:43 +0200 Subject: [PATCH] [ACS-5347] New styles for facets and filters states (#8661) * [ACS-5347] New styles for facets and filters states * [ACS-5347] Move ACA specific colors to ACA * [ACS-5347] CR fixes --- .../search-facet-chip.component.html | 6 ++-- .../search-facet-chip.component.spec.ts | 8 +++++ .../search-facet-chip.component.ts | 3 ++ .../search-filter-chips.component.scss | 2 +- .../search-widget-chip.component.html | 6 ++-- .../search-widget-chip.component.spec.ts | 36 ++++++++++++------- .../search-widget-chip.component.ts | 3 ++ .../search-logical-filter.component.html | 9 ----- .../search-logical-filter.component.spec.ts | 19 ++++------ 9 files changed, 51 insertions(+), 41 deletions(-) diff --git a/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html b/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html index db105c9b96..67d13580c5 100644 --- a/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html +++ b/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html @@ -19,7 +19,7 @@   {{ displayValue | translate }}  {{ 'SEARCH.FILTER.ANY' | translate }} - keyboard_arrow_down + {{ chipIcon }} remove @@ -38,8 +38,8 @@ - - - diff --git a/lib/content-services/src/lib/search/components/search-logical-filter/search-logical-filter.component.spec.ts b/lib/content-services/src/lib/search/components/search-logical-filter/search-logical-filter.component.spec.ts index de39a7309d..dc08d69c5a 100644 --- a/lib/content-services/src/lib/search/components/search-logical-filter/search-logical-filter.component.spec.ts +++ b/lib/content-services/src/lib/search/components/search-logical-filter/search-logical-filter.component.spec.ts @@ -64,12 +64,6 @@ describe('SearchLogicalFilterComponent', () => { fixture.detectChanges(); } - function clickApplyBtn() { - const applyBtn: HTMLButtonElement = fixture.debugElement.query(By.css('[data-automation-id="logical-filter-btn-apply"]')).nativeElement; - applyBtn.click(); - fixture.detectChanges(); - } - it('should update display value on init', () => { spyOn(component.displayValue$, 'next'); component.ngOnInit(); @@ -122,14 +116,13 @@ describe('SearchLogicalFilterComponent', () => { expect(component.displayValue$.next).toHaveBeenCalled(); }); - it('should reset value and display value when reset button is clicked', () => { + it('should reset value and display value when reset is called', () => { const searchCondition: LogicalSearchCondition = { matchAll: ['test1'], matchAny: ['test2'], exclude: ['test3'] }; component.setValue(searchCondition); fixture.detectChanges(); spyOn(component.context, 'update'); spyOn(component.displayValue$, 'next'); - const resetBtn: HTMLButtonElement = fixture.debugElement.query(By.css('[data-automation-id="logical-filter-btn-clear"]')).nativeElement; - resetBtn.click(); + component.reset(); expect(component.context.queryFragments[component.id]).toBe(''); expect(component.context.update).toHaveBeenCalled(); expect(component.getCurrentValue()).toEqual({ matchAll: [], matchAny: [], exclude: [] }); @@ -140,7 +133,7 @@ describe('SearchLogicalFilterComponent', () => { spyOn(component.context, 'update'); enterNewPhrase('test1', 0); enterNewPhrase('test2', 0); - clickApplyBtn(); + component.submitValues(); expect(component.context.update).toHaveBeenCalled(); expect(component.context.queryFragments[component.id]).toBe('((field1:"test1" AND field1:"test2") OR (field2:"test1" AND field2:"test2"))'); }); @@ -149,7 +142,7 @@ describe('SearchLogicalFilterComponent', () => { spyOn(component.context, 'update'); enterNewPhrase('test3', 1); enterNewPhrase('test4', 1); - clickApplyBtn(); + component.submitValues(); expect(component.context.update).toHaveBeenCalled(); expect(component.context.queryFragments[component.id]).toBe('((field1:"test3" OR field1:"test4") OR (field2:"test3" OR field2:"test4"))'); }); @@ -158,7 +151,7 @@ describe('SearchLogicalFilterComponent', () => { spyOn(component.context, 'update'); enterNewPhrase('test5', 2); enterNewPhrase('test6', 2); - clickApplyBtn(); + component.submitValues(); expect(component.context.update).toHaveBeenCalled(); expect(component.context.queryFragments[component.id]).toBe('((NOT field1:"test5" AND NOT field1:"test6") AND (NOT field2:"test5" AND NOT field2:"test6"))'); }); @@ -168,7 +161,7 @@ describe('SearchLogicalFilterComponent', () => { enterNewPhrase('test1', 0); enterNewPhrase('test2', 1); enterNewPhrase('test3', 2); - clickApplyBtn(); + component.submitValues(); const subQuery1 = '((field1:"test1") OR (field2:"test1"))'; const subQuery2 = '((field1:"test2") OR (field2:"test2"))'; const subQuery3 = '((NOT field1:"test3") AND (NOT field2:"test3"))';