[ADF-3848]Implement edit task filters tests (#4110)

* Add test for 'all the filters properly set up accordingly with the Query Param' acceptance criteria.

* Implement edit task filters tests.

* Fix lint errors

* Fix existent tests

* fix lint error

* Changed 'status' to 'state'

e2e/pages/adf/dataTablePage.ts

@@ -251,6 +251,10 @@ export class DataTablePage {
         return this;
     }
 
+    checkSpinnerIsNotDisplayed() {
+        Util.waitUntilElementIsNotOnPage(this.spinner);
+    }
+
     checkRowIsDisplayedByName(filename) {
         Util.waitUntilElementIsVisible(element.all(by.css(`div[filename="${filename}"]`)).first());
     }

e2e/pages/adf/demo-shell/process-services/tasksCloudDemoPage.ts

@@ -56,7 +56,7 @@ export class TasksCloudDemoPage {
     }
 
     customTaskFilter(filterName) {
-        return new TaskFiltersCloudComponent(element(by.css(`span[data-automation-id="${filterName}_filter"]`)));
+        return new TaskFiltersCloudComponent(element(by.css(`span[data-automation-id="${filterName}-filter"]`)));
     }
 
     getActiveFilterName() {

e2e/pages/adf/dialog/editTaskFilterDialog.ts

@@ -0,0 +1,82 @@
+/*!
+ * @license
+ * Copyright 2016 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { by, element } from 'protractor';
+import { Util } from '../../../util/util';
+
+export class EditTaskFilterDialog {
+
+    componentElement = element(by.css('adf-cloud-task-filter-dialog'));
+    title = element(by.id('adf-task-filter-dialog-title'));
+    filterNameInput = element(by.id('adf-filter-name-id'));
+    saveButtonLocator = by.id('adf-save-button-id');
+    cancelButtonLocator = by.id('adf-cancel-button-id');
+
+    clickOnSaveButton() {
+        let saveButton = this.componentElement.element(this.saveButtonLocator);
+        Util.waitUntilElementIsVisible(saveButton);
+        saveButton.click();
+        Util.waitUntilElementIsNotVisible(this.componentElement);
+        return this;
+    }
+
+    checkSaveButtonIsEnabled() {
+        Util.waitUntilElementIsVisible(this.componentElement.element(this.saveButtonLocator));
+        return this.componentElement.element(this.saveButtonLocator).isEnabled();
+    }
+
+    clickOnCancelButton() {
+        let cancelButton = this.componentElement.element(this.cancelButtonLocator);
+        Util.waitUntilElementIsVisible(cancelButton);
+        cancelButton.click();
+        Util.waitUntilElementIsNotVisible(this.componentElement);
+        return this;
+    }
+
+    checkCancelButtonIsEnabled() {
+        Util.waitUntilElementIsVisible(this.componentElement.element(this.cancelButtonLocator));
+        return this.componentElement.element(this.cancelButtonLocator).isEnabled();
+    }
+
+    getFilterName() {
+        Util.waitUntilElementIsVisible(this.filterNameInput);
+        return this.filterNameInput.getAttribute('value');
+    }
+
+    setFilterName(filterName) {
+        this.clearFilterName();
+        this.filterNameInput.sendKeys(filterName);
+        return this;
+    }
+
+    clearFilterName() {
+        Util.waitUntilElementIsVisible(this.filterNameInput);
+        this.filterNameInput.click();
+        this.filterNameInput.getAttribute('value').then((value) => {
+            for (let i = value.length; i >= 0; i--) {
+                this.filterNameInput.sendKeys(protractor.Key.BACK_SPACE);
+            }
+        });
+        return this;
+    }
+
+    getTitle() {
+        Util.waitUntilElementIsVisible(this.title);
+        return this.title.getText();
+    }
+
+}

e2e/pages/adf/process-cloud/editTaskFilterCloudComponent.ts

@@ -17,15 +17,22 @@
 
 import { Util } from '../../../util/util';
 import { by, element, protractor } from 'protractor';
+import { EditTaskFilterDialog } from '../dialog/editTaskFilterDialog';
 
 export class EditTaskFilterCloudComponent {
 
     customiseFilter = element(by.id('adf-edit-task-filter-title-id'));
     selectedOption = element(by.css('mat-option[class*="mat-selected"]'));
     assignment = element(by.css('input[data-automation-id="adf-cloud-edit-task-property-assignment"]'));
-    statusBy = by.css('mat-select[data-automation-id="adf-cloud-edit-task-property-state"]');
-    sortBy = by.css('mat-select[data-automation-id="adf-cloud-edit-task-property-sort"]');
-    orderBy = by.css('mat-select[data-automation-id="adf-cloud-edit-task-property-order"]');
+    saveButton = element(by.css('button[id="adf-save-id"]'));
+    saveAsButton = element(by.css('button[id="adf-save-as-id"]'));
+    deleteButton = element(by.css('button[id="adf-delete-id"]'));
+
+    editTaskFilter = new EditTaskFilterDialog();
+
+    editTaskFilterDialog() {
+        return this.editTaskFilter;
+    }
 
     clickCustomiseFilterHeader() {
         Util.waitUntilElementIsVisible(this.customiseFilter);
@@ -34,7 +41,7 @@ export class EditTaskFilterCloudComponent {
     }
 
     setStateFilterDropDown(option) {
-        this.clickOnDropDownArrow(this.statusBy);
+        this.clickOnDropDownArrow('state');
 
         let stateElement = element.all(by.cssContainingText('mat-option span', option)).first();
         Util.waitUntilElementIsClickable(stateElement);
@@ -43,8 +50,12 @@ export class EditTaskFilterCloudComponent {
         return this;
     }
 
+    getStateFilterDropDownValue() {
+        return element(by.css("mat-select[data-automation-id='adf-cloud-edit-task-property-state'] span")).getText();
+    }
+
     setSortFilterDropDown(option) {
-        this.clickOnDropDownArrow(this.sortBy);
+        this.clickOnDropDownArrow('sort');
 
         let sortElement = element.all(by.cssContainingText('mat-option span', option)).first();
         Util.waitUntilElementIsClickable(sortElement);
@@ -53,8 +64,14 @@ export class EditTaskFilterCloudComponent {
         return this;
     }
 
+    getSortFilterDropDownValue() {
+        let elementSort = element(by.css("mat-select[data-automation-id='adf-cloud-edit-task-property-sort'] span"));
+        Util.waitUntilElementIsVisible(elementSort);
+        return elementSort.getText();
+    }
+
     setOrderFilterDropDown(option) {
-        this.clickOnDropDownArrow(this.orderBy);
+        this.clickOnDropDownArrow('order');
 
         let orderElement = element.all(by.cssContainingText('mat-option span', option)).first();
         Util.waitUntilElementIsClickable(orderElement);
@@ -63,8 +80,12 @@ export class EditTaskFilterCloudComponent {
         return this;
     }
 
+    getOrderFilterDropDownValue() {
+        return element(by.css("mat-select[data-automation-id='adf-cloud-edit-task-property-order'] span")).getText();
+    }
+
     clickOnDropDownArrow(option) {
-        let dropDownArrow = element(option);
+        let dropDownArrow = element(by.css("mat-form-field[data-automation-id='" + option + "'] div[class*='arrow']"));
         Util.waitUntilElementIsVisible(dropDownArrow);
         dropDownArrow.click();
         Util.waitUntilElementIsVisible(this.selectedOption);
@@ -78,4 +99,57 @@ export class EditTaskFilterCloudComponent {
         return this;
     }
 
+    getAssignment() {
+        return this.assignment.getText();
+    }
+
+    checkSaveButtonIsDisplayed() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        return this;
+    }
+
+    checkSaveAsButtonIsDisplayed() {
+        Util.waitUntilElementIsVisible(this.saveAsButton);
+        return this;
+    }
+
+    checkDeleteButtonIsDisplayed() {
+        Util.waitUntilElementIsVisible(this.deleteButton);
+        return this;
+    }
+
+    checkSaveButtonIsEnabled() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        return this.saveButton.isEnabled();
+    }
+
+    checkSaveAsButtonIsEnabled() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        return this.saveAsButton.isEnabled();
+    }
+
+    checkDeleteButtonIsEnabled() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        return this.deleteButton.isEnabled();
+    }
+
+    clickSaveAsButton() {
+        Util.waitUntilElementIsClickable(this.saveAsButton);
+        Util.waitUntilElementIsVisible(this.saveAsButton);
+        this.saveAsButton.click();
+        return this.editTaskFilter;
+    }
+
+    clickDeleteButton() {
+        Util.waitUntilElementIsVisible(this.deleteButton);
+        this.deleteButton.click();
+        return this;
+    }
+
+    clickSaveButton() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        this.saveButton.click();
+        return this;
+    }
+
 }

e2e/pages/adf/process_cloud/editTaskFilterCloudComponent.ts

@@ -0,0 +1,150 @@
+/*!
+ * @license
+ * Copyright 2016 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Util } from '../../../util/util';
+import { by, element, protractor } from 'protractor';
+import { EditTaskFilterDialog } from '../dialog/editTaskFilterDialog';
+
+export class EditTaskFilterCloudComponent {
+
+    customiseFilter = element(by.id('adf-edit-task-filter-title-id'));
+    selectedOption = element(by.css('mat-option[class*="mat-selected"]'));
+    assignment = element(by.css('mat-form-field[data-automation-id="assignment"] input'));
+    saveButton = element(by.css('button[data-automation-id="Save"]'));
+    saveAsButton = element(by.css('button[data-automation-id="Save as"]'));
+    deleteButton = element(by.css('button[data-automation-id="Delete"]'));
+
+    editTaskFilter = new EditTaskFilterDialog();
+
+    editTaskFilterDialog() {
+        return this.editTaskFilter;
+    }
+
+    clickCustomiseFilterHeader() {
+        Util.waitUntilElementIsVisible(this.customiseFilter);
+        this.customiseFilter.click();
+        return this;
+    }
+
+    setStateFilterDropDown(option) {
+        this.clickOnDropDownArrow('status');
+
+        let stateElement = element.all(by.cssContainingText('mat-option span', option)).first();
+        Util.waitUntilElementIsClickable(stateElement);
+        Util.waitUntilElementIsVisible(stateElement);
+        stateElement.click();
+        return this;
+    }
+
+    getStateFilterDropDownValue() {
+        return element(by.css("mat-form-field[data-automation-id='status'] span")).getText();
+    }
+
+    setSortFilterDropDown(option) {
+        this.clickOnDropDownArrow('sort');
+
+        let sortElement = element.all(by.cssContainingText('mat-option span', option)).first();
+        Util.waitUntilElementIsClickable(sortElement);
+        Util.waitUntilElementIsVisible(sortElement);
+        sortElement.click();
+        return this;
+    }
+
+    getSortFilterDropDownValue() {
+        return element(by.css("mat-form-field[data-automation-id='sort'] span")).getText();
+    }
+
+    setOrderFilterDropDown(option) {
+        this.clickOnDropDownArrow('order');
+
+        let orderElement = element.all(by.cssContainingText('mat-option span', option)).first();
+        Util.waitUntilElementIsClickable(orderElement);
+        Util.waitUntilElementIsVisible(orderElement);
+        orderElement.click();
+        return this;
+    }
+
+    getOrderFilterDropDownValue() {
+        return element(by.css("mat-form-field[data-automation-id='order'] span")).getText();
+    }
+
+    clickOnDropDownArrow(option) {
+        let dropDownArrow = element(by.css("mat-form-field[data-automation-id='" + option + "'] div[class*='arrow']"));
+        Util.waitUntilElementIsVisible(dropDownArrow);
+        dropDownArrow.click();
+        Util.waitUntilElementIsVisible(this.selectedOption);
+    }
+
+    setAssignment(option) {
+        Util.waitUntilElementIsVisible(this.assignment);
+        this.assignment.clear();
+        this.assignment.sendKeys(option);
+        this.assignment.sendKeys(protractor.Key.ENTER);
+        return this;
+    }
+
+    getAssignment() {
+        return this.assignment.getText();
+    }
+
+    checkSaveButtonIsDisplayed() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        return this;
+    }
+
+    checkSaveAsButtonIsDisplayed() {
+        Util.waitUntilElementIsVisible(this.saveAsButton);
+        return this;
+    }
+
+    checkDeleteButtonIsDisplayed() {
+        Util.waitUntilElementIsVisible(this.deleteButton);
+        return this;
+    }
+
+    checkSaveButtonIsEnabled() {
+        return this.saveButton.isEnabled();
+    }
+
+    checkSaveAsButtonIsEnabled() {
+        return this.saveAsButton.isEnabled();
+    }
+
+    checkDeleteButtonIsEnabled() {
+        return this.deleteButton.isEnabled();
+    }
+
+    clickSaveAsButton() {
+        Util.waitUntilElementIsClickable(this.saveAsButton);
+        Util.waitUntilElementIsVisible(this.saveAsButton);
+        this.saveAsButton.click();
+        return this.editTaskFilter;
+    }
+
+    clickDeleteButton() {
+        Util.waitUntilElementIsVisible(this.deleteButton);
+        this.deleteButton.click();
+        return this;
+    }
+
+    clickSaveButton() {
+        Util.waitUntilElementIsVisible(this.saveButton);
+        this.saveButton.click();
+        return this;
+    }
+
+}