inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-4232] Fix filePreviewPage methods to reach expectations (#4668)

Browse Source 
* [ADF-4232] Fix filePreviewPage methods to reach expectations

* [ADF-4232] Implement new methods

* Fix word spelling

* [ADF-4232] Fix e2e test and rebase

* Rebase branch

* [ADF-4232] add test for reset zoom check

- remove un-reached expects from filePreviewPage

* [ADF-4232] better naming - review changes

* [ADF-4232] no sleep(s), more timeout

* [ADF-4232] some code clean up

* [ADF-4232] some code clean up

* [ADF-4232] refactoring - renaming

* [ADF-4232] refactoring

* [ADF-4232] refactoring move expects to test - code review changes

* [ADF-4232] remove unused methods

- these already exist on viewerPage.ts

* [ADF-4232] remove duplicated code

- use viewerPage instead of filePreviewPage

* [ADF-4232] reset to original timeout in afterAll
This commit is contained in:
davidcanonieto
2019-06-03 14:24:53 +01:00
committed by Eugenio Romano
parent 7611268bd9
commit b19646d201
4 changed files with 41 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
e2e/search/search-component.e2e.ts
View File

@@ -20,7 +20,7 @@ import { browser } from 'protractor';
import { LoginPage } from '@alfresco/adf-testing';
import { SearchDialog } from '../pages/adf/dialog/searchDialog';
import { ContentServicesPage } from '../pages/adf/contentServicesPage';
import { FilePreviewPage } from '../pages/adf/filePreviewPage';
import { ViewerPage } from '../pages/adf/viewerPage';
import { SearchResultsPage } from '../pages/adf/searchResultsPage';
import { AcsUserModel } from '../models/ACS/acsUserModel';
@@ -51,7 +51,7 @@ describe('Search component - Search Bar', () => {
const searchDialog = new SearchDialog();
const searchResultPage = new SearchResultsPage();
const filePreviewPage = new FilePreviewPage();
const viewerPage = new ViewerPage();
const acsUser = new AcsUserModel();
const uploadActions = new UploadActions();
@@ -209,7 +209,7 @@ describe('Search component - Search Bar', () => {
expect(searchDialog.getSpecificRowsCompleteName(firstFileModel.name)).toEqual(firstFileModel.name);
});
it('[C260257] Should display content when clicking on folder from search suggestions', () => {
it('[C260257] Should display content when clicking on folder from search suggestions', async () => {
searchDialog
.clickOnSearchIcon()
.checkSearchBarIsVisible()
@@ -228,9 +228,9 @@ describe('Search component - Search Bar', () => {
.resultTableContainsRow(firstFileModel.name);
searchDialog.clickOnSpecificRow(firstFileModel.name);
expect(filePreviewPage.getPDFTitleFromSearch()).toEqual(firstFileModel.name);
expect(await viewerPage.getDisplayedFileName()).toEqual(firstFileModel.name);
filePreviewPage.closePreviewWithButton();
viewerPage.clickCloseButton();
});
it('[C272801] Should display message when searching for non-existent folder', () => {