inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5645] Implemented the changes as per the review comments

Browse Source
This commit is contained in:
Yasa-Nataliya
2023-10-13 16:22:28 +05:30
committed by Anukriti Singh
parent 9723f9f480
commit b1da556451
2 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html
+4 -4
View File
@@ -16,7 +16,7 @@
{{ 'CORE.METADATA.BASIC.HEADER' | translate }} {{ 'CORE.METADATA.BASIC.HEADER' | translate }}
</mat-panel-title> </mat-panel-title>
</div> </div>
<button *ngIf="canToggleEdit" <button *ngIf="hasToggleEdit"
mat-icon-button mat-icon-button
(click)="toggleEdit($event, group, buttonType.GeneralInfo)" (click)="toggleEdit($event, group, buttonType.GeneralInfo)"
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
@@ -70,7 +70,7 @@
</mat-panel-title> </mat-panel-title>
</div> </div>
<div class="adf-tags-buttons"> <div class="adf-tags-buttons">
<button *ngIf="canTagsToggleEdit" <button *ngIf="hasTagsToggleEdit"
mat-icon-button mat-icon-button
(click)="toggleEdit($event, group, buttonType.Tags)" (click)="toggleEdit($event, group, buttonType.Tags)"
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
@@ -132,7 +132,7 @@
</mat-panel-title> </mat-panel-title>
</div> </div>
<div class="adf-metadata-categories-title"> <div class="adf-metadata-categories-title">
<button *ngIf="canCategoriesToggleEdit" <button *ngIf="hasCategoriesToggleEdit"
mat-icon-button mat-icon-button
(click)="toggleEdit($event, group, buttonType.Categories)" (click)="toggleEdit($event, group, buttonType.Categories)"
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
@@ -200,7 +200,7 @@
{{ group.title | translate }} {{ group.title | translate }}
</mat-panel-title> </mat-panel-title>
</div> </div>
<button *ngIf="canGroupToggleEdit(group)" <button *ngIf="hasGroupToggleEdit(group)"
mat-icon-button mat-icon-button
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate" [attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate"
lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts
+11 -11
View File
@@ -562,12 +562,12 @@ describe('ContentMetadataComponent', () => {
}); });
}); });
describe('canToggleEdit', () => { describe('hasToggleEdit', () => {
it('should return true when editable is false, readOnly is false, and hasAllowableOperations is true', () => { it('should return true when editable is false, readOnly is false, and hasAllowableOperations is true', () => {
component.editable = false; component.editable = false;
component.readOnly = false; component.readOnly = false;
component.hasAllowableOperations = true; component.hasAllowableOperations = true;
const result = component.canToggleEdit; const result = component.hasToggleEdit;
expect(result).toBe(true); expect(result).toBe(true);
}); });
@@ -575,22 +575,22 @@ describe('ContentMetadataComponent', () => {
component.editable = true; component.editable = true;
component.readOnly = false; component.readOnly = false;
component.hasAllowableOperations = true; component.hasAllowableOperations = true;
const result = component.canToggleEdit; const result = component.hasToggleEdit;
expect(result).toBe(false); expect(result).toBe(false);
}); });
}); });
describe('canTagsToggleEdit', () => { describe('hasTagsToggleEdit', () => {
it('should have canTagsToggleEdit property as expected', () => { it('should have hasTagsToggleEdit property as expected', () => {
component.editableTags = false; component.editableTags = false;
component.readOnly = false; component.readOnly = false;
component.hasAllowableOperations = true; component.hasAllowableOperations = true;
fixture.detectChanges(); fixture.detectChanges();
expect(component.canTagsToggleEdit).toBe(true); expect(component.hasTagsToggleEdit).toBe(true);
}); });
}); });
describe('canGroupToggleEdit', () => { describe('hasGroupToggleEdit', () => {
it('should return true when group is not editable, not read-only, and has allowable operations', () => { it('should return true when group is not editable, not read-only, and has allowable operations', () => {
component.readOnly = false; component.readOnly = false;
component.hasAllowableOperations = true; component.hasAllowableOperations = true;
@@ -600,17 +600,17 @@ describe('ContentMetadataComponent', () => {
expanded: true, expanded: true,
editable: false editable: false
}; };
const result = component.canGroupToggleEdit(group); const result = component.hasGroupToggleEdit(group);
expect(result).toBe(true); expect(result).toBe(true);
}); });
}); });
describe('canCategoriesToggleEdit', () => { describe('hasCategoriesToggleEdit', () => {
it('should have canCategoriesToggleEdit property as expected', () => { it('should have hasCategoriesToggleEdit property as expected', () => {
component.editableCategories = false; component.editableCategories = false;
component.readOnly = false; component.readOnly = false;
component.hasAllowableOperations = true; component.hasAllowableOperations = true;
expect(component.canCategoriesToggleEdit).toBe(true); expect(component.hasCategoriesToggleEdit).toBe(true);
}); });
}); });