inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ban xit and xdescribe use in the future (#4923)

Browse Source 
* remove xit test and ban xit and xdescribe use in the future

* remove xit test and ban xit and xdescribe use in the future

* remove test excluded

* remove consecutive blank line
This commit is contained in:
Eugenio Romano
2019-07-12 15:04:53 +01:00
committed by GitHub
parent 07213fac3a
commit b28a53afe7
28 changed files with 7 additions and 893 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/content-services/document-list/document-list-component.e2e.ts
-10
View File
@@ -236,16 +236,6 @@ describe('Document List Component', () => {
});
});
xit('[C260121] Should show the spinner on content loading', async (done) => {
acsUser = new AcsUserModel();
await this.alfrescoJsApi.login(browser.params.testConfig.adf.adminEmail, browser.params.testConfig.adf.adminPassword);
await this.alfrescoJsApi.core.peopleApi.addPerson(acsUser);
loginPage.loginToContentServicesUsingUserModel(acsUser);
contentServicesPage.clickOnContentServices();
contentServicesPage.checkSpinnerIsShowed();
done();
});
it('[C279959] Should display empty folder state for new folders', async (done) => {
acsUser = new AcsUserModel();
e2e/content-services/upload/excluded-file.e2e.ts
-18
View File
@@ -24,7 +24,6 @@ import { UploadToggles } from '../../pages/adf/dialog/uploadToggles';
import { AcsUserModel } from '../../models/ACS/acsUserModel';
import { FileModel } from '../../models/ACS/fileModel';
import { FolderModel } from '../../models/ACS/folderModel';
import resources = require('../../util/resources');
@@ -44,11 +43,6 @@ describe('Upload component - Excluded Files', () => {
'location': resources.Files.ADF_DOCUMENTS.INI.file_location
});
const folderWithExcludedFile = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.FOLDER_EXCLUDED.folder_name,
'location': resources.Files.ADF_DOCUMENTS.FOLDER_EXCLUDED.folder_location
});
const txtFileModel = new FileModel({
'name': resources.Files.ADF_DOCUMENTS.TXT_0B.file_name,
'location': resources.Files.ADF_DOCUMENTS.TXT_0B.file_location
@@ -106,18 +100,6 @@ describe('Upload component - Excluded Files', () => {
.checkContentIsNotDisplayed(iniExcludedFile.name);
});
xit('[C260125] Should not upload excluded file when they are in a Folder', () => {
uploadToggles.enableFolderUpload();
contentServicesPage.uploadFolder(folderWithExcludedFile.location);
uploadDialog.checkUploadCompleted().then(() => {
contentServicesPage.doubleClickRow(folderWithExcludedFile.name)
.checkContentIsNotDisplayed(iniExcludedFile.name)
.checkContentIsDisplayed('a_file.txt');
});
});
it('[C212862] Should not allow upload file excluded in the files extension of app.config.json', async () => {
await LocalStorageUtil.setConfigField('files', JSON.stringify({
excluded: ['.DS_Store', 'desktop.ini', '*.txt'],
e2e/content-services/upload/uploader-component.e2e.ts
-53
View File
@@ -23,7 +23,6 @@ import { UploadDialog } from '../../pages/adf/dialog/uploadDialog';
import { UploadToggles } from '../../pages/adf/dialog/uploadToggles';
import { AcsUserModel } from '../../models/ACS/acsUserModel';
import { FileModel } from '../../models/ACS/fileModel';
import { FolderModel } from '../../models/ACS/folderModel';
import resources = require('../../util/resources');
import { NavigationBarPage } from '../../pages/adf/navigationBarPage';
import { AlfrescoApiCompatibility as AlfrescoApi } from '@alfresco/js-api';
@@ -67,16 +66,6 @@ describe('Upload component', () => {
'name': resources.Files.ADF_DOCUMENTS.TXT_0B.file_name,
'location': resources.Files.ADF_DOCUMENTS.TXT_0B.file_location
});
const folderOne = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.FOLDER_ONE.folder_name,
'location': resources.Files.ADF_DOCUMENTS.FOLDER_ONE.folder_location
});
const folderTwo = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.FOLDER_TWO.folder_name,
'location': resources.Files.ADF_DOCUMENTS.FOLDER_TWO.folder_location
});
const uploadedFileInFolder = new FileModel({ 'name': resources.Files.ADF_DOCUMENTS.FILE_INSIDE_FOLDER_ONE.file_name });
const uploadedFileInFolderTwo = new FileModel({ 'name': resources.Files.ADF_DOCUMENTS.FILE_INSIDE_FOLDER_TWO.file_name });
beforeAll(async (done) => {
@@ -126,22 +115,6 @@ describe('Upload component', () => {
.checkContentIsDisplayed(firstPdfFileModel.name);
});
xit('[C260173] Should be able to upload folder when enabled', () => {
uploadToggles.enableFolderUpload();
uploadToggles.checkFolderUploadToggleIsEnabled();
contentServicesPage.uploadFolder(folderOne.location);
uploadDialog.checkUploadCompleted().then(() => {
contentServicesPage.checkContentIsDisplayed(folderOne.name);
});
expect(contentServicesPage.getFolderButtonTooltip()).toEqual('Custom tooltip');
uploadDialog.fileIsUploaded(uploadedFileInFolder.name);
uploadDialog.clickOnCloseButton().dialogIsNotDisplayed();
contentServicesPage.doubleClickRow(folderOne.name).checkContentIsDisplayed(uploadedFileInFolder.name);
contentServicesPage.goToDocumentList();
uploadToggles.disableFolderUpload();
});
it('[C272789] Should be able to upload PDF file', () => {
contentServicesPage
.uploadFile(pdfFileModel.location)
@@ -298,32 +271,6 @@ describe('Upload component', () => {
uploadToggles.clickCheckboxDisableUpload();
expect(contentServicesPage.uploadButtonIsEnabled()).toBeTruthy();
});
xit('[C279882] Should be possible Upload a folder in a folder', () => {
uploadToggles.enableFolderUpload();
browser.driver.sleep(1000);
contentServicesPage.uploadFolder(folderOne.location);
uploadDialog.checkUploadCompleted().then(() => {
contentServicesPage.checkContentIsDisplayed(folderOne.name);
});
uploadDialog.fileIsUploaded(uploadedFileInFolder.name);
uploadDialog.clickOnCloseButton().dialogIsNotDisplayed();
contentServicesPage.doubleClickRow(folderOne.name).checkContentIsDisplayed(uploadedFileInFolder.name);
uploadToggles.enableFolderUpload();
browser.driver.sleep(1000);
contentServicesPage.uploadFolder(folderTwo.location);
uploadDialog.checkUploadCompleted().then(() => {
contentServicesPage.checkContentIsDisplayed(folderTwo.name);
});
uploadDialog.fileIsUploaded(uploadedFileInFolderTwo.name);
uploadDialog.clickOnCloseButton().dialogIsNotDisplayed();
contentServicesPage.doubleClickRow(folderTwo.name).checkContentIsDisplayed(uploadedFileInFolderTwo.name);
uploadToggles.disableFolderUpload();
});
});
it('[C260171] Should upload only the extension filter allowed when Enable extension filter is enabled', () => {
e2e/content-services/upload/user-permission.e2e.ts
-85
View File
@@ -20,12 +20,10 @@ import { browser } from 'protractor';
import { StringUtil, LoginPage, NotificationHistoryPage } from '@alfresco/adf-testing';
import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
import { UploadDialog } from '../../pages/adf/dialog/uploadDialog';
import { UploadToggles } from '../../pages/adf/dialog/uploadToggles';
import { NavigationBarPage } from '../../pages/adf/navigationBarPage';
import { AcsUserModel } from '../../models/ACS/acsUserModel';
import { FileModel } from '../../models/ACS/fileModel';
import { FolderModel } from '../../models/ACS/folderModel';
import resources = require('../../util/resources');
@@ -37,7 +35,6 @@ describe('Upload - User permission', () => {
const contentServicesPage = new ContentServicesPage();
const uploadDialog = new UploadDialog();
const uploadToggles = new UploadToggles();
const loginPage = new LoginPage();
let acsUser;
let acsUserTwo;
@@ -59,11 +56,6 @@ describe('Upload - User permission', () => {
'location': resources.Files.ADF_DOCUMENTS.PDF.file_location
});
const folder = new FolderModel({
'name': resources.Files.ADF_DOCUMENTS.FOLDER_TWO.folder_name,
'location': resources.Files.ADF_DOCUMENTS.FOLDER_TWO.folder_location
});
beforeAll(() => {
this.alfrescoJsApi = new AlfrescoApi({
provider: 'ECM',
@@ -114,31 +106,6 @@ describe('Upload - User permission', () => {
done();
});
xit('[C212861] Should not be allowed to Drag and drop a file/folder in a folder with consumer permissions', () => {
contentServicesPage.checkDragAndDropDIsDisplayed();
contentServicesPage.dragAndDropFolder(folder.location);
contentServicesPage.checkContentIsDisplayed(folder.name);
contentServicesPage.dragAndDropFile(emptyFile.location);
contentServicesPage.checkContentIsDisplayed(emptyFile.name);
navigationBarPage.openContentServicesFolder(this.consumerSite.entry.guid);
browser.sleep(3000);
contentServicesPage.dragAndDropFile(emptyFile.location);
contentServicesPage.dragAndDropFolder(folder.location);
const fileInTheUploadedFolder = 'share_profile_pic.png';
uploadDialog.fileIsError(emptyFile.name);
uploadDialog.fileIsError(fileInTheUploadedFolder);
contentServicesPage.checkContentIsNotDisplayed(emptyFile.name);
contentServicesPage.checkContentIsNotDisplayed(folder.name);
});
it('[C291921] Should display tooltip for uploading files without permissions', () => {
navigationBarPage.openContentServicesFolder(this.consumerSite.entry.guid);
@@ -169,30 +136,6 @@ describe('Upload - User permission', () => {
notificationHistoryPage.checkNotifyContains('You don\'t have the create permission to upload the content');
});
xit('[C279916] Should not be allowed to upload a folder in folder with consumer permissions', () => {
uploadToggles.enableFolderUpload();
uploadToggles.checkFolderUploadToggleIsEnabled();
contentServicesPage.uploadFolder(folder.location)
.checkContentIsDisplayed(folder.name);
const fileInTheUploadedFolder = 'share_profile_pic.png';
uploadDialog.fileIsUploaded(fileInTheUploadedFolder);
uploadDialog.clickOnCloseButton().dialogIsNotDisplayed();
navigationBarPage.openContentServicesFolder(this.consumerSite.entry.guid);
browser.sleep(3000);
uploadToggles.enableFolderUpload();
uploadToggles.checkFolderUploadToggleIsEnabled();
contentServicesPage.uploadFolder(folder.location);
notificationHistoryPage.checkNotifyContains('You don\'t have the create permission to upload the content');
});
});
describe('full permissions', () => {
@@ -205,40 +148,12 @@ describe('Upload - User permission', () => {
done();
});
xit('[C260130] Should be allowed to Drag and drop a file/folder in a folder with manager permissions', () => {
contentServicesPage.checkDragAndDropDIsDisplayed();
contentServicesPage.dragAndDropFile(emptyFile.location);
contentServicesPage.checkContentIsDisplayed(emptyFile.name);
contentServicesPage.dragAndDropFolder(folder.location);
contentServicesPage.checkContentIsDisplayed(folder.name);
const fileInTheUploadedFolder = 'share_profile_pic.png';
uploadDialog.fileIsUploaded(emptyFile.name);
uploadDialog.fileIsUploaded(fileInTheUploadedFolder);
});
it('[C279917] Should be allowed to upload a file in a folder with manager permissions', () => {
contentServicesPage.uploadFile(emptyFile.location);
uploadDialog.fileIsUploaded(emptyFile.name);
});
xit('[C279918] Should be allowed to upload a folder in a folder with manager permissions', () => {
uploadToggles.enableFolderUpload();
uploadToggles.checkFolderUploadToggleIsEnabled();
contentServicesPage.uploadFolder(folder.location);
uploadDialog.checkUploadCompleted().then(() => {
contentServicesPage.checkContentIsDisplayed(folder.name);
});
const fileInTheUploadedFolder = 'share_profile_pic.png';
uploadDialog.fileIsUploaded(fileInTheUploadedFolder);
});
});
describe('multiple users', () => {
e2e/core/settings-component.e2e.ts
-22
View File
@@ -49,28 +49,6 @@ describe('Settings component', () => {
loginPage.waitForElements();
});
xit('[C291946] Should not save BPM Settings changes when User clicks Back button', () => {
settingsPage.setProvider(settingsPage.getBpmOption(), 'BPM');
settingsPage.setProcessServicesURL('http://myenvUrl.co.uk');
settingsPage.clickBackButton();
loginPage.waitForElements();
settingsPage.goToSettingsPage();
expect(settingsPage.getSelectedOptionText()).not.toEqual('BPM', 'The Settings changes are saved');
expect(settingsPage.getBpmHostUrl()).not.toEqual('http://myenvUrl.co.uk', 'The Settings changes are saved');
});
xit('[C291947] Should not save ECM Settings changes when User clicks Back button', () => {
settingsPage.setProvider(settingsPage.getEcmOption(), 'ECM');
settingsPage.setContentServicesURL('http://myenvUrl.co.uk');
settingsPage.clickBackButton();
loginPage.waitForElements();
settingsPage.goToSettingsPage();
expect(settingsPage.getSelectedOptionText()).not.toEqual('ECM', 'The Settings changes are saved');
expect(settingsPage.getBpmHostUrl()).not.toEqual('http://myenvUrl.co.uk', 'The Settings changes are saved');
});
it('[C291948] Should save ALL Settings changes when User clicks Apply button', () => {
loginPage.goToLoginPage();
loginPage.clickSettingsIcon();
e2e/core/user-info-component.e2e.ts
+1 -1
View File
@@ -69,7 +69,7 @@ describe('User Info component', () => {
done();
});
xit('[C260111] Should display UserInfo when Process Services and Content Services are enabled', async () => {
it('[C260111] Should display UserInfo when Process Services and Content Services are enabled', async () => {
await loginPage.loginToAllUsingUserModel(contentUserModel);
userInfoPage.clickUserProfile();
e2e/process-services/custom-tasks-filters.e2e.ts
-52
View File
@@ -444,58 +444,6 @@ describe('Start Task - Custom App', () => {
});
});
// failing due to ADF-3667, blocked by ACTIVITI-1975
xit('[C286599] Should be able to sort tasks ascending by due date when choosing due(asc) from sort drop down', () => {
const sortAscByDueDate = [taskWithDueDate.name, completedTasks[0].name, completedTasks[1].name, completedTasks[2].name];
navigationBarPage.clickTaskListButton();
taskListSinglePage.clickResetButton();
taskListSinglePage.typeDueAfter(beforeDate);
taskListSinglePage.selectState('All');
taskListSinglePage.selectSort('Due (asc)');
taskListSinglePage.taskList().getAllRowsNameColumn().then(function (list) {
expect(Util.arrayContainsArray(list, sortAscByDueDate)).toEqual(true);
});
expect(taskListSinglePage.taskList().getDataTable().numberOfRows()).toBe(4);
taskListSinglePage.clickResetButton();
taskListSinglePage.selectState('All');
taskListSinglePage.selectSort('Due (asc)');
expect(taskListSinglePage.taskList().getDataTable().numberOfRows()).toBe(23);
taskListSinglePage.taskList().getAllRowsNameColumn().then(function (list) {
expect(Util.arrayContainsArray(list.slice(0, 4), sortAscByDueDate)).toEqual(true);
expect(Util.arrayContainsArray(list.slice(4, list.length), allTasksName)).toEqual(true);
});
});
// failing due to ADF-3667, blocked by ACTIVITI-1975
xit('[C286600] Should be able to sort tasks descending by due date when choosing due(desc) from sort drop down', () => {
const sortDescByDueDate = [completedTasks[2].name, completedTasks[1].name, completedTasks[0].name, taskWithDueDate.name];
navigationBarPage.clickTaskListButton();
taskListSinglePage.clickResetButton();
taskListSinglePage.typeDueAfter(beforeDate);
taskListSinglePage.selectState('All');
taskListSinglePage.selectSort('Due (desc)');
taskListSinglePage.taskList().getAllRowsNameColumn().then(function (list) {
expect(Util.arrayContainsArray(list, sortDescByDueDate)).toEqual(true);
});
expect(taskListSinglePage.taskList().getDataTable().numberOfRows()).toBe(4);
taskListSinglePage.clickResetButton();
taskListSinglePage.selectState('All');
taskListSinglePage.selectSort('Due (asc)');
expect(taskListSinglePage.taskList().getDataTable().numberOfRows()).toBe(23);
taskListSinglePage.taskList().getAllRowsNameColumn().then(function (list) {
expect(Util.arrayContainsArray(list.slice(0, 4), sortDescByDueDate)).toEqual(true);
expect(Util.arrayContainsArray(list.slice(4, list.length), allTasksName)).toEqual(true);
});
});
it('[C286622] Should be able to see only tasks that are part of a specific process when processDefinitionId is set', () => {
const processDefinitionIds = [processDefinitionId.processDefinitionId, processDefinitionId.processDefinitionId,
processDefinitionId.processDefinitionId, processDefinitionId.processDefinitionId];
e2e/process-services/start-task-custom-app.e2e.ts
-9
View File
@@ -282,13 +282,4 @@ describe('Start Task - Custom App', () => {
taskPage.taskDetails().taskInfoDrawerIsDisplayed();
});
xit('[C263950] Should be able to see Spinner loading on task list when clicking on Tasks on custom app', () => {
navigationBarPage.navigateToProcessServicesPage().goToApp(appModel.name).clickTasksButton();
taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
taskPage.createNewTask().addName(tasks[7]).clickStartButton();
navigationBarPage.navigateToProcessServicesPage().goToTaskApp();
taskPage.tasksListPage().getDataTable().checkSpinnerIsDisplayed();
});
});
e2e/process-services/start-task-task-app.e2e.ts
-4
View File
@@ -172,10 +172,6 @@ describe('Start Task - Task App', () => {
taskPage.taskDetails().taskInfoDrawerIsDisplayed();
});
xit('[C260424] Should be able to see Spinner loading on task list when clicking on Tasks', () => {
taskPage.tasksListPage().getDataTable().checkSpinnerIsDisplayed();
});
it('[C291780] Should be displayed an error message if task name exceed 255 characters', () => {
const startDialog = taskPage.createNewTask().addName(taskName255Characters).checkStartButtonIsEnabled();
startDialog.addName(taskNameBiggerThen255Characters)
e2e/search/search-component.e2e.ts
-17
View File
@@ -25,7 +25,6 @@ import { SearchResultsPage } from '../pages/adf/searchResultsPage';
import { AcsUserModel } from '../models/ACS/acsUserModel';
import { FileModel } from '../models/ACS/fileModel';
import { FolderModel } from '../models/ACS/folderModel';
import { Util } from '../util/util';
import { AlfrescoApiCompatibility as AlfrescoApi } from '@alfresco/js-api';
import { NavigationBarPage } from '../pages/adf/navigationBarPage';
import { SearchConfiguration } from './search.config';
@@ -269,22 +268,6 @@ describe('Search component - Search Bar', () => {
expect(contentServicesPage.currentFolderName()).toEqual(secondFolder.name);
});
xit('[C260254] Search bar should get closed when changing browser tab', () => {
searchDialog
.checkSearchIconIsVisible()
.clickOnSearchIcon()
.checkSearchBarIsVisible()
.enterText(secondFolder.shortName);
searchDialog.resultTableContainsRow(secondFolder.name);
Util.openNewTabInBrowser();
Util.switchToWindowHandler(0);
browser.sleep(500);
searchDialog.checkSearchBarIsNotVisible().checkSearchIconIsVisible();
});
it('[C290137] Should be able to search by \'%\'', () => {
searchDialog
.clickOnSearchIcon()