inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ban xit and xdescribe use in the future (#4923)

Browse Source 
* remove xit test and ban xit and xdescribe use in the future

* remove xit test and ban xit and xdescribe use in the future

* remove test excluded

* remove consecutive blank line
This commit is contained in:
Eugenio Romano
2019-07-12 15:04:53 +01:00
committed by GitHub
parent 07213fac3a
commit b28a53afe7
28 changed files with 7 additions and 893 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
lib/core/form/services/widget-visibility-cloud.service.spec.ts
View File

@@ -488,15 +488,6 @@ describe('WidgetVisibilityCloudService', () => {
expect(isVisible).toBeTruthy();
});
xit('should return empty string for a value that is not on variable or form', () => {
visibilityObjTest.leftType = WidgetTypeEnum.field;
visibilityObjTest.leftValue = 'NO_FIELD_FORM';
const rightValue = service.getRightValue(fakeFormWithField, visibilityObjTest);
expect(rightValue).not.toBeUndefined();
expect(rightValue).toBe('');
});
it('should evaluate the visibility for the field with single visibility condition between form values', () => {
visibilityObjTest.leftType = 'LEFT_FORM_FIELD_ID';
visibilityObjTest.operator = '!=';
@@ -559,14 +550,6 @@ describe('WidgetVisibilityCloudService', () => {
expect(leftValue).toBe('form_value_test');
});
xit('should determine visibility for dropdown on label condition', () => {
const dropdownValue = service.getFieldValue(formTest.values, 'Dropdown');
expect(dropdownValue).not.toBeNull();
expect(dropdownValue).toBeDefined();
expect(dropdownValue).toBe('Dropdown');
});
it('should be able to get the value for a standard field', () => {
const dropdownValue = service.getFieldValue(formTest.values, 'test_2');
@@ -575,14 +558,6 @@ describe('WidgetVisibilityCloudService', () => {
expect(dropdownValue).toBe('value_2');
});
xit('should get the dropdown label value from a form', () => {
const dropdownValue = service.getFormValue(formTest, 'Dropdown');
expect(dropdownValue).not.toBeNull();
expect(dropdownValue).toBeDefined();
expect(dropdownValue).toBe('Dropdown');
});
it('should get the dropdown id value from a form', () => {
const dropdownValue = service.getFormValue(formTest, 'dropdown');
@@ -600,26 +575,6 @@ describe('WidgetVisibilityCloudService', () => {
expect(rightValue).toBe('dropdown_id');
});
xit('should retrieve the value for the right field when it is a dropdown label', () => {
visibilityObjTest.rightType = 'field';
visibilityObjTest.rightValue = 'Dropdown';
const rightValue = service.getRightValue(formTest, visibilityObjTest);
expect(rightValue).toBeDefined();
expect(rightValue).toBe('Dropdown');
});
xit('should be able to evaluate condition with a dropdown <label>', () => {
visibilityObjTest.leftType = 'field';
visibilityObjTest.leftValue = 'test_5';
visibilityObjTest.operator = '==';
visibilityObjTest.rightValue = 'Dropdown';
const fakeFormField: FormFieldModel = new FormFieldModel(formTest, jsonFieldFake);
service.refreshEntityVisibility(fakeFormField);
expect(fakeFormField.isVisible).toBeTruthy();
});
it('should be able to evaluate condition with a dropdown <id>', () => {
visibilityObjTest.rightType = 'field';
visibilityObjTest.leftType = 'field';