From 8993223a62f994f62c8cf7a5a427838fea08bd7e Mon Sep 17 00:00:00 2001
From: mauriziovitale84 <maurizio.vitale@alfresco.com>
Date: Tue, 13 Dec 2016 09:55:13 +0000
Subject: [PATCH 1/3] #1174 Add update report endpoint

---
 ...analytics-report-parameters.component.html | 13 +++++++++++-
 .../analytics-report-parameters.component.ts  | 21 +++++++++++++++++++
 .../src/components/analytics.component.ts     |  6 +++++-
 .../src/services/analytics.service.ts         |  7 +++++++
 4 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html
index f48bbb8bc0..b8f5fc8e10 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html
@@ -1,7 +1,18 @@
 <div class="col-md-6">
     <div *ngIf="reportParameters">
         <form [formGroup]="reportForm" novalidate>
-        <h4>{{reportParameters.name}}</h4>
+        <div *ngIf="isEditable">
+            <input
+                    type="text"
+                    class="mdl-textfield__input"
+                    id="reportName"
+                    data-automation-id="reportName"
+                    [value]="reportParameters.name"
+                    (input)="reportParameters.name=$event.target.value"
+                    (blur)="editTitle($event)"
+                    />
+        </div>
+        <h4 *ngIf="!isEditable" (click)="editEnable()">{{reportParameters.name}}</h4>
         <div *ngFor="let field of reportParameters.definition.parameters">
             <div [ngSwitch]="field.type">
                 <div *ngSwitchCase="'integer'">
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts
index cf16698e80..15a8707bf0 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts
@@ -63,6 +63,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges {
     private dropDownSub;
     private reportParamsSub;
     private paramOpts;
+    private isEditable: boolean = false;
 
     constructor(private translate: AlfrescoTranslationService,
                 private analyticsService: AnalyticsService,
@@ -210,4 +211,24 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges {
             this.reportParamsSub.unsubscribe();
         }
     }
+
+    public editEnable() {
+        this.isEditable =  true;
+    }
+
+    public editDisable() {
+        this.isEditable = false;
+    }
+
+    public editTitle() {
+        this.reportParamsSub = this.analyticsService.updateReport(this.reportParameters.id, this.reportParameters.name).subscribe(
+            (res: ReportParametersModel) => {
+                this.editDisable();
+            },
+            (err: any) => {
+                console.log(err);
+                this.onError.emit(err);
+            }
+        );
+    }
 }
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts b/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts
index 3d12832940..aba1a6d550 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts
@@ -46,7 +46,7 @@ export class AnalyticsComponent implements OnChanges {
 
     reportParamQuery = new ReportQuery();
 
-    reports: any[];
+    reports: Chart[];
 
     public barChartOptions: any = {
         responsive: true,
@@ -107,4 +107,8 @@ export class AnalyticsComponent implements OnChanges {
         let clone = JSON.parse(JSON.stringify(report));
         report.datasets = clone.datasets;
     }
+
+    public editReport(report: Chart) {
+        console.log(report);
+    }
 }
diff --git a/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts b/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts
index d9fc0b94cd..2849515e8f 100644
--- a/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts
+++ b/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts
@@ -178,6 +178,13 @@ export class AnalyticsService {
             .catch(this.handleError);
     }
 
+    updateReport(reportId: number, name: string): Observable<any> {
+        return Observable.fromPromise(this.apiService.getInstance().activiti.reportApi.updateReport(reportId, name))
+            .map((res: any) => {
+                console.log('upload');
+            }).catch(this.handleError);
+    }
+
     private handleError(error: Response) {
         console.error(error);
         return Observable.throw(error.json().error || 'Server error');

From a12c370cc792eb31a62fe86d1a00f81624eb06a7 Mon Sep 17 00:00:00 2001
From: mauriziovitale84 <maurizio.vitale@alfresco.com>
Date: Tue, 13 Dec 2016 16:10:32 +0000
Subject: [PATCH 2/3] #1174 Rename report

---
 .../src/components/analytics-report-parameters.component.css  | 4 ++++
 .../src/components/analytics-report-parameters.component.html | 2 +-
 .../ng2-activiti-analytics/src/services/analytics.service.ts  | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css
index ae995ca854..19692bd6a6 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css
@@ -21,3 +21,7 @@
 .dropdown-widget__invalid .mdl-textfield__error {
     visibility: visible !important;
 }
+
+.large {
+    font-size: 44px;
+}
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html
index b8f5fc8e10..ba7950517c 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.html
@@ -4,7 +4,7 @@
         <div *ngIf="isEditable">
             <input
                     type="text"
-                    class="mdl-textfield__input"
+                    class="mdl-textfield__input large"
                     id="reportName"
                     data-automation-id="reportName"
                     [value]="reportParameters.name"
diff --git a/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts b/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts
index 2849515e8f..f1ccd7c731 100644
--- a/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts
+++ b/ng2-components/ng2-activiti-analytics/src/services/analytics.service.ts
@@ -178,7 +178,7 @@ export class AnalyticsService {
             .catch(this.handleError);
     }
 
-    updateReport(reportId: number, name: string): Observable<any> {
+    public updateReport(reportId: number, name: string): Observable<any> {
         return Observable.fromPromise(this.apiService.getInstance().activiti.reportApi.updateReport(reportId, name))
             .map((res: any) => {
                 console.log('upload');

From 8bfa71bc480dd4fbdb0dc389c45fdb59b8ffc042 Mon Sep 17 00:00:00 2001
From: mauriziovitale84 <maurizio.vitale@alfresco.com>
Date: Wed, 14 Dec 2016 15:14:37 +0000
Subject: [PATCH 3/3] #1174 Refresh the report list after edit report title

---
 .../activiti/activiti-demo.component.html     | 11 +++++++--
 .../activiti/activiti-demo.component.ts       |  8 +++++++
 .../analytics-report-list.component.ts        | 23 ++++++++++++++++---
 .../analytics-report-parameters.component.css |  2 +-
 .../analytics-report-parameters.component.ts  |  4 ++++
 .../src/components/analytics.component.html   |  5 +++-
 .../src/components/analytics.component.ts     |  7 ++++--
 7 files changed, 51 insertions(+), 9 deletions(-)

diff --git a/demo-shell-ng2/app/components/activiti/activiti-demo.component.html b/demo-shell-ng2/app/components/activiti/activiti-demo.component.html
index 8469fd7fb2..0d08e2376e 100644
--- a/demo-shell-ng2/app/components/activiti/activiti-demo.component.html
+++ b/demo-shell-ng2/app/components/activiti/activiti-demo.component.html
@@ -92,10 +92,17 @@
             <div class="page-content">
                 <div class="mdl-grid">
                     <div class="mdl-cell mdl-cell--4-col task-column mdl-shadow--2dp">
-                        <analytics-report-list (reportClick)="onReportClick($event)"></analytics-report-list>
+                        <analytics-report-list
+                                (reportClick)="onReportClick($event)"
+                                #analyticsreportlist >
+                        </analytics-report-list>
                     </div>
                     <div class="mdl-cell mdl-cell--8-col task-column mdl-shadow--2dp">
-                        <activiti-analytics [appId]="appId" *ngIf="report" [reportId]="report.id"></activiti-analytics>
+                        <activiti-analytics *ngIf="report"
+                                            [appId]="appId"
+                                            [reportId]="report.id"
+                                            (editReport)="onEditReport($event)">
+                        </activiti-analytics>
                     </div>
                 </div>
             </div>
diff --git a/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts b/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts
index 7936e77575..d8fd23ce9a 100644
--- a/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts
+++ b/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts
@@ -30,6 +30,7 @@ import {
     ActivitiStartProcessInstance,
     ProcessInstance
 } from 'ng2-activiti-processlist';
+import { AnalyticsReportListComponent } from 'ng2-activiti-analytics';
 import { ActivatedRoute } from '@angular/router';
 import { Subscription } from 'rxjs/Rx';
 import {
@@ -75,6 +76,9 @@ export class ActivitiDemoComponent implements AfterViewInit {
     @ViewChild(ActivitiStartProcessInstance)
     activitiStartProcess: ActivitiStartProcessInstance;
 
+    @ViewChild(AnalyticsReportListComponent)
+    analyticsreportlist: AnalyticsReportListComponent;
+
     @Input()
     appId: number;
 
@@ -183,6 +187,10 @@ export class ActivitiDemoComponent implements AfterViewInit {
         this.currentProcessInstanceId = processInstanceId;
     }
 
+    onEditReport(name: string) {
+        this.analyticsreportlist.reload();
+    }
+
     navigateStartProcess() {
         this.currentProcessInstanceId = currentProcessIdNew;
     }
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-list.component.ts b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-list.component.ts
index 979d8ad0b1..47ce38c21b 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-list.component.ts
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-list.component.ts
@@ -57,13 +57,21 @@ export class AnalyticsReportListComponent implements  OnInit {
             this.reports.push(report);
         });
 
-        this.getReportListByAppId();
+        this.getReportList();
     }
 
     /**
-     * Get the report list by app id
+     * Reload the component
      */
-    getReportListByAppId() {
+    reload() {
+        this.reset();
+        this.getReportList();
+    }
+
+    /**
+     * Get the report list
+     */
+    getReportList() {
         this.analyticsService.getReportList().subscribe(
             (res: ReportParametersModel[]) => {
                 if (res && res.length === 0) {
@@ -108,6 +116,15 @@ export class AnalyticsReportListComponent implements  OnInit {
         return this.reports === undefined || (this.reports && this.reports.length === 0);
     }
 
+    /**
+     * Reset the list
+     */
+    private reset() {
+        if (!this.isReportsEmpty()) {
+            this.reports = [];
+        }
+    }
+
     /**
      * Select the current report
      * @param report
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css
index 19692bd6a6..aae39eab91 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.css
@@ -23,5 +23,5 @@
 }
 
 .large {
-    font-size: 44px;
+    font-size: x-large;
 }
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts
index 15a8707bf0..45bc29cc9a 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics-report-parameters.component.ts
@@ -47,6 +47,9 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges {
     @Output()
     onError = new EventEmitter();
 
+    @Output()
+    onEdit = new EventEmitter();
+
     @Output()
     onFormValueChanged = new EventEmitter();
 
@@ -224,6 +227,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges {
         this.reportParamsSub = this.analyticsService.updateReport(this.reportParameters.id, this.reportParameters.name).subscribe(
             (res: ReportParametersModel) => {
                 this.editDisable();
+                this.onEdit.emit(this.reportParameters.name);
             },
             (err: any) => {
                 console.log(err);
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics.component.html b/ng2-components/ng2-activiti-analytics/src/components/analytics.component.html
index a6b2f5ef26..a52b7480c7 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics.component.html
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics.component.html
@@ -1,6 +1,9 @@
 <div class="col-md-6">
     <analytics-report-parameters [appId]="appId" [reportId]="reportId"
-                                 (onFormValueChanged)="reset()" (onSuccess)="showReport($event)"></analytics-report-parameters>
+                                 (onFormValueChanged)="reset()"
+                                 (onSuccess)="showReport($event)"
+                                 (onEdit)="onEditReport($event)">
+    </analytics-report-parameters>
 
     <div *ngIf="reports">
         <div *ngFor="let report of reports">
diff --git a/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts b/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts
index aba1a6d550..008e12cbbf 100644
--- a/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts
+++ b/ng2-components/ng2-activiti-analytics/src/components/analytics.component.ts
@@ -41,6 +41,9 @@ export class AnalyticsComponent implements OnChanges {
     @Output()
     onSuccess = new EventEmitter();
 
+    @Output()
+    editReport = new EventEmitter();
+
     @Output()
     onError = new EventEmitter();
 
@@ -108,7 +111,7 @@ export class AnalyticsComponent implements OnChanges {
         report.datasets = clone.datasets;
     }
 
-    public editReport(report: Chart) {
-        console.log(report);
+    public onEditReport(name: string) {
+        this.editReport.emit(name);
     }
 }