[ADF-4298] Improve Info drawer e2e tests (#4532)

* [ADF-4298] Improve Info drawer e2e tests

* [ADF-4298] Add new tab with single icon and update e2e tests
This commit is contained in:
davidcanonieto
2019-04-02 12:00:27 +01:00
committed by Eugenio Romano
parent 2b4d748a66
commit b60e9a7c6e
5 changed files with 69 additions and 27 deletions
+19 -13
View File
@@ -74,30 +74,36 @@ describe('Info Drawer', () => {
done();
});
it('[C277251] Should display only the icon when the icon property is defined', () => {
loginPage.loginToContentServicesUsingUserModel(acsUser);
navigationBarPage.goToSite(site);
contentServicesPage.checkAcsContainer();
viewerPage.viewFile(pngFileUploaded.entry.name);
viewerPage.clickLeftSidebarButton();
viewerPage.enableShowTabWithIcon();
viewerPage.checkTabHasIcon(1);
expect(viewerPage.getTabLabelById(1)).not.toBe('COMMENT');
expect(viewerPage.getTabIconById(1)).toBe('comment');
afterAll(async (done) => {
await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
await uploadActions.deleteFilesOrFolder(this.alfrescoJsApi, pngFileUploaded.entry.id);
done();
});
it('[C277252] Should display the label when the icon property is not defined', () => {
beforeEach(() => {
loginPage.loginToContentServicesUsingUserModel(acsUser);
navigationBarPage.goToSite(site);
contentServicesPage.checkAcsContainer();
});
it('[C277251] Should display the icon when the icon property is defined', () => {
viewerPage.viewFile(pngFileUploaded.entry.name);
viewerPage.clickLeftSidebarButton();
viewerPage.enableShowTabWithIcon();
viewerPage.enableShowTabWithIconAndLabel();
viewerPage.checkTabHasNoIcon(0);
expect(viewerPage.getTabIconById(1)).toBe('face');
expect(viewerPage.getTabIconById(2)).toBe('comment');
});
it('[C277252] Should display the label when the label property is defined', () => {
viewerPage.viewFile(pngFileUploaded.entry.name);
viewerPage.clickLeftSidebarButton();
viewerPage.enableShowTabWithIcon();
viewerPage.enableShowTabWithIconAndLabel();
expect(viewerPage.getTabLabelById(0)).toBe('SETTINGS');
viewerPage.checkTabHasNoLabel(1);
expect(viewerPage.getTabLabelById(2)).toBe('COMMENTS');
});
});
+17 -2
View File
@@ -98,7 +98,8 @@ export class ViewerPage {
codeViewer = element(by.id('adf-monaco-file-editor'));
moveRightChevron = element(by.css('.mat-tab-header-pagination-after .mat-tab-header-pagination-chevron'));
showTabWithIconSwitch = element(by.id('adf-show-tab-with-icon'));
showTabWithIconSwitch = element(by.id('adf-tab-with-icon'));
showTabWithIconAndLabelSwitch = element(by.id('adf-icon-and-label-tab'));
checkCodeViewerIsDisplayed() {
return BrowserVisibility.waitUntilElementIsVisible(this.codeViewer);
@@ -513,6 +514,14 @@ export class ViewerPage {
this.formControllersPage.enableToggle(this.showTabWithIconSwitch);
}
disableShowTabWithIconAndLabel() {
this.formControllersPage.disableToggle(this.showTabWithIconAndLabelSwitch);
}
enableShowTabWithIconAndLabel() {
this.formControllersPage.enableToggle(this.showTabWithIconAndLabelSwitch);
}
checkDownloadButtonDisplayed() {
BrowserVisibility.waitUntilElementIsVisible(this.downloadButton);
return this;
@@ -649,8 +658,14 @@ export class ViewerPage {
return this;
}
checkTabHasNoLabel(index: number) {
const tab = element(by.css(`div[id="mat-tab-label-1-${index}"] div[class="mat-tab-label-content"] span`));
BrowserVisibility.waitUntilElementIsNotVisible(tab);
return this;
}
getTabLabelById(index: number) {
const tab = element(by.css(`div[id="mat-tab-label-1-${index}"] div[class="mat-tab-label-content"]`));
const tab = element(by.css(`div[id="mat-tab-label-1-${index}"] div[class="mat-tab-label-content"] span`));
BrowserVisibility.waitUntilElementIsVisible(tab);
return tab.getText();
}