From bc48a3923e88576892eeee05f27fdf3cef4ea4e2 Mon Sep 17 00:00:00 2001 From: Eugenio Romano Date: Thu, 23 Nov 2017 14:05:13 +0000 Subject: [PATCH] [ADF-2005] Cannot view document in tasklist attachment list (#2701) --- demo-shell/src/app/app.module.ts | 26 ++++----- demo-shell/src/app/app.routes.ts | 22 ++++---- .../activiti-task-attachments.component.html | 32 ----------- .../file-view/file-view.component.ts | 6 ++- .../apps-view.component.html | 0 .../apps-view.component.ts | 4 +- .../custom-editor/custom-editor.component.ts | 2 +- .../demo-field-validator.ts | 0 .../form-node-viewer.component.css | 0 .../form-node-viewer.component.html | 0 .../form-node-viewer.component.ts | 0 .../form-viewer.component.css | 0 .../form-viewer.component.html | 0 .../form-viewer.component.ts | 2 +- .../process-attachments.component.css} | 0 .../process-attachments.component.html} | 10 ++-- .../process-attachments.component.ts} | 14 ++--- .../process-service.component.html} | 54 +++++++------------ .../process-service.component.scss} | 14 ++--- .../process-service.component.ts} | 12 ++--- .../show-diagram.component.css} | 0 .../show-diagram.component.html} | 0 .../show-diagram.component.ts} | 8 +-- .../task-attachments.component.css} | 0 .../task-attachments.component.html | 39 ++++++++++++++ .../task-attachments.component.ts} | 8 +-- .../app/services/in-memory-form.service.ts | 6 +-- demo-shell/tslint.json | 2 +- 28 files changed, 128 insertions(+), 133 deletions(-) delete mode 100644 demo-shell/src/app/components/activiti/activiti-task-attachments.component.html rename demo-shell/src/app/components/{activiti => process-service}/apps-view.component.html (100%) rename demo-shell/src/app/components/{activiti => process-service}/apps-view.component.ts (93%) rename demo-shell/src/app/components/{activiti => process-service}/custom-editor/custom-editor.component.ts (93%) rename demo-shell/src/app/components/{activiti => process-service}/demo-field-validator.ts (100%) rename demo-shell/src/app/components/{activiti => process-service}/form-node-viewer.component.css (100%) rename demo-shell/src/app/components/{activiti => process-service}/form-node-viewer.component.html (100%) rename demo-shell/src/app/components/{activiti => process-service}/form-node-viewer.component.ts (100%) rename demo-shell/src/app/components/{activiti => process-service}/form-viewer.component.css (100%) rename demo-shell/src/app/components/{activiti => process-service}/form-viewer.component.html (100%) rename demo-shell/src/app/components/{activiti => process-service}/form-viewer.component.ts (97%) rename demo-shell/src/app/components/{activiti/activiti-process-attachments.component.css => process-service/process-attachments.component.css} (100%) rename demo-shell/src/app/components/{activiti/activiti-process-attachments.component.html => process-service/process-attachments.component.html} (76%) rename demo-shell/src/app/components/{activiti/activiti-process-attachments.component.ts => process-service/process-attachments.component.ts} (82%) rename demo-shell/src/app/components/{activiti/activiti.component.html => process-service/process-service.component.html} (76%) rename demo-shell/src/app/components/{activiti/activiti.component.scss => process-service/process-service.component.scss} (90%) rename demo-shell/src/app/components/{activiti/activiti.component.ts => process-service/process-service.component.ts} (97%) rename demo-shell/src/app/components/{activiti/activiti-show-diagram.component.css => process-service/show-diagram.component.css} (100%) rename demo-shell/src/app/components/{activiti/activiti-show-diagram.component.html => process-service/show-diagram.component.html} (100%) rename demo-shell/src/app/components/{activiti/activiti-show-diagram.component.ts => process-service/show-diagram.component.ts} (85%) rename demo-shell/src/app/components/{activiti/activiti-task-attachments.component.css => process-service/task-attachments.component.css} (100%) create mode 100644 demo-shell/src/app/components/process-service/task-attachments.component.html rename demo-shell/src/app/components/{activiti/activiti-task-attachments.component.ts => process-service/task-attachments.component.ts} (89%) diff --git a/demo-shell/src/app/app.module.ts b/demo-shell/src/app/app.module.ts index f7e67cf675..985735a566 100644 --- a/demo-shell/src/app/app.module.ts +++ b/demo-shell/src/app/app.module.ts @@ -22,13 +22,11 @@ import { FormComponent } from './components/form/form.component'; import { FormListComponent } from './components/form/form-list.component'; import { CustomSourcesComponent } from './components/files/custom-sources.component'; -import { ActivitiComponent } from './components/activiti/activiti.component'; -import { ActivitiTaskAttachmentsComponent } from './components/activiti/activiti-task-attachments.component'; -import { ActivitiProcessAttachmentsComponent } from './components/activiti/activiti-process-attachments.component'; -import { ActivitiShowDiagramComponent } from './components/activiti/activiti-show-diagram.component'; -import { FormViewerComponent } from './components/activiti/form-viewer.component'; -import { FormNodeViewerComponent } from './components/activiti/form-node-viewer.component'; -import { ActivitiAppsViewComponent } from './components/activiti/apps-view.component'; +import { ProcessServiceComponent } from './components/process-service/process-service.component'; +import { ShowDiagramComponent } from './components/process-service/show-diagram.component'; +import { FormViewerComponent } from './components/process-service/form-viewer.component'; +import { FormNodeViewerComponent } from './components/process-service/form-node-viewer.component'; +import { AppsViewComponent } from './components/process-service/apps-view.component'; import { DataTableComponent } from './components/datatable/datatable.component'; import { FilesComponent } from './components/files/files.component'; import { FileViewComponent } from './components/file-view/file-view.component'; @@ -43,6 +41,8 @@ import { DebugAppConfigService } from './services/debug-app-config.service'; import { routing } from './app.routes'; import { TranslateModule } from '@ngx-translate/core'; import { ReactiveFormsModule } from '@angular/forms'; +import { TaskAttachmentsComponent } from './components/process-service/task-attachments.component'; +import { ProcessAttachmentsComponent } from './components/process-service/process-attachments.component'; @NgModule({ @@ -69,13 +69,11 @@ import { ReactiveFormsModule } from '@angular/forms'; SearchBarComponent, SearchResultComponent, AboutComponent, - ActivitiComponent, - ActivitiTaskAttachmentsComponent, - ActivitiProcessAttachmentsComponent, - ActivitiShowDiagramComponent, + ProcessServiceComponent, + ShowDiagramComponent, FormViewerComponent, FormNodeViewerComponent, - ActivitiAppsViewComponent, + AppsViewComponent, DataTableComponent, FilesComponent, FileViewComponent, @@ -85,7 +83,9 @@ import { ReactiveFormsModule } from '@angular/forms'; TagComponent, SocialComponent, CustomSourcesComponent, - VersionManagerDialogAdapterComponent + VersionManagerDialogAdapterComponent, + TaskAttachmentsComponent, + ProcessAttachmentsComponent ], providers: [ TranslateService, diff --git a/demo-shell/src/app/app.routes.ts b/demo-shell/src/app/app.routes.ts index 5505e4da96..f9a7b5938f 100644 --- a/demo-shell/src/app/app.routes.ts +++ b/demo-shell/src/app/app.routes.ts @@ -23,11 +23,11 @@ import { LoginComponent } from './components/login/login.component'; import { SettingsComponent } from './components/settings/settings.component'; import { HomeComponent } from './components/home/home.component'; import { AboutComponent } from './components/about/about.component'; -import { ActivitiComponent } from './components/activiti/activiti.component'; -import { ActivitiShowDiagramComponent } from './components/activiti/activiti-show-diagram.component'; -import { FormViewerComponent } from './components/activiti/form-viewer.component'; -import { FormNodeViewerComponent } from './components/activiti/form-node-viewer.component'; -import { ActivitiAppsViewComponent } from './components/activiti/apps-view.component'; +import { ProcessServiceComponent } from './components/process-service/process-service.component'; +import { ShowDiagramComponent } from './components/process-service/show-diagram.component'; +import { FormViewerComponent } from './components/process-service/form-viewer.component'; +import { FormNodeViewerComponent } from './components/process-service/form-node-viewer.component'; +import { AppsViewComponent } from './components/process-service/apps-view.component'; import { SearchResultComponent } from './components/search/search-result.component'; import { DataTableComponent } from './components/datatable/datatable.component'; @@ -91,33 +91,33 @@ export const appRoutes: Routes = [ }, { path: 'activiti', - component: ActivitiAppsViewComponent, + component: AppsViewComponent, canActivate: [AuthGuardBpm] }, { path: 'activiti/apps', - component: ActivitiAppsViewComponent, + component: AppsViewComponent, canActivate: [AuthGuardBpm] }, { path: 'activiti/apps/:appId/tasks', - component: ActivitiComponent, + component: ProcessServiceComponent, canActivate: [AuthGuardBpm] }, { path: 'activiti/apps/:appId/processes', - component: ActivitiComponent, + component: ProcessServiceComponent, canActivate: [AuthGuardBpm] }, { path: 'activiti/apps/:appId/diagram/:processDefinitionId', - component: ActivitiShowDiagramComponent, + component: ShowDiagramComponent, canActivate: [AuthGuardBpm] }, // TODO: check if neeeded { path: 'activiti/appId/:appId', - component: ActivitiComponent, + component: ProcessServiceComponent, canActivate: [AuthGuardBpm] }, // TODO: check if needed diff --git a/demo-shell/src/app/components/activiti/activiti-task-attachments.component.html b/demo-shell/src/app/components/activiti/activiti-task-attachments.component.html deleted file mode 100644 index 614eb855bf..0000000000 --- a/demo-shell/src/app/components/activiti/activiti-task-attachments.component.html +++ /dev/null @@ -1,32 +0,0 @@ -
-
Attachments
-
- - - - - - - - -
-
- -
- - -
diff --git a/demo-shell/src/app/components/file-view/file-view.component.ts b/demo-shell/src/app/components/file-view/file-view.component.ts index 0362474ed4..3b0da5f72d 100644 --- a/demo-shell/src/app/components/file-view/file-view.component.ts +++ b/demo-shell/src/app/components/file-view/file-view.component.ts @@ -20,7 +20,7 @@ import { ActivatedRoute, Router } from '@angular/router'; import { AlfrescoApiService } from '@alfresco/adf-core'; @Component({ - selector: 'adf-file-view', + selector: 'app-file-view', templateUrl: 'file-view.component.html' }) export class FileViewComponent implements OnInit { @@ -33,6 +33,10 @@ export class FileViewComponent implements OnInit { private apiService: AlfrescoApiService) {} ngOnInit() { + this.route + .data + .subscribe(v => console.log(v)); + this.route.params.subscribe(params => { const id = params.nodeId; if (id) { diff --git a/demo-shell/src/app/components/activiti/apps-view.component.html b/demo-shell/src/app/components/process-service/apps-view.component.html similarity index 100% rename from demo-shell/src/app/components/activiti/apps-view.component.html rename to demo-shell/src/app/components/process-service/apps-view.component.html diff --git a/demo-shell/src/app/components/activiti/apps-view.component.ts b/demo-shell/src/app/components/process-service/apps-view.component.ts similarity index 93% rename from demo-shell/src/app/components/activiti/apps-view.component.ts rename to demo-shell/src/app/components/process-service/apps-view.component.ts index fcd2331524..9ea602b13b 100644 --- a/demo-shell/src/app/components/activiti/apps-view.component.ts +++ b/demo-shell/src/app/components/process-service/apps-view.component.ts @@ -20,10 +20,10 @@ import { Router } from '@angular/router'; import { AppDefinitionRepresentationModel } from '@alfresco/adf-process-services'; @Component({ - selector: 'activiti-apps-view', + selector: 'app-process-list-view', templateUrl: './apps-view.component.html' }) -export class ActivitiAppsViewComponent { +export class AppsViewComponent { constructor(private router: Router) { } diff --git a/demo-shell/src/app/components/activiti/custom-editor/custom-editor.component.ts b/demo-shell/src/app/components/process-service/custom-editor/custom-editor.component.ts similarity index 93% rename from demo-shell/src/app/components/activiti/custom-editor/custom-editor.component.ts rename to demo-shell/src/app/components/process-service/custom-editor/custom-editor.component.ts index bbe39dd559..830cba9850 100644 --- a/demo-shell/src/app/components/activiti/custom-editor/custom-editor.component.ts +++ b/demo-shell/src/app/components/process-service/custom-editor/custom-editor.component.ts @@ -35,7 +35,7 @@ export class CustomEditorComponent extends WidgetComponent { @Component({ selector: 'custom-stencil-01', - template: `
ADF version of custom Activiti stencil
` + template: `
ADF version of custom ProcessService stencil
` }) export class CustomStencil01 extends WidgetComponent { diff --git a/demo-shell/src/app/components/activiti/demo-field-validator.ts b/demo-shell/src/app/components/process-service/demo-field-validator.ts similarity index 100% rename from demo-shell/src/app/components/activiti/demo-field-validator.ts rename to demo-shell/src/app/components/process-service/demo-field-validator.ts diff --git a/demo-shell/src/app/components/activiti/form-node-viewer.component.css b/demo-shell/src/app/components/process-service/form-node-viewer.component.css similarity index 100% rename from demo-shell/src/app/components/activiti/form-node-viewer.component.css rename to demo-shell/src/app/components/process-service/form-node-viewer.component.css diff --git a/demo-shell/src/app/components/activiti/form-node-viewer.component.html b/demo-shell/src/app/components/process-service/form-node-viewer.component.html similarity index 100% rename from demo-shell/src/app/components/activiti/form-node-viewer.component.html rename to demo-shell/src/app/components/process-service/form-node-viewer.component.html diff --git a/demo-shell/src/app/components/activiti/form-node-viewer.component.ts b/demo-shell/src/app/components/process-service/form-node-viewer.component.ts similarity index 100% rename from demo-shell/src/app/components/activiti/form-node-viewer.component.ts rename to demo-shell/src/app/components/process-service/form-node-viewer.component.ts diff --git a/demo-shell/src/app/components/activiti/form-viewer.component.css b/demo-shell/src/app/components/process-service/form-viewer.component.css similarity index 100% rename from demo-shell/src/app/components/activiti/form-viewer.component.css rename to demo-shell/src/app/components/process-service/form-viewer.component.css diff --git a/demo-shell/src/app/components/activiti/form-viewer.component.html b/demo-shell/src/app/components/process-service/form-viewer.component.html similarity index 100% rename from demo-shell/src/app/components/activiti/form-viewer.component.html rename to demo-shell/src/app/components/process-service/form-viewer.component.html diff --git a/demo-shell/src/app/components/activiti/form-viewer.component.ts b/demo-shell/src/app/components/process-service/form-viewer.component.ts similarity index 97% rename from demo-shell/src/app/components/activiti/form-viewer.component.ts rename to demo-shell/src/app/components/process-service/form-viewer.component.ts index 3ecdf36d80..5fb3346fe0 100644 --- a/demo-shell/src/app/components/activiti/form-viewer.component.ts +++ b/demo-shell/src/app/components/process-service/form-viewer.component.ts @@ -20,7 +20,7 @@ import { ActivatedRoute } from '@angular/router'; import { Subscription } from 'rxjs/Rx'; @Component({ - selector: 'form-viewer', + selector: 'app-form-viewer', templateUrl: './form-viewer.component.html', styleUrls: ['./form-viewer.component.css'] }) diff --git a/demo-shell/src/app/components/activiti/activiti-process-attachments.component.css b/demo-shell/src/app/components/process-service/process-attachments.component.css similarity index 100% rename from demo-shell/src/app/components/activiti/activiti-process-attachments.component.css rename to demo-shell/src/app/components/process-service/process-attachments.component.css diff --git a/demo-shell/src/app/components/activiti/activiti-process-attachments.component.html b/demo-shell/src/app/components/process-service/process-attachments.component.html similarity index 76% rename from demo-shell/src/app/components/activiti/activiti-process-attachments.component.html rename to demo-shell/src/app/components/process-service/process-attachments.component.html index 40c432c332..484772dd41 100644 --- a/demo-shell/src/app/components/activiti/activiti-process-attachments.component.html +++ b/demo-shell/src/app/components/process-service/process-attachments.component.html @@ -1,21 +1,21 @@ -
+
Attachments
diff --git a/demo-shell/src/app/components/activiti/activiti-process-attachments.component.ts b/demo-shell/src/app/components/process-service/process-attachments.component.ts similarity index 82% rename from demo-shell/src/app/components/activiti/activiti-process-attachments.component.ts rename to demo-shell/src/app/components/process-service/process-attachments.component.ts index 8ff15ade3f..26a3baa9ab 100644 --- a/demo-shell/src/app/components/activiti/activiti-process-attachments.component.ts +++ b/demo-shell/src/app/components/process-service/process-attachments.component.ts @@ -21,18 +21,18 @@ import { ProcessInstance, ProcessService , import { UploadService } from '@alfresco/adf-core'; @Component({ - selector: 'activiti-process-attachments', - templateUrl: './activiti-process-attachments.component.html', - styleUrls: ['./activiti-process-attachments.component.css'], + selector: 'app-process-attachments', + templateUrl: './process-attachments.component.html', + styleUrls: ['./process-attachments.component.css'], providers: [ {provide: UploadService, useClass: ProcessUploadService} ] }) -export class ActivitiProcessAttachmentsComponent implements OnInit, OnChanges { +export class ProcessAttachmentsComponent implements OnInit, OnChanges { @Input() - processId: string; + processInstanceId: string; @ViewChild(ProcessAttachmentListComponent) processAttachList: ProcessAttachmentListComponent; @@ -50,8 +50,8 @@ export class ActivitiProcessAttachmentsComponent implements OnInit, OnChanges { } ngOnChanges() { - if (this.processId) { - this.processService.getProcess(this.processId).subscribe((processInstance: ProcessInstance) => { + if (this.processInstanceId) { + this.processService.getProcess(this.processInstanceId).subscribe((processInstance: ProcessInstance) => { this.processInstance = processInstance; }); } diff --git a/demo-shell/src/app/components/activiti/activiti.component.html b/demo-shell/src/app/components/process-service/process-service.component.html similarity index 76% rename from demo-shell/src/app/components/activiti/activiti.component.html rename to demo-shell/src/app/components/process-service/process-service.component.html index 2e51276ee8..81130280f0 100644 --- a/demo-shell/src/app/components/activiti/activiti.component.html +++ b/demo-shell/src/app/components/process-service/process-service.component.html @@ -1,10 +1,10 @@
-
-
-
- @@ -23,7 +23,7 @@
-
-
+
- - -
-
{{'ADF_TASK_LIST.ATTACHMENT.EMPTY.HEADER' | translate}}
-
-
{{'ADF_TASK_LIST.ATTACHMENT.EMPTY.DRAG-AND-DROP.TITLE' | translate}}
-
{{'ADF_TASK_LIST.ATTACHMENT.EMPTY.DRAG-AND-DROP.SUBTITLE' | translate}}
-
-
-
-
+
-
+
-
-
-
+
+
+
-
-
+
- - +
-
-
-
+
+
Report List

-
+
{ if (response) { let s = document.createElement('script'); diff --git a/demo-shell/src/app/components/activiti/activiti-show-diagram.component.css b/demo-shell/src/app/components/process-service/show-diagram.component.css similarity index 100% rename from demo-shell/src/app/components/activiti/activiti-show-diagram.component.css rename to demo-shell/src/app/components/process-service/show-diagram.component.css diff --git a/demo-shell/src/app/components/activiti/activiti-show-diagram.component.html b/demo-shell/src/app/components/process-service/show-diagram.component.html similarity index 100% rename from demo-shell/src/app/components/activiti/activiti-show-diagram.component.html rename to demo-shell/src/app/components/process-service/show-diagram.component.html diff --git a/demo-shell/src/app/components/activiti/activiti-show-diagram.component.ts b/demo-shell/src/app/components/process-service/show-diagram.component.ts similarity index 85% rename from demo-shell/src/app/components/activiti/activiti-show-diagram.component.ts rename to demo-shell/src/app/components/process-service/show-diagram.component.ts index 12cf2537e9..982eb9a818 100644 --- a/demo-shell/src/app/components/activiti/activiti-show-diagram.component.ts +++ b/demo-shell/src/app/components/process-service/show-diagram.component.ts @@ -19,11 +19,11 @@ import { Component } from '@angular/core'; import { ActivatedRoute, Router } from '@angular/router'; @Component({ - selector: 'activiti-show-diagram', - templateUrl: './activiti-show-diagram.component.html', - styleUrls: ['./activiti-show-diagram.component.css'] + selector: 'app-show-diagram', + templateUrl: './show-diagram.component.html', + styleUrls: ['./show-diagram.component.css'] }) -export class ActivitiShowDiagramComponent { +export class ShowDiagramComponent { processDefinitionId: string; appId: string; diff --git a/demo-shell/src/app/components/activiti/activiti-task-attachments.component.css b/demo-shell/src/app/components/process-service/task-attachments.component.css similarity index 100% rename from demo-shell/src/app/components/activiti/activiti-task-attachments.component.css rename to demo-shell/src/app/components/process-service/task-attachments.component.css diff --git a/demo-shell/src/app/components/process-service/task-attachments.component.html b/demo-shell/src/app/components/process-service/task-attachments.component.html new file mode 100644 index 0000000000..f77be75d7b --- /dev/null +++ b/demo-shell/src/app/components/process-service/task-attachments.component.html @@ -0,0 +1,39 @@ +
+
+ + + +
+
{{'ADF_TASK_LIST.ATTACHMENT.EMPTY.HEADER' | translate}}
+
+
{{'ADF_TASK_LIST.ATTACHMENT.EMPTY.DRAG-AND-DROP.TITLE' | translate}}
+
{{'ADF_TASK_LIST.ATTACHMENT.EMPTY.DRAG-AND-DROP.SUBTITLE' | translate}}
+
+
+
+ +
+ + + + + +
+
+ +
+ + +
diff --git a/demo-shell/src/app/components/activiti/activiti-task-attachments.component.ts b/demo-shell/src/app/components/process-service/task-attachments.component.ts similarity index 89% rename from demo-shell/src/app/components/activiti/activiti-task-attachments.component.ts rename to demo-shell/src/app/components/process-service/task-attachments.component.ts index 8582f80160..6e3694b7b9 100644 --- a/demo-shell/src/app/components/activiti/activiti-task-attachments.component.ts +++ b/demo-shell/src/app/components/process-service/task-attachments.component.ts @@ -20,15 +20,15 @@ import { ProcessUploadService, TaskListService, TaskAttachmentListComponent } fr import { UploadService } from '@alfresco/adf-core'; @Component({ - selector: 'activiti-task-attachments', - templateUrl: './activiti-task-attachments.component.html', - styleUrls: ['./activiti-task-attachments.component.css'], + selector: 'app-task-attachments', + templateUrl: './task-attachments.component.html', + styleUrls: ['./task-attachments.component.css'], providers: [ { provide: UploadService, useClass: ProcessUploadService } ] }) -export class ActivitiTaskAttachmentsComponent implements OnInit, OnChanges { +export class TaskAttachmentsComponent implements OnInit, OnChanges { @Input() taskId: string; diff --git a/demo-shell/src/app/services/in-memory-form.service.ts b/demo-shell/src/app/services/in-memory-form.service.ts index 9456e832fd..fdf6857943 100644 --- a/demo-shell/src/app/services/in-memory-form.service.ts +++ b/demo-shell/src/app/services/in-memory-form.service.ts @@ -22,7 +22,7 @@ import { AppConfigService, AlfrescoApiService, EcmModelService, LogService, import { Observable } from 'rxjs/Observable'; import { Subject } from 'rxjs/Subject'; -interface ActivitiData { +interface ProcessServiceData { rest: { fields: Array<{ processId?: string, @@ -39,7 +39,7 @@ interface ActivitiData { @Injectable() export class InMemoryFormService extends FormService { - private data: ActivitiData; + private data: ProcessServiceData; executeOutcome = new Subject(); @@ -48,7 +48,7 @@ export class InMemoryFormService extends FormService { apiService: AlfrescoApiService, protected logService: LogService) { super(ecmModelService, apiService, logService); - this.data = appConfig.get('activiti'); + this.data = appConfig.get('activiti'); } /** @override */ diff --git a/demo-shell/tslint.json b/demo-shell/tslint.json index a4886b4596..7e834c0ab2 100644 --- a/demo-shell/tslint.json +++ b/demo-shell/tslint.json @@ -100,7 +100,7 @@ ], "directive-selector": [true, "attribute", "app", "camelCase"], - "component-selector": [true, "element", "adf", "kebab-case"], + "component-selector": [true, "element", "app", "kebab-case"], "use-input-property-decorator": true, "use-output-property-decorator": true, "use-host-property-decorator": true,