Source Mapping is not working on test debugging (#1931)

* coverage single components run fix

* remove spec.ts from coverage

* make the coverage and the istanbul-instrumenter-loader works only over the console test because a problem on the remapping for the browser test

* move tslint on the main folder of any component

* remove build:w from readme

* stop build tslint error also in spec files

* clear karma file from unnecessary files

* add set -f for build all script in order to accept *

* fix lint problem and failing tests

* fix failing test search component

* add loader test for viewer

* fix tslint error userinfo

* --max_old_space_size=2048 remove

* fix tslint error uploader unused EventEmitter

* remove spec|index|.*mock|.*model|.*event from coverage

ng2-components/ng2-alfresco-webscript/README.md

@@ -294,12 +294,6 @@ npm install
 npm run build
 ```
 
-### Build the files and keep watching for changes
-
-```sh
-$ npm run build:w
-```
-
 ## Running unit tests
 
 ```sh

ng2-components/ng2-alfresco-webscript/config/webpack.build.js

@@ -0,0 +1,35 @@
+const webpack = require('webpack');
+const webpackMerge = require('webpack-merge');
+const commonConfig = require('./webpack.common.js');
+
+module.exports = webpackMerge(commonConfig, {
+
+    devtool: 'cheap-module-source-map',
+
+    externals: [
+        /^\@angular\//,
+        /^rxjs\//,
+        'moment',
+        'raphael',
+        'ng2-charts',
+        'alfresco-js-api',
+        'ng2-alfresco-core',
+        'ng2-alfresco-datatable',
+        'ng2-activiti-analytics',
+        'ng2-activiti-diagrams',
+        'ng2-activiti-form',
+        "ng2-activiti-tasklist",
+        'ng2-alfresco-documentlist'
+    ],
+
+    output: {
+        filename: './bundles/[name].js',
+        library: '[name]',
+        libraryTarget: 'umd',
+        chunkFilename: '[id].chunk.js'
+    },
+
+    entry: {
+        "ng2-alfresco-webscript": "./index.ts"
+    }
+});

ng2-components/ng2-alfresco-webscript/config/webpack.common.js

@@ -4,6 +4,8 @@ const fs = require('fs');
 const path = require('path');
 const CopyWebpackPlugin = require('copy-webpack-plugin');
 
+const ENV = process.env.NODE_ENV = process.env.ENV = 'production';
+
 module.exports = {
 
     resolveLoader: {
@@ -13,22 +15,15 @@ module.exports = {
         }
     },
 
-    // require those dependencies but don't bundle them
-    externals: [
-        /^\@angular\//,
-        /^rxjs\//,
-        'moment',
-        'raphael',
-        'ng2-charts',
-        'alfresco-js-api',
-        'ng2-alfresco-core',
-        'ng2-alfresco-datatable',
-        'ng2-activiti-analytics',
-        'ng2-activiti-diagrams',
-        'ng2-activiti-form',
-        "ng2-activiti-tasklist",
-        'ng2-alfresco-documentlist'
-    ],
+    resolve: {
+        alias: {
+            "ng2-alfresco-core": helpers.root('../ng2-alfresco-core/index.ts'),
+            "ng2-alfresco-datatable": helpers.root('../ng2-alfresco-datatable/index.ts')
+        },
+        extensions: ['.ts', '.js'],
+        symlinks: false,
+        modules: [helpers.root('../../ng2-components'), helpers.root('node_modules')]
+    },
 
     module: {
         rules: [
@@ -38,19 +33,13 @@ module.exports = {
                 loader: 'source-map-loader',
                 exclude: [/node_modules/, /bundles/, /dist/, /demo/]
             },
-            {
-                enforce: 'pre',
-                test: /\.ts$/,
-                use: 'source-map-loader',
-                exclude: [/node_modules/, /bundles/, /dist/, /demo/]
-            },
             {
                 enforce: 'pre',
                 test: /\.ts$/,
                 loader: 'tslint-loader',
                 options: {
                     emitErrors: true,
-                    configFile: path.resolve(__dirname, './assets/tslint.json')
+                    failOnHint: true
                 },
                 exclude: [/node_modules/, /bundles/, /dist/, /demo/]
             },
@@ -102,18 +91,10 @@ module.exports = {
         ]
     },
 
-    resolve: {
-        extensions: ['.ts', '.js'],
-        symlinks: false,
-        modules: [
-            '../ng2-components', 'node_modules'
-        ]
-    },
-
     plugins: [
         new CopyWebpackPlugin([{
             from: `src/i18n/`,
-            to: `bundles/assets/ng2-alfresco-webscript/i18n/`
+            to: `bundles/assets/ng2-alfresco-tag/i18n/`
         }]),
 
         new webpack.NoEmitOnErrorsPlugin(),
@@ -124,11 +105,19 @@ module.exports = {
             /angular(\\|\/)core(\\|\/)@angular/,
             helpers.root('./src'),
             {}
-        )
+        ),
+        new webpack.DefinePlugin({
+            'process.env': {
+                'ENV': JSON.stringify(ENV)
+            }
+        }),
+        new webpack.LoaderOptionsPlugin({
+                htmlLoader: {
+                    minimize: false // workaround for ng2
+                }
+        })
     ],
 
-    devtool: 'cheap-module-source-map',
-
     node: {
         fs: 'empty',
         module: false

ng2-components/ng2-alfresco-webscript/config/webpack.coverage.js

@@ -0,0 +1,22 @@
+const webpack = require('webpack');
+const webpackMerge = require('webpack-merge');
+const testConfig = require('./webpack.test.js');
+const helpers = require('./helpers');
+
+module.exports = webpackMerge(testConfig, {
+
+    module: {
+        rules: [
+            {
+                enforce: 'post',
+                test: /^?!(.*spec|index|.*mock|.*model|.*event).*\.ts?$/,
+                include: [helpers.root('src')],
+                loader: 'istanbul-instrumenter-loader',
+                exclude: [
+                    /node_modules/,
+                    /test/
+                ]
+            }
+        ]
+    }
+});

ng2-components/ng2-alfresco-webscript/config/webpack.test.js

@@ -1,90 +1,8 @@
-const webpack = require('webpack');
 const helpers = require('./helpers');
+const webpackMerge = require('webpack-merge');
+const commonConfig = require('./webpack.common.js');
 
-const ENV = process.env.NODE_ENV = process.env.ENV = 'production';
+module.exports = webpackMerge(commonConfig, {
 
-module.exports = {
-
-    devtool: 'inline-source-map',
-
-    resolve: {
-        extensions: ['.ts', '.js'],
-        symlinks: false,
-        modules: [helpers.root('../ng2-components'), helpers.root('node_modules')]
-    },
-
-    module: {
-        rules: [
-            {
-                enforce: 'pre',
-                test: /\.js$/,
-                loader: 'source-map-loader',
-                exclude: [/node_modules/, /bundles/, /dist/, /demo/]
-            },
-            {
-                test: /\.ts$/,
-                loaders: ['ts-loader?' + JSON.stringify({ transpileOnly: true}), 'angular2-template-loader'],
-                exclude: [/node_modules/, /bundles/, /dist/, /demo/]
-            },
-            {
-                test: /\.html$/,
-                loader: 'html-loader',
-                exclude: [/node_modules/, /bundles/, /dist/, /demo/]
-            },
-            {
-                test: /\.css$/,
-                loader: ['to-string-loader', 'css-loader'],
-                exclude: [/node_modules/, /bundles/, /dist/, /demo/]
-            },
-            {
-                test: /\.component.scss$/,
-                use: ['to-string-loader', 'raw-loader', 'sass-loader'],
-                exclude: [/node_modules/, /bundles/, /dist/, /demo/]
-            },
-            {
-                test: /\.(png|jpe?g|gif|svg|woff|woff2|ttf|eot|ico|pdf)$/,
-                loader: 'file-loader',
-                query: {
-                    name: '[path][name].[ext]',
-                    outputPath: (url)=> {
-                        return url.replace('src', 'dist');
-                    }
-                }
-            },
-            {
-                enforce: 'post',
-                test: /\.ts$/,
-                loader: 'istanbul-instrumenter-loader',
-                exclude: [
-                    /node_modules/,
-                    /test/
-                ]
-            }
-        ]
-    },
-
-    plugins: [
-        new webpack.NoEmitOnErrorsPlugin(),
-
-        new webpack.ContextReplacementPlugin(
-            /angular(\\|\/)core(\\|\/)@angular/,
-            helpers.root('./src'),
-            {}
-        ),
-        new webpack.DefinePlugin({
-            'process.env': {
-                'ENV': JSON.stringify(ENV)
-            }
-        }),
-        new webpack.LoaderOptionsPlugin({
-                htmlLoader: {
-                    minimize: false // workaround for ng2
-                }
-        })
-    ],
-
-    node: {
-        fs: 'empty',
-        module: false
-    }
-};
+    devtool: 'inline-source-map'
+});

ng2-components/ng2-alfresco-webscript/karma.conf.js

@@ -8,6 +8,7 @@ module.exports = function (config) {
 
     files: [
       './node_modules/hammerjs/hammer.js',
+      {pattern: './node_modules/@angular/material/prebuilt-themes/indigo-pink.css', included: true, watched: false},
 
       //diagrams
       './node_modules/chart.js/dist/Chart.js',
@@ -27,7 +28,7 @@ module.exports = function (config) {
       {pattern: './src/**/*.ts', included: false, served: true, watched: false}
     ],
 
-    webpack: webpackConfig,
+    webpack: (config.mode === 'coverage') ? require('./webpack.coverage') : require('./webpack.test'),
 
     webpackMiddleware: {
       stats: 'errors-only'

ng2-components/ng2-alfresco-webscript/package.json

@@ -7,7 +7,7 @@
     "clean": "rimraf dist node_modules typings bundles coverage .npmrc",
     "rimraf": "rimraf",
     "build": "webpack --config webpack.build.js --progress --profile --bail",
-    "test": "karma start karma.conf.js --reporters mocha,coverage --single-run --component",
+    "test": "karma start karma.conf.js --reporters mocha,coverage --single-run --mode coverage",
     "test-browser": "karma start karma.conf.js --reporters kjhtml --component",
     "coverage": "npm run test && wsrv -o -p 9875 ./coverage/report",
     "prepublish" : "npm run build"

ng2-components/ng2-alfresco-webscript/webpack.build.js

@@ -1,17 +1 @@
-const webpack = require('webpack');
-const webpackMerge = require('webpack-merge');
-const commonConfig = require('./config/webpack.common.js');
-
-module.exports = webpackMerge(commonConfig, {
-
-    output: {
-        filename: './bundles/[name].js',
-        library: '[name]',
-        libraryTarget: 'umd',
-        chunkFilename: '[id].chunk.js'
-    },
-
-    entry: {
-        "ng2-alfresco-webscript": "./index.ts"
-    }
-});
+module.exports = require('./config/webpack.build.js');

ng2-components/ng2-alfresco-webscript/webpack.coverage.js

@@ -0,0 +1 @@
+module.exports = require('./config/webpack.coverage.js');

ng2-components/ng2-alfresco-webscript/webpack.test.js

@@ -1,8 +1 @@
-const webpack = require('webpack');
-const webpackMerge = require('webpack-merge');
-const testConfig = require('./config/webpack.test.js');
-
-module.exports = webpackMerge(testConfig, {
-
-
-});
+module.exports = require('./config/webpack.test.js');