inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix eslint warnigs for core project (#7506)

Browse Source
This commit is contained in:
Denys Vuika
2022-02-17 14:35:33 +00:00
committed by GitHub
parent 5b7f255eec
commit bca5a783ab
246 changed files with 5127 additions and 5065 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/datatable/data/data-table.schema.ts
View File

@@ -67,7 +67,7 @@ export abstract class DataTableSchema {
public getSchemaFromHtml(columnList: DataColumnListComponent): any {
let schema = [];
if (columnList && columnList.columns && columnList.columns.length > 0) {
schema = columnList.columns.map((c) => <DataColumn> c);
schema = columnList.columns.map((c) => c as DataColumn);
}
return schema;
}

2
lib/core/datatable/data/datatable-adapter.ts
View File

@@ -28,7 +28,7 @@ export interface DataTableAdapter {
setRows(rows: Array<DataRow>): void;
getColumns(): Array<DataColumn>;
setColumns(columns: Array<DataColumn>): void;
getValue(row: DataRow, col: DataColumn, resolverFn?: (row: DataRow, col: DataColumn) => any): any;
getValue(row: DataRow, col: DataColumn, resolverFn?: (_row: DataRow, _col: DataColumn) => any): any;
getSorting(): DataSorting;
setSorting(sorting: DataSorting): void;
sort(key?: string, direction?: string): void;

32
lib/core/datatable/data/object-datatable-adapter.spec.ts
View File

@@ -47,8 +47,8 @@ describe('ObjectDataTableAdapter', () => {
it('should map columns without rows', () => {
const adapter = new ObjectDataTableAdapter(null, [
<DataColumn> {},
<DataColumn> {}
{} as DataColumn,
{} as DataColumn
]);
const columns = adapter.getColumns();
@@ -64,10 +64,7 @@ describe('ObjectDataTableAdapter', () => {
it('should apply new rows array', () => {
const adapter = new ObjectDataTableAdapter([], []);
const newRows = [
<DataRow> {},
<DataRow> {}
];
const newRows = [{}, {}] as DataRow[];
adapter.setRows(newRows);
expect(adapter.getRows()).toBe(newRows);
@@ -102,10 +99,7 @@ describe('ObjectDataTableAdapter', () => {
it('should apply new columns array', () => {
const adapter = new ObjectDataTableAdapter([], []);
const columns = [
<DataColumn> {},
<DataColumn> {}
];
const columns = [{},{}] as DataColumn[];
adapter.setColumns(columns);
expect(adapter.getColumns()).toBe(columns);
@@ -123,8 +117,8 @@ describe('ObjectDataTableAdapter', () => {
it('should reset columns by null value', () => {
const adapter = new ObjectDataTableAdapter([], [
<DataColumn> {},
<DataColumn> {}
{} as DataColumn,
{} as DataColumn
]);
expect(adapter.getColumns()).toBeDefined();
expect(adapter.getColumns().length).toBe(2);
@@ -144,7 +138,7 @@ describe('ObjectDataTableAdapter', () => {
it('should fail getting value with column not defined', () => {
const adapter = new ObjectDataTableAdapter([], []);
expect(() => {
adapter.getValue(<DataRow> {}, null);
adapter.getValue({} as DataRow, null);
}).toThrowError('Column not found');
});
@@ -155,7 +149,7 @@ describe('ObjectDataTableAdapter', () => {
row.getValue.and.returnValue(value);
const adapter = new ObjectDataTableAdapter([], []);
const result = adapter.getValue(row, <DataColumn> { key: 'col1' });
const result = adapter.getValue(row, { key: 'col1' } as DataColumn);
expect(row.getValue).toHaveBeenCalledWith('col1');
expect(result).toBe(value);
@@ -206,7 +200,7 @@ describe('ObjectDataTableAdapter', () => {
it('should take first sortable column by default', () => {
const adapter = new ObjectDataTableAdapter([], [
<DataColumn> { key: 'icon' },
{ key: 'icon' } as DataColumn,
new ObjectDataColumn({ key: 'id', sortable: true })
]);
@@ -225,8 +219,8 @@ describe('ObjectDataTableAdapter', () => {
{ id: 2, created: new Date(2016, 7, 6, 15, 7, 1) }
],
[
<DataColumn> { key: 'id' },
<DataColumn> { key: 'created' }
{ key: 'id' } as DataColumn,
{ key: 'created' } as DataColumn
]
);
@@ -304,9 +298,7 @@ describe('ObjectDataTableAdapter', () => {
describe('ObjectDataRow', () => {
it('should require object source', () => {
expect(() => {
return new ObjectDataRow(null);
}).toThrowError('Object source not found');
expect(() => new ObjectDataRow(null)).toThrowError('Object source not found');
});
it('should get top level property value', () => {

12
lib/core/datatable/data/object-datatable-adapter.ts
View File

@@ -44,7 +44,7 @@ export class ObjectDataTableAdapter implements DataTableAdapter {
if (rowToExaminate.hasOwnProperty(key)) {
schema.push({
type: 'text',
key: key,
key,
title: key,
sortable: false
});
@@ -61,15 +61,11 @@ export class ObjectDataTableAdapter implements DataTableAdapter {
this._columns = [];
if (data && data.length > 0) {
this._rows = data.map((item) => {
return new ObjectDataRow(item);
});
this._rows = data.map((item) => new ObjectDataRow(item));
}
if (schema && schema.length > 0) {
this._columns = schema.map((item) => {
return new ObjectDataColumn(item);
});
this._columns = schema.map((item) => new ObjectDataColumn(item));
// Sort by first sortable or just first column
const sortable = this._columns.filter((column) => column.sortable);
@@ -99,7 +95,7 @@ export class ObjectDataTableAdapter implements DataTableAdapter {
this._columns = columns || [];
}
getValue(row: DataRow, col: DataColumn, resolver?: (row: DataRow, col: DataColumn) => any ): any {
getValue(row: DataRow, col: DataColumn, resolver?: (_row: DataRow, _col: DataColumn) => any ): any {
if (!row) {
throw new Error('Row not found');
}