inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix eslint warnigs for core project (#7506)

Browse Source
This commit is contained in:
Denys Vuika
2022-02-17 14:35:33 +00:00
committed by GitHub
parent 5b7f255eec
commit bca5a783ab
246 changed files with 5127 additions and 5065 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/core/viewer/components/img-viewer.component.spec.ts
View File

@@ -31,10 +31,10 @@ describe('Test Img viewer component ', () => {
let fixture: ComponentFixture<ImgViewerComponent>;
let element: HTMLElement;
function createFakeBlob() {
const createFakeBlob = () => {
const data = atob('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==');
return new Blob([data], { type: 'image/png' });
}
};
setupTestBed({
imports: [
@@ -86,7 +86,7 @@ describe('Test Img viewer component ', () => {
it('If no url or blob are passed should thrown an error', () => {
const change = new SimpleChange(null, null, true);
expect(() => {
component.ngOnChanges({ 'blobFile': change });
component.ngOnChanges({ blobFile: change });
}).toThrow(new Error('Attribute urlFile or blobFile is required'));
});
@@ -109,7 +109,7 @@ describe('Test Img viewer component ', () => {
spyOn(service, 'createTrustedUrl').and.returnValue('fake-blob-url');
const change = new SimpleChange(null, blob, true);
expect(() => {
component.ngOnChanges({ 'blobFile': change });
component.ngOnChanges({ blobFile: change });
}).not.toThrow(new Error('Attribute urlFile or blobFile is required'));
expect(component.urlFile).toEqual('fake-blob-url');
});
@@ -163,7 +163,7 @@ describe('Test Img viewer component ', () => {
component = fixture.componentInstance;
component.blobFile = createFakeBlob();
const change = new SimpleChange(null, component.blobFile, true);
component.ngOnChanges({ 'blobFile': change });
component.ngOnChanges({ blobFile: change });
fixture.detectChanges();
});

2
lib/core/viewer/components/img-viewer.component.ts
View File

@@ -33,7 +33,7 @@ import Cropper from 'cropperjs';
selector: 'adf-img-viewer',
templateUrl: './img-viewer.component.html',
styleUrls: ['./img-viewer.component.scss'],
host: { 'class': 'adf-image-viewer' },
host: { class: 'adf-image-viewer' },
encapsulation: ViewEncapsulation.None
})
export class ImgViewerComponent implements AfterViewInit, OnChanges, OnDestroy {

2
lib/core/viewer/components/media-player.component.ts
View File

@@ -24,7 +24,7 @@ import { ViewUtilService } from '../services/view-util.service';
selector: 'adf-media-player',
templateUrl: './media-player.component.html',
styleUrls: ['./media-player.component.scss'],
host: { 'class': 'adf-media-player' },
host: { class: 'adf-media-player' },
encapsulation: ViewEncapsulation.None
})
export class MediaPlayerComponent implements OnChanges {

2
lib/core/viewer/components/pdf-viewer-thumb.component.ts
View File

@@ -51,7 +51,7 @@ export class PdfThumbComponent implements OnInit, FocusableOption {
return page.render({
canvasContext: canvas.getContext('2d'),
viewport: page.getViewport({ scale: scale })
viewport: page.getViewport({ scale })
}).promise.then(() => {
const imageSource = canvas.toDataURL();
return this.sanitizer.bypassSecurityTrustUrl(imageSource);

22
lib/core/viewer/components/pdf-viewer-thumbnails.component.spec.ts
View File

@@ -30,12 +30,10 @@ describe('PdfThumbListComponent', () => {
let fixture: ComponentFixture<PdfThumbListComponent>;
let component: PdfThumbListComponent;
const page = (id) => {
return {
id,
getPage: Promise.resolve()
};
};
const page = (id) => ({
id,
getPage: Promise.resolve()
});
const viewerMock = {
_currentPageNumber: null,
@@ -90,6 +88,7 @@ describe('PdfThumbListComponent', () => {
fixture.detectChanges();
const renderedIds = component.renderItems.map((item) => item.id);
// eslint-disable-next-line no-underscore-dangle
const rangeIds = viewerMock._pages.slice(0, 6).map((item) => item.id);
expect(renderedIds).toEqual(rangeIds);
@@ -101,6 +100,7 @@ describe('PdfThumbListComponent', () => {
fixture.detectChanges();
const renderedIds = component.renderItems.map((item) => item.id);
// eslint-disable-next-line no-underscore-dangle
const rangeIds = viewerMock._pages.slice(5, 12).map((item) => item.id);
expect(renderedIds).toEqual(rangeIds);
@@ -175,7 +175,7 @@ describe('PdfThumbListComponent', () => {
describe('Keyboard events', () => {
it('should select next page in the list on DOWN_ARROW event', () => {
const event = new KeyboardEvent('keydown', {'keyCode': DOWN_ARROW} as KeyboardEventInit);
const event = new KeyboardEvent('keydown', {keyCode: DOWN_ARROW} as KeyboardEventInit);
fixture.detectChanges();
component.goTo(1);
expect(document.activeElement.id).toBe('1');
@@ -185,7 +185,7 @@ describe('PdfThumbListComponent', () => {
});
it('should select previous page in the list on UP_ARROW event', () => {
const event = new KeyboardEvent('keydown', {'keyCode': UP_ARROW} as KeyboardEventInit);
const event = new KeyboardEvent('keydown', {keyCode: UP_ARROW} as KeyboardEventInit);
fixture.detectChanges();
component.goTo(2);
expect(document.activeElement.id).toBe('2');
@@ -195,7 +195,7 @@ describe('PdfThumbListComponent', () => {
});
it('should not select previous page if it is the first page', () => {
const event = new KeyboardEvent('keydown', {'keyCode': UP_ARROW} as KeyboardEventInit);
const event = new KeyboardEvent('keydown', {keyCode: UP_ARROW} as KeyboardEventInit);
fixture.detectChanges();
component.goTo(1);
expect(document.activeElement.id).toBe('1');
@@ -205,7 +205,7 @@ describe('PdfThumbListComponent', () => {
});
it('should not select next item if it is the last page', () => {
const event = new KeyboardEvent('keydown', {'keyCode': DOWN_ARROW} as KeyboardEventInit);
const event = new KeyboardEvent('keydown', {keyCode: DOWN_ARROW} as KeyboardEventInit);
fixture.detectChanges();
component.scrollInto(16);
fixture.detectChanges();
@@ -218,7 +218,7 @@ describe('PdfThumbListComponent', () => {
});
it('should emit on ESCAPE event', () => {
const event = new KeyboardEvent('keydown', {'keyCode': ESCAPE} as KeyboardEventInit);
const event = new KeyboardEvent('keydown', {keyCode: ESCAPE} as KeyboardEventInit);
spyOn(component.close, 'emit');
fixture.detectChanges();

11
lib/core/viewer/components/pdf-viewer-thumbnails.component.ts
View File

@@ -36,7 +36,7 @@ export class PdfThumbListComponent implements OnInit, AfterViewInit, OnDestroy {
@Input() pdfViewer: any;
@Output()
close: EventEmitter<any> = new EventEmitter<void>();
close = new EventEmitter<void>();
virtualHeight: number = 0;
translateY: number = 0;
@@ -149,14 +149,11 @@ export class PdfThumbListComponent implements OnInit, AfterViewInit, OnDestroy {
}
getPages() {
// eslint-disable-next-line no-underscore-dangle
return this.pdfViewer._pages.map((page) => ({
id: page.id,
getWidth: () => {
return this.width;
},
getHeight: () => {
return this.currentHeight;
},
getWidth: () => this.width,
getHeight: () => this.currentHeight,
getPage: () => this.pdfViewer.pdfDocument.getPage(page.id)
}));
}

18
lib/core/viewer/components/pdf-viewer.component.spec.ts
View File

@@ -173,7 +173,7 @@ describe('Test PdfViewer component', () => {
change = new SimpleChange(null, null, true);
expect(() => {
component.ngOnChanges({ 'urlFile': change });
component.ngOnChanges({ urlFile: change });
}).toThrow(new Error('Attribute urlFile or blobFile is required'));
});
@@ -181,7 +181,7 @@ describe('Test PdfViewer component', () => {
change = new SimpleChange(null, null, true);
expect(() => {
component.ngOnChanges({ 'blobFile': change });
component.ngOnChanges({ blobFile: change });
}).toThrow(new Error('Attribute urlFile or blobFile is required'));
});
});
@@ -398,14 +398,12 @@ describe('Test PdfViewer component', () => {
fixtureUrlTestPasswordComponent = TestBed.createComponent(UrlTestPasswordComponent);
componentUrlTestPasswordComponent = fixtureUrlTestPasswordComponent.componentInstance;
spyOn(dialog, 'open').and.callFake(() => {
return {
afterClosed: () => {
done();
return of('');
}
} as any;
});
spyOn(dialog, 'open').and.callFake(() => ({
afterClosed: () => {
done();
return of('');
}
} as any));
spyOn(componentUrlTestPasswordComponent.pdfViewerComponent.close, 'emit');

11
lib/core/viewer/components/pdf-viewer.component.ts
View File

@@ -48,7 +48,7 @@ declare const pdfjsViewer: any;
templateUrl: './pdf-viewer.component.html',
styleUrls: ['./pdf-viewer-host.component.scss', './pdf-viewer.component.scss'],
providers: [RenderingQueueServices],
host: { 'class': 'adf-pdf-viewer' },
host: { class: 'adf-pdf-viewer' },
encapsulation: ViewEncapsulation.None
})
export class PdfViewerComponent implements OnChanges, OnDestroy {
@@ -215,8 +215,8 @@ export class PdfViewerComponent implements OnChanges, OnDestroy {
if (viewer && container) {
this.pdfViewer = new pdfjsViewer.PDFViewer({
container: container,
viewer: viewer,
container,
viewer,
renderingQueue: this.renderingQueueServices,
eventBus: this.eventBus
});
@@ -364,7 +364,7 @@ export class PdfViewerComponent implements OnChanges, OnDestroy {
if (!this.isSameScale(this.currentScale, newScale)) {
this.currentScale = newScale;
this.pdfViewer._pages.forEach(function(currentPage) {
this.pdfViewer._pages.forEach((currentPage) => {
currentPage.update(newScale);
});
}
@@ -530,6 +530,7 @@ export class PdfViewerComponent implements OnChanges, OnDestroy {
/**
* Keyboard Event Listener
*
* @param KeyboardEvent event
*/
@HostListener('document:keydown', ['$event'])
@@ -543,7 +544,7 @@ export class PdfViewerComponent implements OnChanges, OnDestroy {
}
private generateUuid() {
return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {
return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, (c) => {
const r = Math.random() * 16 | 0;
const v = c === 'x' ? r : (r & 0x3 | 0x8);
return v.toString(16);

4
lib/core/viewer/components/txt-viewer.component.spec.ts
View File

@@ -49,7 +49,7 @@ describe('Text View component', () => {
const urlFile = './fake-test-file.txt';
const change = new SimpleChange(null, urlFile, true);
component.ngOnChanges({ 'urlFile': change }).then(() => {
component.ngOnChanges({ urlFile: change }).then(() => {
fixture.detectChanges();
fixture.whenStable().then(() => {
expect(element.querySelector('.adf-txt-viewer-content').textContent).toContain('example');
@@ -63,7 +63,7 @@ describe('Text View component', () => {
const change = new SimpleChange(null, blobFile, true);
component.ngOnChanges({ 'blobFile': change }).then(() => {
component.ngOnChanges({ blobFile: change }).then(() => {
fixture.detectChanges();
fixture.whenStable().then(() => {
expect(element.querySelector('.adf-txt-viewer-content').textContent).toContain('example');

2
lib/core/viewer/components/txt-viewer.component.ts
View File

@@ -23,7 +23,7 @@ import { AppConfigService } from './../../app-config/app-config.service';
selector: 'adf-txt-viewer',
templateUrl: './txt-viewer.component.html',
styleUrls: ['./txt-viewer.component.scss'],
host: { 'class': 'adf-txt-viewer' },
host: { class: 'adf-txt-viewer' },
encapsulation: ViewEncapsulation.None
})
export class TxtViewerComponent implements OnChanges {

10
lib/core/viewer/components/viewer.component.spec.ts
View File

@@ -156,9 +156,7 @@ describe('ViewerComponent', () => {
providers: [
{
provide: RenditionsService, useValue: {
getRendition: () => {
return throwError('thrown');
}
getRendition: () => throwError('thrown')
}
},
RenderingQueueServices,
@@ -560,15 +558,15 @@ describe('ViewerComponent', () => {
expect(component.fileTitle).toBe('file1');
alfrescoApiService.nodeUpdated.next(<any> { id: 'id1', name: 'file2' });
alfrescoApiService.nodeUpdated.next({ id: 'id1', name: 'file2' } as any);
fixture.detectChanges();
expect(component.fileTitle).toBe('file2');
alfrescoApiService.nodeUpdated.next(<any> { id: 'id1', name: 'file3' });
alfrescoApiService.nodeUpdated.next({ id: 'id1', name: 'file3' } as any);
fixture.detectChanges();
expect(component.fileTitle).toBe('file3');
alfrescoApiService.nodeUpdated.next(<any> { id: 'id2', name: 'file4' });
alfrescoApiService.nodeUpdated.next({ id: 'id2', name: 'file4' } as any);
fixture.detectChanges();
expect(component.fileTitle).toBe('file3');
expect(component.nodeId).toBe('id1');

13
lib/core/viewer/components/viewer.component.ts
View File

@@ -49,7 +49,7 @@ import { FileModel } from '../../models';
selector: 'adf-viewer',
templateUrl: './viewer.component.html',
styleUrls: ['./viewer.component.scss'],
host: { 'class': 'adf-viewer' },
host: { class: 'adf-viewer' },
encapsulation: ViewEncapsulation.None
})
export class ViewerComponent implements OnChanges, OnInit, OnDestroy {
@@ -320,11 +320,9 @@ export class ViewerComponent implements OnChanges, OnInit, OnDestroy {
ngOnInit() {
this.apiService.nodeUpdated.pipe(
filter((node) => {
return node && node.id === this.nodeId &&
filter((node) => node && node.id === this.nodeId &&
(node.name !== this.fileName ||
this.getNodeVersionProperty(this.nodeEntry.entry) !== this.getNodeVersionProperty(node));
}),
this.getNodeVersionProperty(this.nodeEntry.entry) !== this.getNodeVersionProperty(node))),
takeUntil(this.onDestroy$)
).subscribe((node) => this.onNodeUpdated(node));
@@ -739,11 +737,8 @@ export class ViewerComponent implements OnChanges, OnInit, OnDestroy {
if (typeof extensionAllowed === 'string') {
return this.extension.toLowerCase() === extensionAllowed.toLowerCase();
} else if (extensionAllowed.length > 0) {
return extensionAllowed.find((currentExtension) => {
return this.extension.toLowerCase() === currentExtension.toLowerCase();
});
return extensionAllowed.find((currentExtension) => this.extension.toLowerCase() === currentExtension.toLowerCase());
}
}
onSubmitFile(newImageBlob: Blob) {