From bd4ee6a69565dafe7bd21827d030856c03b788ff Mon Sep 17 00:00:00 2001 From: VitoAlbano Date: Sat, 22 Jun 2024 23:31:04 +0100 Subject: [PATCH] Fixing unit test --- .../src/lib/directives/library-favorite.directive.spec.ts | 3 +-- .../about/about-github-link/about-github-link.component.html | 0 .../about-github-link/about-github-link.component.spec.ts | 0 .../about-server-settings.component.spec.ts | 1 - lib/core/src/lib/auth/mock/authentication.service.mock.ts | 4 ++++ lib/core/src/lib/testing/core.testing.module.ts | 4 ++-- 6 files changed, 7 insertions(+), 5 deletions(-) delete mode 100644 lib/core/src/lib/about/about-github-link/about-github-link.component.html delete mode 100644 lib/core/src/lib/about/about-github-link/about-github-link.component.spec.ts diff --git a/lib/content-services/src/lib/directives/library-favorite.directive.spec.ts b/lib/content-services/src/lib/directives/library-favorite.directive.spec.ts index 8fe872cd7d..18787b54ba 100644 --- a/lib/content-services/src/lib/directives/library-favorite.directive.spec.ts +++ b/lib/content-services/src/lib/directives/library-favorite.directive.spec.ts @@ -41,8 +41,7 @@ describe('LibraryFavoriteDirective', () => { beforeEach(() => { TestBed.configureTestingModule({ - imports: [HttpClientTestingModule, TestComponent], - declarations: [LibraryFavoriteDirective] + imports: [HttpClientTestingModule, TestComponent, LibraryFavoriteDirective] }); fixture = TestBed.createComponent(TestComponent); component = fixture.componentInstance; diff --git a/lib/core/src/lib/about/about-github-link/about-github-link.component.html b/lib/core/src/lib/about/about-github-link/about-github-link.component.html deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/lib/core/src/lib/about/about-github-link/about-github-link.component.spec.ts b/lib/core/src/lib/about/about-github-link/about-github-link.component.spec.ts deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/lib/core/src/lib/about/about-server-settings/about-server-settings.component.spec.ts b/lib/core/src/lib/about/about-server-settings/about-server-settings.component.spec.ts index df7e926221..27fc2ad32f 100644 --- a/lib/core/src/lib/about/about-server-settings/about-server-settings.component.spec.ts +++ b/lib/core/src/lib/about/about-server-settings/about-server-settings.component.spec.ts @@ -18,7 +18,6 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { AboutServerSettingsComponent } from './about-server-settings.component'; import { AppConfigService } from '../../app-config/app-config.service'; -import { aboutGithubDetails } from '../about.mock'; import { TranslateModule } from '@ngx-translate/core'; import { HttpClientTestingModule } from '@angular/common/http/testing'; import { AppConfigServiceMock } from '../../common'; diff --git a/lib/core/src/lib/auth/mock/authentication.service.mock.ts b/lib/core/src/lib/auth/mock/authentication.service.mock.ts index efcce4448f..c418c27561 100644 --- a/lib/core/src/lib/auth/mock/authentication.service.mock.ts +++ b/lib/core/src/lib/auth/mock/authentication.service.mock.ts @@ -50,4 +50,8 @@ export class AuthenticationMock extends AuthenticationService { return throwError('Fake server error'); } + + logout(): Observable { + return of({}); + } } diff --git a/lib/core/src/lib/testing/core.testing.module.ts b/lib/core/src/lib/testing/core.testing.module.ts index 8bab775717..b7dba3f9f7 100644 --- a/lib/core/src/lib/testing/core.testing.module.ts +++ b/lib/core/src/lib/testing/core.testing.module.ts @@ -33,7 +33,7 @@ import { HttpClientModule } from '@angular/common/http'; import { directionalityConfigFactory } from '../common/services/directionality-config-factory'; import { DirectionalityConfigService } from '../common/services/directionality-config.service'; import { AuthModule, RedirectAuthService } from '../auth'; -import { EMPTY } from 'rxjs'; +import { EMPTY, of } from 'rxjs'; @NgModule({ imports: [ @@ -56,7 +56,7 @@ import { EMPTY } from 'rxjs'; deps: [DirectionalityConfigService], multi: true }, - { provide: RedirectAuthService, useValue: { onLogin: EMPTY, init: () => {} } } + { provide: RedirectAuthService, useValue: { onLogin: EMPTY, init: () => {}, onTokenReceived: of() } } ], exports: [NoopAnimationsModule, CoreModule, TranslateModule, RouterTestingModule] })