fix protractor report

fix validation
fix log deprecated
fix ADF-3576 Single required dropdown column dynamicgrid aps-form row editor not saving

lib/core/form/components/widgets/core/form.model.ts

@@ -201,9 +201,7 @@ export class FormModel {
             }
         }
 
-        if (errorsField.length > 0) {
-            this._isValid = false;
-        }
+        this._isValid = errorsField.length > 0 ? false : true;
 
         if (this.formService) {
             validateFormEvent.isValid = this._isValid;

lib/core/form/components/widgets/dynamic-table/editors/dropdown/dropdown.editor.html

@@ -8,7 +8,7 @@
             [(ngModel)]="value"
             [required]="column.required"
             [disabled]="!column.editable"
-            (selectionChange)="onValueChanged(row, column, $event)">
+            (ngModelChange)="onValueChanged(row, column, $event)">
             <mat-option></mat-option>
             <mat-option *ngFor="let opt of options" [value]="opt.name" [id]="opt.id">{{opt.name}}</mat-option>
         </mat-select>

lib/core/services/settings.service.ts

@@ -72,7 +72,7 @@ export class SettingsService {
 
     /** @deprecated in 1.7.0 */
     public setProviders(providers: string) {
-        this.logService.log(`SettingsService.aetProviders is deprecated. Use the app-config.json`);
+        this.logService.log(`SettingsService.setProviders is deprecated. Use the app-config.json`);
         if (providers) {
             this.storage.setItem(AppConfigValues.PROVIDERS, providers);
         }

lib/core/viewer/components/viewer.component.html

@@ -142,8 +142,6 @@
         </ng-container>
 
         <div fxLayout="row" fxFlex="1 1 auto">
-            showSidebar 1 {{showSidebar}}
-
             <ng-container *ngIf="allowSidebar && showSidebar">
                 showSidebar {{showSidebar}}
                 <div class="adf-viewer__sidebar" [ngClass]="'adf-viewer__sidebar__right'" fxFlexOrder="4"  id="adf-right-sidebar" >

lib/process-services/task-list/components/task-details.component.html

@@ -124,7 +124,7 @@
             <div *ngIf="showHeaderContent" class="adf-task-details-core-sidebar-checklist">
                 <div *ngIf="showChecklist">
                     <adf-checklist #activitichecklist
-                                   [readOnly]="readOnlyForm"
+                                   [readOnly]="internalReadOnlyForm"
                                    [taskId]="taskDetails.id"
                                    [assignee]="taskDetails?.assignee?.id"
                                    (checklistTaskCreated)="onChecklistTaskCreated($event)"

lib/process-services/task-list/components/task-details.component.ts

@@ -175,6 +175,7 @@ export class TaskDetailsComponent implements OnInit, OnChanges {
 
     showAssignee: boolean = false;
     showAttachForm: boolean = false;
+    internalReadOnlyForm: boolean = false;
 
     private peopleSearchObserver: Observer<UserProcessModel[]>;
     public errorDialogRef: MatDialogRef<TemplateRef<any>>;
@@ -306,7 +307,9 @@ export class TaskDetailsComponent implements OnInit, OnChanges {
 
                     let endDate: any = res.endDate;
                     if (endDate && !isNaN(endDate.getTime())) {
-                        this.readOnlyForm = true;
+                        this.internalReadOnlyForm = true;
+                    } else {
+                        this.internalReadOnlyForm = this.readOnlyForm
                     }
 
                     if (this.taskDetails && this.taskDetails.involvedPeople) {