fix protractor report

fix validation
fix log deprecated
fix ADF-3576 Single required dropdown column dynamicgrid aps-form row editor not saving
This commit is contained in:
Eugenio Romano
2018-09-21 15:18:06 +01:00
parent 6e72a84d13
commit bd5be8912f
7 changed files with 81 additions and 66 deletions

View File

@@ -201,9 +201,7 @@ export class FormModel {
}
}
if (errorsField.length > 0) {
this._isValid = false;
}
this._isValid = errorsField.length > 0 ? false : true;
if (this.formService) {
validateFormEvent.isValid = this._isValid;

View File

@@ -8,7 +8,7 @@
[(ngModel)]="value"
[required]="column.required"
[disabled]="!column.editable"
(selectionChange)="onValueChanged(row, column, $event)">
(ngModelChange)="onValueChanged(row, column, $event)">
<mat-option></mat-option>
<mat-option *ngFor="let opt of options" [value]="opt.name" [id]="opt.id">{{opt.name}}</mat-option>
</mat-select>

View File

@@ -72,7 +72,7 @@ export class SettingsService {
/** @deprecated in 1.7.0 */
public setProviders(providers: string) {
this.logService.log(`SettingsService.aetProviders is deprecated. Use the app-config.json`);
this.logService.log(`SettingsService.setProviders is deprecated. Use the app-config.json`);
if (providers) {
this.storage.setItem(AppConfigValues.PROVIDERS, providers);
}

View File

@@ -142,8 +142,6 @@
</ng-container>
<div fxLayout="row" fxFlex="1 1 auto">
showSidebar 1 {{showSidebar}}
<ng-container *ngIf="allowSidebar && showSidebar">
showSidebar {{showSidebar}}
<div class="adf-viewer__sidebar" [ngClass]="'adf-viewer__sidebar__right'" fxFlexOrder="4" id="adf-right-sidebar" >