From be4aec7e0764db0f811dd714140a8000b08caada Mon Sep 17 00:00:00 2001 From: Will Abson Date: Thu, 13 Oct 2016 12:54:17 +0100 Subject: [PATCH] Refactor mocks into external file --- .../assets/alfresco-search.service.mock.ts | 63 +++++++++++++++++++ .../services/alfresco-search.service.spec.ts | 48 +------------- 2 files changed, 64 insertions(+), 47 deletions(-) create mode 100644 ng2-components/ng2-alfresco-search/src/assets/alfresco-search.service.mock.ts diff --git a/ng2-components/ng2-alfresco-search/src/assets/alfresco-search.service.mock.ts b/ng2-components/ng2-alfresco-search/src/assets/alfresco-search.service.mock.ts new file mode 100644 index 0000000000..0f15f11a81 --- /dev/null +++ b/ng2-components/ng2-alfresco-search/src/assets/alfresco-search.service.mock.ts @@ -0,0 +1,63 @@ +/*! + * @license + * Copyright 2016 Alfresco Software, Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +export var fakeSearch = { + list: { + pagination: { + count: 1, + hasMoreItems: false, + totalItems: 1, + skipCount: 0, + maxItems: 100 + }, + entries: [ + { + entry: { + id: '123', + name: 'MyDoc', + content: { + mimetype: 'text/plain' + }, + createdByUser: { + displayName: 'John Doe' + }, + modifiedByUser: { + displayName: 'John Doe' + } + } + } + ] + } +}; + +export var fakeError = { + error: { + errorKey: 'Search failed', + statusCode: 400, + briefSummary: '08220082 search failed', + stackTrace: 'For security reasons the stack trace is no longer displayed, but the property is kept for previous versions.', + descriptionURL: 'https://api-explorer.alfresco.com' + } +}; + +export var fakeApi = { + core: { + searchApi: { + liveSearchNodes: (term, opts) => Promise.resolve(fakeSearch) + } + } +}; diff --git a/ng2-components/ng2-alfresco-search/src/services/alfresco-search.service.spec.ts b/ng2-components/ng2-alfresco-search/src/services/alfresco-search.service.spec.ts index 8a9d531352..56f0093492 100644 --- a/ng2-components/ng2-alfresco-search/src/services/alfresco-search.service.spec.ts +++ b/ng2-components/ng2-alfresco-search/src/services/alfresco-search.service.spec.ts @@ -18,6 +18,7 @@ import { ReflectiveInjector } from '@angular/core'; import { AlfrescoSearchService } from './alfresco-search.service'; import { AlfrescoAuthenticationService, AlfrescoSettingsService, AlfrescoApiService } from 'ng2-alfresco-core'; +import { fakeApi, fakeSearch, fakeError } from '../assets/alfresco-search.service.mock'; declare let jasmine: any; @@ -27,53 +28,6 @@ describe('AlfrescoSearchService', () => { let authenticationService: AlfrescoAuthenticationService; let injector: ReflectiveInjector; - let fakeSearch = { - list: { - pagination: { - count: 1, - hasMoreItems: false, - totalItems: 1, - skipCount: 0, - maxItems: 100 - }, - entries: [ - { - entry: { - id: '123', - name: 'MyDoc', - content: { - mimetype: 'text/plain' - }, - createdByUser: { - displayName: 'John Doe' - }, - modifiedByUser: { - displayName: 'John Doe' - } - } - } - ] - } - }; - - let fakeError = { - error: { - errorKey: 'Search failed', - statusCode: 400, - briefSummary: '08220082 search failed', - stackTrace: 'For security reasons the stack trace is no longer displayed, but the property is kept for previous versions.', - descriptionURL: 'https://api-explorer.alfresco.com' - } - }; - - let fakeApi = { - core: { - searchApi: { - liveSearchNodes: (term, opts) => Promise.resolve(fakeSearch) - } - } - }; - beforeEach(() => { injector = ReflectiveInjector.resolveAndCreate([ AlfrescoSearchService,