inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-05-12 17:04:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-2405] Reverted service to get all process definition versions (#3079)

Browse Source 
AnalyticsService.getProcessDefinitionsValues() has same behaviour
This commit is contained in:
Deepak Paul 2018-03-15 05:06:39 +05:30 committed by Eugenio Romano
parent 86cc219bc4
commit c27273cb7d
2 changed files with 0 additions and 74 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
lib/process-services/process-list/services/process.service.spec.ts
View File

@ -341,65 +341,6 @@ describe('ProcessService', () => {
});
describe('process definition versions', () => {
let getProcessDefinitionVersions: jasmine.Spy;
beforeEach(() => {
getProcessDefinitionVersions = spyOn(alfrescoApi.activiti.processApi, 'getProcessDefinitions')
.and
.returnValue(Promise.resolve({ data: [ fakeProcessDef, fakeProcessDef ] }));
});
it('should return the correct number of process defs', async(() => {
service.getProcessDefinitionVersions().subscribe((defs) => {
expect(defs.length).toBe(2);
});
}));
it('should return the correct process def data', async(() => {
service.getProcessDefinitionVersions().subscribe((defs) => {
expect(defs[0].id).toBe(fakeProcessDef.id);
expect(defs[0].key).toBe(fakeProcessDef.key);
expect(defs[0].name).toBe(fakeProcessDef.name);
});
}));
it('should call API with correct parameters when no appId provided', () => {
service.getProcessDefinitionVersions();
expect(getProcessDefinitionVersions).toHaveBeenCalledWith({});
});
it('should call API with correct parameters when appId provided', () => {
const appId = 1;
service.getProcessDefinitionVersions(appId);
expect(getProcessDefinitionVersions).toHaveBeenCalledWith({
appDefinitionId: appId
});
});
it('should pass on any error that is returned by the API', async(() => {
getProcessDefinitionVersions = getProcessDefinitionVersions.and.returnValue(Promise.reject(mockError));
service.getProcessDefinitionVersions().subscribe(
() => {},
(res) => {
expect(res).toBe(mockError);
}
);
}));
it('should return a default error if no data is returned by the API', async(() => {
getProcessDefinitionVersions = getProcessDefinitionVersions.and.returnValue(Promise.reject(null));
service.getProcessDefinitionVersions().subscribe(
() => {},
(res) => {
expect(res).toBe('Server error');
}
);
}));
});
describe('process instance tasks', () => {
const processId = '1001';

15
lib/process-services/process-list/services/process.service.ts
View File

@ -119,21 +119,6 @@ export class ProcessService {
.catch(err => this.handleProcessError(err));
}
/**
* Gets the versions of process definitions associated with an app.
* @param appId ID of a target app
*/
getProcessDefinitionVersions(appId?: number): Observable<ProcessDefinitionRepresentation[]> {
const opts = appId ? { appDefinitionId: appId } : {};
return Observable.fromPromise(
this.alfrescoApiService.getInstance().activiti.processApi.getProcessDefinitions(opts)
)
.map(this.extractData)
.map(processDefs => processDefs.map((pd) => new ProcessDefinitionRepresentation(pd)))
.catch(err => this.handleProcessError(err));
}
/**
* Starts a process based on a process definition, name, form values or variables.
* @param processDefinitionId Process definition ID