From c533b4ec35673337d2e9a22c6e53c5cb24a11bdc Mon Sep 17 00:00:00 2001
From: Vito <vito.albano@alfresco.com>
Date: Wed, 19 May 2021 17:18:57 +0100
Subject: [PATCH] [ACA-4445] - disabled edit aspect button on content card for
 ACS version below 7 (#7043)

---
 .../content-metadata-card.component.html          |  2 +-
 .../content-metadata-card.component.spec.ts       | 15 +++++++++++++++
 .../content-metadata-card.component.ts            | 11 +++++++++--
 3 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.html b/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.html
index 2591517d1c..ada1a528f2 100644
--- a/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.html
+++ b/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.html
@@ -13,7 +13,7 @@
     </mat-card-content>
     <mat-card-footer class="adf-content-metadata-card-footer" fxLayout="row" fxLayoutAlign="space-between stretch">
         <div>
-            <button *ngIf="!readOnly && hasAllowableOperations()"
+            <button *ngIf="isEditAspectSupported()"
                 mat-icon-button
                 (click)="openAspectDialog()"
                 [attr.title]="'CORE.METADATA.ACTIONS.EDIT_ASPECTS' | translate"
diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.spec.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.spec.ts
index 4a49def0e8..a6f20d6b56 100644
--- a/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.spec.ts
+++ b/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.spec.ts
@@ -59,6 +59,7 @@ describe('ContentMetadataCardComponent', () => {
 
         component.node = node;
         component.preset = preset;
+        component.editAspectSupported = true;
         nodeAspectService = TestBed.inject(NodeAspectService);
         spyOn(contentMetadataService, 'getContentTypeProperty').and.returnValue(of([]));
         fixture.detectChanges();
@@ -220,6 +221,7 @@ describe('ContentMetadataCardComponent', () => {
         component.node.id = 'fake-node-id';
         component.node.allowableOperations = [AllowableOperationsEnum.UPDATE];
         spyOn(nodeAspectService, 'updateNodeAspects').and.stub();
+
         fixture.detectChanges();
 
         const button = fixture.debugElement.query(By.css('[data-automation-id="meta-data-card-edit-aspect"]'));
@@ -228,4 +230,17 @@ describe('ContentMetadataCardComponent', () => {
 
         expect(nodeAspectService.updateNodeAspects).toHaveBeenCalledWith('fake-node-id');
     });
+
+    it('should not show the edit aspect button if ACS version is not supported', () => {
+        component.editable = true;
+        component.node.id = 'fake-node-id';
+        component.node.allowableOperations = [AllowableOperationsEnum.UPDATE];
+        spyOn(nodeAspectService, 'updateNodeAspects').and.stub();
+        component.editAspectSupported = false;
+        fixture.detectChanges();
+
+        const button = fixture.debugElement.query(By.css('[data-automation-id="meta-data-card-edit-aspect"]'));
+
+        expect(button).toBeNull();
+    });
 });
diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.ts
index 50100e8c7c..78acf4e501 100644
--- a/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.ts
+++ b/lib/content-services/src/lib/content-metadata/components/content-metadata-card/content-metadata-card.component.ts
@@ -17,7 +17,7 @@
 
 import { Component, Input, OnChanges, SimpleChanges, ViewEncapsulation } from '@angular/core';
 import { Node } from '@alfresco/js-api';
-import { ContentService, AllowableOperationsEnum } from '@alfresco/adf-core';
+import { ContentService, AllowableOperationsEnum, VersionCompatibilityService } from '@alfresco/adf-core';
 import { NodeAspectService } from '../../../aspect-list/node-aspect.service';
 @Component({
     selector: 'adf-content-metadata-card',
@@ -81,7 +81,10 @@ export class ContentMetadataCardComponent implements OnChanges {
 
     expanded: boolean;
 
-    constructor(private contentService: ContentService, private nodeAspectService: NodeAspectService) {
+    editAspectSupported = false;
+
+    constructor(private contentService: ContentService, private nodeAspectService: NodeAspectService, private versionCompatibilityService: VersionCompatibilityService) {
+        this.editAspectSupported = this.versionCompatibilityService.isVersionSupported('7');
     }
 
     ngOnChanges(changes: SimpleChanges): void {
@@ -109,4 +112,8 @@ export class ContentMetadataCardComponent implements OnChanges {
     openAspectDialog() {
         this.nodeAspectService.updateNodeAspects(this.node.id);
     }
+
+    isEditAspectSupported(): boolean {
+        return !this.readOnly && this.hasAllowableOperations() && this.editAspectSupported;
+    }
 }