diff --git a/lib/js-api/src/axiosHttpClient.ts b/lib/js-api/src/axiosHttpClient.ts index 316ad7b3b7..548f175efd 100644 --- a/lib/js-api/src/axiosHttpClient.ts +++ b/lib/js-api/src/axiosHttpClient.ts @@ -258,7 +258,7 @@ export class AxiosHttpClient implements HttpClient { try { document.cookie = `CSRF-TOKEN=${token};path=/`; - } catch (err) { + } catch { /* continue regardless of error */ } } diff --git a/lib/js-api/test/alfrescoApi.spec.ts b/lib/js-api/test/alfrescoApi.spec.ts index 6101b253c9..2df2549d54 100644 --- a/lib/js-api/test/alfrescoApi.spec.ts +++ b/lib/js-api/test/alfrescoApi.spec.ts @@ -18,6 +18,7 @@ import assert from 'assert'; import { AlfrescoApi } from '../src'; import { BpmAuthMock, EcmAuthMock, OAuthMock } from './mockObjects'; +import nock from 'nock'; describe('Basic configuration test', () => { describe('config parameter ', () => { @@ -209,16 +210,23 @@ describe('Basic configuration test', () => { }); describe('login', () => { + beforeEach(() => { + nock.cleanAll(); + }); + it('Should login be rejected if username or password are not provided', async () => { + const hostEcm = 'https://testServer.com:1616'; + const authEcmMock = new EcmAuthMock(hostEcm); // ✅ HAS MOCK + const config = { - hostEcm: 'https://testServer.com:1616', + hostEcm, contextRoot: 'strangeContextRoot', withCredentials: true }; const alfrescoJsApi = new AlfrescoApi(config); let error; - + authEcmMock.get401InvalidRequest(); try { await alfrescoJsApi.login(undefined, undefined); } catch (e) { diff --git a/lib/js-api/test/mockObjects/content-services/ecm-auth.mock.ts b/lib/js-api/test/mockObjects/content-services/ecm-auth.mock.ts index dd109fdd40..19ea2fc8f9 100644 --- a/lib/js-api/test/mockObjects/content-services/ecm-auth.mock.ts +++ b/lib/js-api/test/mockObjects/content-services/ecm-auth.mock.ts @@ -82,6 +82,20 @@ export class EcmAuthMock extends BaseMock { }); } + get401InvalidRequest(): void { + this.createNockWithCors() + .get('/.*tickets.*/') + .reply(401, { + error: { + errorKey: 'framework.exception.ApiDefault', + statusCode: 401, + briefSummary: '05210059 Authentication failed for Web Script org/alfresco/api/ResourceWebScript.get', + stackTrace: 'For security reasons the stack trace is no longer displayed, but the property is kept for previous versions.', + descriptionURL: 'https://api-explorer.alfresco.com' + } + }); + } + get403Response(): void { this.createNockWithCors() .post('/alfresco/api/-default-/public/authentication/versions/1/tickets', {